The @dataProvider annotation should be a static function, make
- ExtensionServicesTestBase::provideMethods
static and adjust the usages (More infos at T332865).
Description
Description
Details
Details
Related Changes in Gerrit:
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Stalled | None | T334726 Use return type `never` in Wikibase | |||
| Open | None | T232915 Red-green in PHPUnit code coverage are hard to read | |||
| Open | None | T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10 | |||
| Open | None | T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min | |||
| Open | None | T332865 PHPUnit data providers should be simple static functions that return plain data | |||
| Resolved | Umherirrender | T393207 Make PHPUnit dataProvider on ExtensionServicesTestBase static |
Event Timeline
Comment Actions
Change #1146709 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] tests: Make PHPUnit data provider static in ExtensionServicesTestBase
Comment Actions
Change #1146710 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/AbuseFilter@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146711 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/CampaignEvents@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146712 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/Cognate@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146713 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/EntitySchema@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146714 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/Wikibase@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146715 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146709 merged by jenkins-bot:
[mediawiki/core@master] tests: Make PHPUnit data provider static in ExtensionServicesTestBase
Comment Actions
Change #1146710 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146711 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146715 merged by jenkins-bot:
[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146714 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146713 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Change #1146712 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] tests: Make class property static in ExtensionServicesTest
Comment Actions
Made a follow-up to drop the BC code: T416513: Drop non-static $className in ExtensionServicesTestBase