Make PHPUnit dataProvider on RestStructureTest static
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 2 2025, 9:24 PM

Description

The @dataProvider annotation should be a static function, the following data provider are not static

(More infos at T332865).

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Remove two data provider in RestStructureTest	mediawiki/core	master	+94 -160

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T232915 Red-green in PHPUnit code coverage are hard to read
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	Umherirrender	T393219 Make PHPUnit dataProvider on RestStructureTest static

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

daniel moved this task from Backlog to To Refine on the MW-Interfaces-Team board.

Change #1147069 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Remove two data provider in RestStructureTest

Change #1147069 merged by jenkins-bot:

[mediawiki/core@master] tests: Remove two data provider in RestStructureTest