Page MenuHomePhabricator

SecurityPatchBot: Reopen security task if any of its patches is failing to apply
Closed, ResolvedPublic

Description

@A_smart_kitten proposed the following:

(side note @jnuche, if the bot is flagging a closed security task as a train blocker, should it also reopen the task in question for additional visibility? i’m just thinking to avoid the potential risk of people seeing an already-closed train-blocker-subtask, and - based on its 'closed' status - thinking that the train-blocking issue has already been resolved.)

I'm in favor of that. Pinging @thcipriani and @sbassett for visibility

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
patches: ensure a security task notified of a failure is openrepos/releng/scap!790jnucheT393361master
Customize query in GitLab

Event Timeline

IMO if SecurityPatchBot is resetting task priority, especially to UBN, it should definitely re-open the task if the task has been closed.

jnuche claimed this task.

This is in prod now