Page MenuHomePhabricator
Create Task
Maniphest T393465

Domain Events: Extensions Migrations
Open, MediumPublic0 Estimated Story Points
Actions

Description

For the Domain Events work T393004, This ticket tracks migration of Extensions using the old Page events hooks to the new Event classes. The goal of this work is to move towards deprecation for the hooks that can be replaced by DomainEvents.

Extension adoption:

  • PageMove: 12 extensions
  • PageDelete: 7 extensions

Candidate extensions:

  • EventBus
  • AbuseFilter
    • AbuseFilter - PaveMove
    • AbuseFilter - PageSave
    • -AbuseFilter - ArticleDelete-
  • Echo
    • Echo - PageSave
    • Echo - ArticleDeleteComplete
  • CirrusSearch
    • CirrusSearch - PageDelete
    • CirrusSearch - PageDeleteComplete
    • CirrusSearch - PageMoveComplete
  • TimedMediaHandler --> Currently unowned
    • TimedMediaHandler - PageDeleteComplete
    • TimedMediaHandler - PageMoveComplete
    • TimedMediaHandler - PageSaveComplete
    • -TimedMediaHandler - RevisionFromEditComplete-
  • CampaignEvents
    • CampaignEvents - PageMoveComplete
    • CampaignEvents - PageDeleteComplete
  • WIkibase --> WMDE
    • TBD
NOTE: We are tracking completion of extension migrations here: https://docs.google.com/spreadsheets/d/14CX7wFaAjnkCmi3z9lykX9DPlbv1Zc3XpM73ToxRtNI/edit?gid=267846005#gid=267846005 This tracker can also be used to confirm which extensions are using which hooks.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
DomainEvents: Port Page hooks to Page eventsAtienomediawiki/extensions/TimedMediaHandlermaster+275 -120
DomainEvents: Port PageMoved and PageDeletedAtienomediawiki/extensions/CampaignEventsmaster+391 -286
DomainEvents: Port onArticleDeleteCompleteAtienomediawiki/extensions/Echomaster+92 -38
DomainEvents: Port onPageDelete hook to PageDeletedEventAtienomediawiki/extensions/AbuseFiltermaster+50 -34
DomainEvents: Port onPageSaveComplete hook to PageUpdatedEventAtienomediawiki/extensions/Echomaster+158 -138
DomainEvents: Port onPageSaveComplete hook to PageUpdatedEventAtienomediawiki/extensions/AbuseFiltermaster+48 -30
DomainEvents: Port onPageSaveComplete hook to PageUpdatedEventAtienomediawiki/extensions/Echomaster+155 -130
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Atieno created this task.May 6 2025, 1:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2025, 1:20 PM
• Atieno added a project: MediaWiki-API-Platform-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)).May 6 2025, 1:21 PM
• Atieno added a subtask: T393466: Investigate porting onPageSaveComplete to PageUpdated event for all Extensions.May 6 2025, 1:27 PM
OWresch-WMF set the point value for this task to 0.May 6 2025, 3:05 PM
Aklapper added a project: MediaWiki-DomainEvents.May 6 2025, 7:14 PM

Please add code project tags.

OWresch-WMF triaged this task as Medium priority.May 7 2025, 11:44 AM
daniel subscribed.May 9 2025, 12:18 PM

Looks like this is the same as T393005: In extensions, use domain events instead of hooks where appropriate. @Atieno which way do you want to merge?

HCoplin-WMF edited projects, added: MediaWiki-API-Platform-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)); removed: MediaWiki-API-Platform-Team (MW-Sprint-8 (2025-04-23 to 2025-05-06)).May 9 2025, 6:12 PM
gerritbot added a comment.May 12 2025, 4:19 PM

Change #1144609 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/Echo@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1144609

gerritbot added a project: Patch-For-Review.May 12 2025, 4:20 PM
gerritbot added a comment.May 13 2025, 12:12 PM

Change #1145175 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/AbuseFilter@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1145175

gerritbot added a comment.May 20 2025, 11:57 AM

Change #1148316 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/Echo@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1148316

gerritbot added a comment.May 20 2025, 11:59 AM

Change #1144609 abandoned by Atieno:

[mediawiki/extensions/Echo@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

Reason:

This was in master causing branching conflict hullabaloo...New branched MR https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/1148316

https://gerrit.wikimedia.org/r/1144609

HCoplin-WMF edited projects, added: OKR-Work, Epic, MediaWiki-API-Platform-Team (MWI-Roadmap); removed: MediaWiki-API-Platform-Team (MW-Sprint-9 (2025-05-07 to 2025-05-20)).May 20 2025, 3:04 PM
HCoplin-WMF updated the task description. (Show Details)May 20 2025, 3:16 PM
HCoplin-WMF updated the task description. (Show Details)May 20 2025, 3:20 PM
daniel added a subtask: T395835: Introduce a domain event to represent changes to revision visibility (suppression).Jun 2 2025, 8:37 PM
gerritbot added a comment.Jun 3 2025, 6:55 PM

Change #1153335 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/AbuseFilter@master] DomainEvents: Port onPageDelete hook to PageDeletedEvent

https://gerrit.wikimedia.org/r/1153335

• Atieno updated the task description. (Show Details)Jun 3 2025, 7:09 PM
gerritbot added a comment.Jun 4 2025, 10:27 AM

Change #1153575 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/TimedMediaHandler@master] DomainEvents: Port Page hooks to Page events

https://gerrit.wikimedia.org/r/1153575

gerritbot added a comment.Jun 7 2025, 2:16 AM

Change #1148316 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1148316

HCoplin-WMF updated the task description. (Show Details)Jun 12 2025, 2:55 PM
A_smart_kitten added a project: MediaWiki-extensions-General.Jun 12 2025, 3:06 PM
HCoplin-WMF updated the task description. (Show Details)Jun 12 2025, 3:07 PM
HCoplin-WMF closed subtask T396757: TimedMediaHandler: Port onPageSaveComplete and onRevisionFromEditComplete to PageUpdated as Invalid.Jun 12 2025, 3:15 PM
HCoplin-WMF closed subtask T396759: TimedMediaHandler: Port onPageDeleteComplete to PageDeleted as Invalid.
gerritbot added a comment.Jun 17 2025, 9:08 PM

Change #1145175 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] DomainEvents: Port onPageSaveComplete hook to PageUpdatedEvent

https://gerrit.wikimedia.org/r/1145175

• Atieno updated the task description. (Show Details)Jun 24 2025, 12:17 PM

Not seeing ArticleDelete for AbuseFilter

gerritbot added a comment.Jun 24 2025, 12:18 PM

Change #1153335 abandoned by Atieno:

[mediawiki/extensions/AbuseFilter@master] DomainEvents: Port onPageDelete hook to PageDeletedEvent

https://gerrit.wikimedia.org/r/1153335

gerritbot added a comment.Jun 24 2025, 12:35 PM

Change #1163352 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/Echo@master] DomainEvents: Port onArticleDeleteComplete

https://gerrit.wikimedia.org/r/1163352

gerritbot added a comment.Jun 24 2025, 12:51 PM

Change #1163357 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/CampaignEvents@master] DomainEvents: Port PageMoved and PageUpdated

https://gerrit.wikimedia.org/r/1163357

• Atieno updated the task description. (Show Details)Jun 24 2025, 1:20 PM
Daimona added a project: CampaignEvents.Jun 24 2025, 5:33 PM
HCoplin-WMF closed subtask T395835: Introduce a domain event to represent changes to revision visibility (suppression) as Resolved.Jul 2 2025, 1:52 PM
HCoplin-WMF moved this task from Now to Parking Lot on the MediaWiki-API-Platform-Team (MWI-Roadmap) board.Jul 7 2025, 1:53 PM
gerritbot added a comment.Jul 24 2025, 8:19 AM

Change #1163352 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] DomainEvents: Port onArticleDeleteComplete

https://gerrit.wikimedia.org/r/1163352

HCoplin-WMF closed subtask T396756: Echo: Port onArticleDeleteComplete hook to PageDeleted event as Resolved.Aug 18 2025, 12:45 PM
gerritbot added a comment.Aug 18 2025, 6:10 PM

Change #1163357 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] DomainEvents: Port PageMoved and PageDeleted

https://gerrit.wikimedia.org/r/1163357

HCoplin-WMF closed subtask T396762: CampaignEvents: Port all hooks to relevant domain events as Resolved.Sep 10 2025, 7:46 PM
Restricted Application added a project: Connection-Team. · View Herald TranscriptSep 10 2025, 7:46 PM
Pppery mentioned this in T400050: Special:Undelete Wikimedia\Rdbms\DBQueryError: Error 1062: Duplicate entry 'tp:transver-###-###' for key 'PRIMARY'.Dec 18 2025, 6:20 PM
gerritbot added a comment.Mar 3 2026, 8:12 PM

Change #1153575 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] DomainEvents: Port Page hooks to Page events

https://gerrit.wikimedia.org/r/1153575

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2026, 8:31 PM
TheDJ closed subtask T396758: TimedMediaHandler: Port all hooks to relevant domain events as Resolved.Mar 4 2026, 1:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits