Page MenuHomePhabricator
Create Task
Maniphest T393570

Ensure pre-save edit checks know whether a user has interacted with mid-edit equivalents
Closed, ResolvedPublicBUG REPORT
Actions

Description

Based on task T392871: Ensure the Peacock Check card is displayed during the Pre-Save moment if someone does not elect to Revise or Decline during the Mid-Edit moment.

QA steps

  1. Edit a page with VE
  2. Add three new paragraphs, along the lines of:
    1. This is a magnificent paragraph which I will be revising
    2. This is a superlatively excellent paragraph which I will be declining
    3. This is an extremely excellent paragraph which I will not be touching
  3. Ensure you got three revision edit checks. You might get a citation one too.
  4. Hit 'Revise' on the first paragraph's edit check
  5. Hit 'Decline' on the second one
  6. Press 'Save Changes'
  7. Confirm that only the final paragraph has a pre-save edit check
  8. Revise that paragraph. You should be returned to the usual editing session. Only the dismissed paragraph doesn't have an edit check now.

Related Objects
Search...

Event Timeline

zoe created this task.May 7 2025, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2025, 10:27 AM
zoe claimed this task.May 7 2025, 10:28 AM
zoe added projects: VisualEditor, EditCheck.
zoe added a parent task: T392871: Create Tone Check Patch demo for concept validation.
zoe added a subscriber: ppelberg.
ppelberg mentioned this in T392871: Create Tone Check Patch demo for concept validation.May 9 2025, 7:19 PM
ppelberg added a project: Editing-team (Kanban Board).May 9 2025, 7:35 PM
ppelberg added a project: OKR-Work.
ppelberg moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.
PatchDemoBot added a comment.May 12 2025, 5:25 PM

Test wiki created on Patch demo by Zoe-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/5d24bcfa36/w/

ppelberg added a project: Goal.May 15 2025, 7:21 PM
PatchDemoBot added a comment.May 16 2025, 4:09 PM

Test wiki created on Patch demo by Zoe-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/46e5084a5f/w/

zoe added a comment.May 16 2025, 4:12 PM

I think this is working okay. If you interact at all with a check during pre-save it shoudln't appear during the pre-save.

zoe added a comment.May 16 2025, 4:12 PM
In T393570#10830569, @zoe wrote:

I think this is working okay. If you interact at all with a check during normal editing it shoudln't appear during the pre-save.

PatchDemoBot added a comment.May 16 2025, 7:25 PM

Test wiki on Patch demo by Zoe-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/46e5084a5f/w/

PatchDemoBot added a comment.May 16 2025, 7:28 PM

Test wiki on Patch demo by Zoe-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/5d24bcfa36/w/

ppelberg added a comment.May 19 2025, 5:23 PM

Next step(s)

  • Editing Engineering to take on work of ensuring save dialog waits for asynchronous edit checks to complete in T394711
  • @zoe to update task description to include QA steps
  • @zoe to move ticket to QA (high priority)
ppelberg removed a parent task: T392871: Create Tone Check Patch demo for concept validation.May 20 2025, 5:15 PM
ppelberg added a parent task: T394818: Merge Tone Check proof of concept .
zoe updated the task description. (Show Details)May 21 2025, 4:27 PM
PatchDemoBot added a comment.May 21 2025, 4:32 PM

Test wiki created on Patch demo by Zoe-WMF using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/1b1089a907/w/

zoe triaged this task as High priority.May 22 2025, 9:12 AM
zoe moved this task from Doing to QA on the Editing-team (Kanban Board) board.
zoe added a project: Editing QA.
In T393570#10836100, @ppelberg wrote:

Next step(s)

  • Editing Engineering to take on work of ensuring save dialog waits for asynchronous edit checks to complete in T394711
  • @zoe to update task description to include QA steps
  • @zoe to move ticket to QA (high priority)
Ryasmeen moved this task from Inbox to High Priority on the Editing QA board.May 22 2025, 6:13 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 22 2025, 9:15 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
Ryasmeen subscribed.

Both the Revised paragraph and the Dismissed paragraph get their Edit Check card removed.

ppelberg closed this task as Resolved.Jul 12 2025, 12:03 AM
PatchDemoBot added a comment.Aug 12 2025, 2:20 AM

Test wiki on Patch demo by Zoe-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/1b1089a907/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits