[ReadingLists] Move bookmark action button to toolbar
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdrewniak
	May 7 2025, 3:04 PM

Description

Background

In T390762 we enabled adding an article to the default reading list. This task will define the work required to move the "Bookmark" menu item from the Tools -> Actions menu into the toolbar next to the watchstar icon.

User story

As a user, I'd like to easily add an article to my default reading list.

Requirements

A bookmark icon exists next to the watchstar icon
Clicking the bookmark icon will add the article to a users default reading list.
If the article is already added to the default reading list, clicking the bookmark icon will remove it.

BDD

Feature: Optimized reading list bookmark behavior

Scenario: No API request on page load
  Given the reading list beta feature is enabled
  When I open the network tab and visit any article
  Then a bookmark icon appears next to the watchstar on both Minerva and Vector skins
  And no reading list API request occurs on page load

Test Steps

Test Case 1: Verify no reading list API request on page load

Precondition: Make sure you have enabled the Reading List beta feature in user preferences.

Log in with an existing user account.
Open the browser DevTools and switch to the Network tab.
Navigate to any article page (e.g., /wiki/Dog) on the beta cluster.
AC1: Confirm a bookmark icon appears next to the watchstar in both Minerva and Vector skins.
AC2: Confirm no API requests related to reading lists are triggered automatically on page load.

Precondition: Create a new user account and enable the Reading List beta feature.

Navigate to any article page (e.g., /wiki/Cat).
AC3: Confirm no API requests related to reading lists are triggered on page load.
Click the bookmark icon next to the watchstar.
AC4: Confirm the article is added to a newly created default reading list (no errors).
Refresh the page.
AC5: Confirm the bookmark icon remains filled, indicating the article is successfully saved.

Design


button when article has been added to default reading list	Button when article has not been added to default reading list

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix Reading Lists user link translation	mediawiki/extensions/ReadingLists	master	+1 -1
	bookmark: Move action button to toolbar	mediawiki/extensions/ReadingLists	master	+371 -82

Customize query in gerrit

Related Objects

Mentioned In: T394329: Verify 1.45.0-wmf.3 deployment
T394328: Verify 1.45.0-wmf.2 deployment
T394736: Beta cluster: data-list-id is not being added on bookmark link
T394562: Hide the watchstar and watchlist when the reading list beta feature is enabled
T390762: API: Optimize the bookmark action
Mentioned Here: T394736: Beta cluster: data-list-id is not being added on bookmark link
T394560: Minerva doesn't support outputting custom data attributes
T390762: API: Optimize the bookmark action

Event Timeline

Jdrewniak created this task.May 7 2025, 3:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2025, 3:04 PM

Jdrewniak attached a referenced file: F58968589: image.png. (Show Details)May 7 2025, 3:04 PM

Jdrewniak attached a referenced file: F58968592: image.png. (Show Details)

Jdlrobson-WMF triaged this task as Medium priority.May 7 2025, 4:09 PM

Jdlrobson-WMF set the point value for this task to 3.

Jdlrobson-WMF moved this task from Incoming to Q4 Sprint 3 (May 7 2025 - 21 May) on the Web-Team board.

Jdlrobson-WMF edited projects, added Web-Team (Q4 Sprint 3 (May 7 2025 - 21 May)); removed Web-Team.

Dillon is beginning this today.

Change #1143673 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/ReadingLists@master] bookmark: Move action button to toolbar

https://gerrit.wikimedia.org/r/1143673

gerritbot added a project: Patch-For-Review.May 8 2025, 8:58 PM

Hoping to get a new patch up by the end of the day.

Currently in process of reorganizing ResourceLoader.

Jdlrobson-WMF updated the task description. (Show Details)May 14 2025, 9:47 PM

Jdlrobson-WMF mentioned this in T390762: API: Optimize the bookmark action.

Change #1143673 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] bookmark: Move action button to toolbar

https://gerrit.wikimedia.org/r/1143673

Jdlrobson-WMF moved this task from Backlog to In Progress on the FY2024-25 KR 3.1 Content Discovery (Reading List MVP 3.1 (Intern Research)) board.May 17 2025, 12:16 AM

Edward. FYI: Known issue is that your testing should fail in mobile until T394560: Minerva doesn't support outputting custom data attributes is fixed. You can move to sign off once you've confirmed things are working in desktop and broken in mobile.

Maintenance_bot removed a project: Patch-For-Review.May 17 2025, 12:30 AM

Jdlrobson-WMF mentioned this in T394562: Hide the watchstar and watchlist when the reading list beta feature is enabled.May 17 2025, 12:31 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 17 2025, 1:00 AM

Johannnes89 subscribed.May 17 2025, 6:42 AM

Test Steps

Status: ❌ FAIL
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS

Test Case 1: Verify no reading list API request on page load

Precondition: Make sure you have enabled the Reading List beta feature in user preferences.

Log in with an existing user account.
Open the browser DevTools and switch to the Network tab.
Navigate to any article page (e.g., /wiki/Dog) on the beta cluster.
✅ AC1: Confirm a bookmark icon appears next to the watchstar in both Minerva and Vector skins.
✅ AC2: Confirm no API requests related to reading lists are triggered automatically on page load.

Vector	Minerva
	no api calls, I guess this is done?

Precondition: Create a new user account and enable the Reading List beta feature.

Navigate to any article page (e.g., /wiki/Cat).
✅ AC3: Confirm no API requests related to reading lists are triggered on page load.

Vector	Minerva

Click the bookmark icon next to the watchstar.
✅ AC4: Confirm the article is added to a newly created default reading list (no errors).

Vector	Minerva

Refresh the page.
❌ AC5: Confirm the bookmark icon remains filled, indicating the article is successfully saved.

Vector	Minerva
	link still takes you to the Desktop page

There is an issue with the reading list label

Screenshot 2025-05-19 at 10.17.04 AM.png (314×182 px, 21 KB)

After that we can pass to Edward.

Change #1147866 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/ReadingLists@master] Fix Reading Lists user link translation

https://gerrit.wikimedia.org/r/1147866

gerritbot added a project: Patch-For-Review.May 19 2025, 8:00 PM

Change #1147866 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Fix Reading Lists user link translation

https://gerrit.wikimedia.org/r/1147866

Maintenance_bot removed a project: Patch-For-Review.May 19 2025, 9:30 PM

AC5 ( T393608#10835903) will be fixed as part of T394736.

Great work on this @Dillon !

Jdlrobson-WMF mentioned this in T394736: Beta cluster: data-list-id is not being added on bookmark link.May 19 2025, 9:32 PM

Jdlrobson-WMF assigned this task to Jdrewniak.May 20 2025, 5:31 PM

Resolving given this is working as required on https://mylists.wmcloud.org/
Follow up work in { T394736}

Edtadros mentioned this in T394328: Verify 1.45.0-wmf.2 deployment.May 21 2025, 11:32 PM

Edtadros mentioned this in T394329: Verify 1.45.0-wmf.3 deployment.May 27 2025, 4:32 PM

Test Steps

Status: ❌ FAIL
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS

Test Case 1: Verify no reading list API request on page load

Precondition: Make sure you have enabled the Reading List beta feature in user preferences.

Log in with an existing user account.
Open the browser DevTools and switch to the Network tab.
Navigate to any article page (e.g., /wiki/Dog) on the beta cluster.
✅ AC1: Confirm a bookmark icon appears in both Minerva and Vector skins.
✅ AC2: Confirm no API requests related to reading lists are triggered automatically on page load.

Vector	Minerva
No api calls	No api calls

Precondition: Create a new user account and enable the Reading List beta feature.

Navigate to any article page (e.g., /wiki/Cat).
⬜ AC3: Confirm no API requests related to reading lists are triggered on page load.

Prod testing is read only so skipping this so no new user needs to be created.

Click the bookmark icon next to the watchstar.
❌ AC4: Confirm the article is added to a newly created default reading list (no errors).

Vector	Minerva
This works fine	This shows an error in the console and the page isn't saved.

Error:

 index.js:123 Uncaught (in promise) readinglists-db-error-already-set-up
eval	@	index.js:123

Refresh the page.
✅ AC5: Confirm the bookmark icon remains filled, indicating the article is successfully saved.

Vector	Minerva

❌ AC4: Confirm the article is added to a newly created default reading list (no errors).

Thanks Edward! This is expected. Will be fixed by T394560: Minerva doesn't support outputting custom data attributes.

	F60246320: Screenshot 2025-05-19 at 10.17.04 AM.png
	May 19 2025, 5:17 PM

	F60837848: screenshot 365.png
	May 30 2025, 3:29 AM

	F60837383: screenshot 364.png
	May 30 2025, 3:29 AM

	F60837291: screenshot 363.png
	May 30 2025, 3:29 AM

[ReadingLists] Move bookmark action button to toolbarClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Background

User story

Requirements

BDD

Test Steps

Test Case 1: Verify no reading list API request on page load

Design

Details

Related Objects

Event Timeline

Test Steps

Test Case 1: Verify no reading list API request on page load

Test Steps

Test Case 1: Verify no reading list API request on page load

[ReadingLists] Move bookmark action button to toolbar
Closed, ResolvedPublic3 Estimated Story Points
Actions