Page MenuHomePhabricator
Create Task
Maniphest T393643

IP auto-reveal: Use the UserTemporaryLocation icon in the tool menu on mobile
Closed, ResolvedPublic
Actions

Description

Background

The tool link menu in the MinervaNeue skin displays icons next to the tool links.

The IP auto-reveal tool link was added in T386500, but currently uses the wrong icon:

image.png (595×1 px, 58 KB)

It uses userAvatar, but should use UserTemporaryLocation:

image.png (318×640 px, 35 KB)

This is because UserTemporaryLocation was available in Codex until recentlly. It was added to Codex in T389299.

Technical notes

The IP auto-reveal tool link is specified in SidebarLinksHandler::addIPAutoReveal. The specification should have:

'icon' => 'UserTemporaryLocation'

Acceptance criteria

  • The UserTemporaryLocation icon displays next to the IP auto-reveal tool link on mobile

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
IP auto-reveal: Fix typo in icon specificationmediawiki/extensions/CheckUsermaster+4 -4
IP auto-reveal: Use UserTemporaryLocation iconmediawiki/extensions/CheckUsermaster+4 -4
skin.json: Add icon to the skins.minerva.overflow.icons modulemediawiki/skins/MinervaNeuemaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.May 7 2025, 7:51 PM
Tchanders attached a referenced file: F59269060: image.png. (Show Details)
Tchanders attached a referenced file: F59751485: image.png. (Show Details)
Tchanders mentioned this in T386500: IP auto-reveal: Allow managing IP auto-reveal from sidebar tools menu.
Tchanders added a subtask: T389299: icons: Add 'userTemporaryLocation' icon to Codex and OOUI.
WikanBoy123 triaged this task as Low priority.May 8 2025, 5:59 AM
WikanBoy123 changed the subtype of this task from "Task" to "Design".
JJMC89 raised the priority of this task from Low to Needs Triage.May 8 2025, 6:11 AM
JJMC89 changed the subtype of this task from "Design" to "Task".
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 9 2025, 6:04 AM
kostajh claimed this task.May 9 2025, 6:10 AM
kostajh updated the task description. (Show Details)
kostajh moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
gerritbot added a comment.May 9 2025, 6:15 AM

Change #1143708 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Use UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143708

gerritbot added a project: Patch-For-Review.May 9 2025, 6:15 AM
kostajh changed the task status from Open to Stalled.May 9 2025, 6:39 AM

Patch is ready, but needs to wait for the next Codex release that will include the new icon.

Tchanders moved this task from Backlog to In progress on the Temporary accounts (Major pilot wiki deployment) board.May 13 2025, 12:29 PM
Tchanders mentioned this in T389299: icons: Add 'userTemporaryLocation' icon to Codex and OOUI.May 23 2025, 1:34 PM
Tchanders added a comment.May 23 2025, 1:41 PM
In T393643#10806497, @kostajh wrote:

Patch is ready, but needs to wait for the next Codex release that will include the new icon.

I came back to this now that MediaWiki is using Codex v2.0.0-rc.2.

However, it turns out that this menu uses OOUI icons, so it's actually a new OOUI release that we need: T389299#10852539.

We also need an update to MinervaNeue/skin.json in order to use the icon.

This task is now stalled on:

  • MediaWiki using a release of OOUI that has the userTemporaryLocation icon
  • MinervaNeue/skin.json including the userTemporaryLocation icon in the skins.minerva.overflow.icons module
gerritbot added a comment.May 23 2025, 5:32 PM

Change #1149704 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/skins/MinervaNeue@master] skin.json: Add icon to the skins.minerva.overflow.icons module

https://gerrit.wikimedia.org/r/1149704

egardner closed subtask T389299: icons: Add 'userTemporaryLocation' icon to Codex and OOUI as Resolved.May 23 2025, 10:54 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)); removed Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)).May 25 2025, 6:59 PM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.
Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts (Major pilot wiki deployment).Jun 6 2025, 3:42 PM
Tchanders added a comment.Jun 11 2025, 3:46 PM

Stalled on T396629: Release OOUI v0.52.0.

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)); removed Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)).Jun 16 2025, 6:14 AM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)) board.
Tchanders changed the task status from Stalled to Open.Jun 16 2025, 9:25 AM
In T393643#10905374, @Tchanders wrote:

Stalled on T396629: Release OOUI v0.52.0.

This is ready now.

gerritbot added a comment.Jun 16 2025, 10:08 AM

Change #1149704 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] skin.json: Add icon to the skins.minerva.overflow.icons module

https://gerrit.wikimedia.org/r/1149704

kostajh moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)) board.Jun 16 2025, 10:09 AM
gerritbot added a comment.Jun 16 2025, 10:37 AM

Change #1143708 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Use UserTemporaryLocation icon

https://gerrit.wikimedia.org/r/1143708

kostajh moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)) board.Jun 16 2025, 10:52 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 16 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2025, 11:30 AM
Djackson-ctr subscribed.Jun 18 2025, 7:26 AM

Hi @kostajh:
While testing this ticket, I am noticing the IP Auto-reveal icon is just a dark square (see screenshot)...
I have tried this with testwiki, my localhost and patch demo, and getting the same dark square icon for IP Auto-reveal.

image.png (797×1 px, 387 KB)

gerritbot added a comment.Jun 19 2025, 3:41 PM

Change #1161550 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Fix typo in icon specification

https://gerrit.wikimedia.org/r/1161550

gerritbot added a project: Patch-For-Review.Jun 19 2025, 3:41 PM
Tchanders moved this task from Needs QA to Needs Review on the Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)) board.Jun 19 2025, 3:42 PM

Thanks @Djackson-ctr - it should be fixed in the latest patch.

gerritbot added a comment.Jun 19 2025, 4:18 PM

Change #1161550 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: Fix typo in icon specification

https://gerrit.wikimedia.org/r/1161550

Maintenance_bot removed a project: Patch-For-Review.Jun 19 2025, 4:30 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.7; 2025-06-24); removed MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 19 2025, 5:00 PM
Djackson-ctr moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Baklava (June 16 - July 4)) board.Jun 21 2025, 7:29 AM

Using Localhost for testing:
QA is completed, I have verified the new code has been implemented and is functioning as expected (Per the Acceptance Criteria)... Thank you @Tchanders.

Tchanders closed this task as Resolved.Jun 21 2025, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits