Page MenuHomePhabricator
Create Task
Maniphest T393742

CodeMirrorContentModels extension attribute is ignored
Closed, ResolvedPublicBUG REPORT
Actions

Description

For example, proofread-page should be supported per https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/ProofreadPage/+/ea103112c40a567306361c33c135aba8c26c0750/extension.json#462

It looks like I forgot about the extension attribute in r1107061 :(

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use CodeMirrorGetModeHook instead of extension attributemediawiki/extensions/ProofreadPagemaster+31 -6
Remove ContentModels ext attribute, make config flag associativemediawiki/extensions/CodeMirrormaster+37 -39
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.May 8 2025, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2025, 9:53 PM
MusikAnimal changed the task status from Open to In Progress.May 8 2025, 9:53 PM
MusikAnimal claimed this task.
MusikAnimal triaged this task as High priority.
MusikAnimal moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.

There are no more backport windows this week, so we may not get the fix in until Monday.

gerritbot added a comment.May 12 2025, 11:00 PM

Change #1144669 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] Remove ContentModels ext attribute, make config flag associative

https://gerrit.wikimedia.org/r/1144669

gerritbot added a project: Patch-For-Review.May 12 2025, 11:00 PM
gerritbot added a comment.May 12 2025, 11:18 PM

Change #1144673 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/ProofreadPage@master] Use CodeMirrorGetModeHook instead of extension attribute

https://gerrit.wikimedia.org/r/1144673

gerritbot added a comment.May 17 2025, 6:59 AM

Change #1144669 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove ContentModels ext attribute, make config flag associative

https://gerrit.wikimedia.org/r/1144669

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 17 2025, 7:00 AM
gerritbot added a comment.May 21 2025, 12:34 PM

Change #1144673 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Use CodeMirrorGetModeHook instead of extension attribute

https://gerrit.wikimedia.org/r/1144673

Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 1:31 PM
MusikAnimal mentioned this in T394891: Syntax Highlighting unavailable on Wikisources in Page namespace: Unsupported CodeMirror mode '' [Called from MediaWiki\Extension\CodeMirror\Hooks::loadCodeMirrorOnEditPage in CodeMirror/includes/Hooks.php at line 223].May 21 2025, 4:59 PM
MusikAnimal merged a task: T394891: Syntax Highlighting unavailable on Wikisources in Page namespace: Unsupported CodeMirror mode '' [Called from MediaWiki\Extension\CodeMirror\Hooks::loadCodeMirrorOnEditPage in CodeMirror/includes/Hooks.php at line 223].May 22 2025, 11:00 PM
MusikAnimal added subscribers: brennen, Ammarpad.
Albertoleoncio subscribed.May 27 2025, 3:57 PM
Bhsd subscribed.May 29 2025, 2:50 AM

Before closing this ticket, I find a few more issues related to proofreading with CM6 enabled:

  1. The header and the footer disappear when previewing.
  2. The CSS looks broken when line wrapping is disabled.
  3. Code folding does not work.
Bhsd closed this task as Resolved.Jun 12 2025, 8:09 AM
Bhsd moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.

Close this ticket and continue the discussion in T380262.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits