Page MenuHomePhabricator
Create Task
Maniphest T393834

CentralNotice campaign page lets people without permissions visually modify stuff
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The editing UI renders and lets you make changes (but there's no way of saving the changes)

What should have happened instead?:

The editing UI should be read only.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Apply multiselect to cn-multiselect class instead of generic elementmediawiki/extensions/CentralNoticemaster+11 -15
Disable project / language selectors when not editablemediawiki/extensions/CentralNoticemaster+1 -1
Disable mixin inputs when not editablemediawiki/extensions/CentralNoticemaster+7 -1
Disable geotargeting selectors when not editablemediawiki/extensions/CentralNoticemaster+10 -4
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.May 10 2025, 4:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2025, 4:52 PM
Johannnes89 subscribed.May 12 2025, 8:22 AM
Pcoombe renamed this task from CentralNotice UI lets people without permissions visually modify stuff to CentralNotice campaign page lets people without permissions visually modify stuff.May 12 2025, 9:55 AM
Pcoombe updated the task description. (Show Details)
Ejegg subscribed.Feb 6 2026, 7:02 PM

As of early 2026 some elements are rendered read-only (dates, type, targeting checkboxes, banner assignment) and some elements are rendered editable (project & language targeting complex select boxes, country & region selectors, mixin-specific settings)

gerritbot added a comment.Feb 6 2026, 7:28 PM

Change #1237562 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Disable geotargeting selectors when not editable

https://gerrit.wikimedia.org/r/1237562

gerritbot added a project: Patch-For-Review.Feb 6 2026, 7:28 PM
gerritbot added a comment.Feb 6 2026, 8:30 PM

Change #1237584 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Disable mixin inputs when not editable

https://gerrit.wikimedia.org/r/1237584

Ejegg added a comment.Feb 6 2026, 8:45 PM

looks like JQuery UI multiselect (used for the project & language targeting selectors) does not have a disabled state

gerritbot added a comment.Feb 6 2026, 9:07 PM

Change #1237590 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Disable project / language selectors when not editable

https://gerrit.wikimedia.org/r/1237590

Ejegg added a project: Fundraising Tech - Chaos Crew.Feb 6 2026, 9:08 PM
Restricted Application added a project: Fundraising-Backlog. · View Herald TranscriptFeb 6 2026, 9:08 PM
Ejegg moved this task from Triage to Chaos Crew Backlog on the Fundraising-Backlog board.Feb 6 2026, 9:08 PM
Ejegg moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.
gerritbot added a comment.Feb 26 2026, 7:54 PM

Change #1237562 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Disable geotargeting selectors when not editable

https://gerrit.wikimedia.org/r/1237562

gerritbot added a comment.Feb 26 2026, 7:56 PM

Change #1237584 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Disable mixin inputs when not editable

https://gerrit.wikimedia.org/r/1237584

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.18; 2026-03-03).Feb 26 2026, 8:00 PM
gerritbot added a comment.Feb 27 2026, 2:16 AM

Change #1237590 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Disable project / language selectors when not editable

https://gerrit.wikimedia.org/r/1237590

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2026, 2:30 AM
gerritbot added a comment.Feb 27 2026, 2:38 AM

Change #1245007 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/CentralNotice@master] Apply multiselect to cn-multiselect class instead of generic element

https://gerrit.wikimedia.org/r/1245007

gerritbot added a project: Patch-For-Review.Feb 27 2026, 2:38 AM
gerritbot added a comment.Mar 2 2026, 4:04 PM

Change #1245007 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Apply multiselect to cn-multiselect class instead of generic element

https://gerrit.wikimedia.org/r/1245007

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2026, 4:31 PM
Ejegg moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.Mar 9 2026, 7:48 PM
Pppery closed this task as Resolved.Mar 21 2026, 5:28 AM
Pppery assigned this task to Ejegg.

Confirmed fixed, but discovered T420810 while testing.

Damilare mentioned this in T419708: Sprint E- Priorities.Mar 24 2026, 1:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits