Page MenuHomePhabricator
Create Task
Maniphest T393844

Allow newsletter extension to publish issues with section anchors
Closed, ResolvedPublicFeature
Actions

Description

Feature summary: Allow newsletter extension to publish issues that point to page sections (as opposed to only being limited to pages).

Use case(s) : Reported by User:Gryllida on MW:Newsletter Talk page about having using the extension to send Echo notification to a group of subscribers, but in this case, with page sections (instead of new pages) as issues.

Benefits: Seems like we had a discussion about it back during the original discussions around the Newsletter extension. In general, this should make the extension more flexible (I guess)?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Support fragments to issue titles when announcingmediawiki/extensions/Newslettermaster+21 -4
Customize query in gerrit

Related Objects

Event Timeline

01tonythomas created this task.May 11 2025, 12:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2025, 12:06 PM
Pppery added a project: Schema-change.May 11 2025, 5:53 PM
Pppery subscribed.

This would require a schema change to the nli_issues table.

Pppery removed a project: Schema-change.May 11 2025, 11:01 PM

Actually it doesn't since the nl_issues table is never read from. Something in Echo is losing the fragment, and I'm not inclined to spend my time determining what it is.

Gryllida subscribed.May 17 2025, 12:12 PM
01tonythomas added a comment.May 17 2025, 4:17 PM

I played around with a bit, and saw that it was Echo that was killing the fragments by relying simply on the pageId. I thought about providing the fragment as an extra param while creating the issue, and using it when rendering it. Works, but, to be honest, this has to be implemented at Echo level, IMHO. But since that is a big ask, probably we might be able to live with this as well?

gerritbot added a comment.May 17 2025, 4:46 PM

Change #1147111 had a related patch set uploaded (by 01tonythomas; author: 01tonythomas):

[mediawiki/extensions/Newsletter@master] Support fragments to issue titles when announcing

https://gerrit.wikimedia.org/r/1147111

gerritbot added a project: Patch-For-Review.May 17 2025, 4:46 PM
Pppery mentioned this in T394586: nl_issues table is never read from.May 17 2025, 4:52 PM
gerritbot added a comment.May 17 2025, 9:22 PM

Change #1147111 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Support fragments to issue titles when announcing

https://gerrit.wikimedia.org/r/1147111

Maintenance_bot removed a project: Patch-For-Review.May 17 2025, 9:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 17 2025, 10:00 PM
Pppery closed this task as Resolved.May 18 2025, 12:41 AM
Pppery assigned this task to 01tonythomas.
01tonythomas mentioned this in T394022: install Newsletter extension in English Wikinews.May 20 2025, 1:31 PM
IKhitron awarded a token.May 20 2025, 6:30 PM
IKhitron subscribed.
IKhitron added a comment.May 20 2025, 6:59 PM

I'm happy this is resolved, and added an entry for the Tech News. Please fill free to fix or remove it, if I'm wrong. Thank you.

Pppery added a project: User-notice.May 20 2025, 7:04 PM
Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.May 23 2025, 8:17 PM
Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.May 29 2025, 8:02 PM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Jun 8 2025, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits