| Novem_Linguae | |
| May 11 2025, 6:00 PM |
| F59885026: image.png | |
| May 11 2025, 7:10 PM |
Why
What
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| replace complex ?stableid= code with a redirect to ?oldid= | mediawiki/extensions/FlaggedRevs | master | +15 -178 |
The below grey box is the only thing that links to ?stableid=.
The QQQ for this message says...
"revreview-basic-source": "{{Flagged Revs-small}}\nDisplayed on the top of a page when you are viewing an old checked revision. The link goes to the reviewed *version* of this revision (e.g. templates/files are stabilized).\n* Example: [https://de.wikipedia.org/w/index.php?title=Deutsche_Sprache&oldid=46894374 de.wikipedia].\nParameters:\n* $1 - stable revision ID\n* $2 - date the stable version was accepted",This seems to indicate that this is left over from a time when FlaggedRevs used to recursively stabilize every template and file the page used. I think this feature was removed a year or two ago.
Anyway, thoughts on the best approach? Should I just remove this box completely? Or should I only remove the ?stableid= hyperlink? Or am I missing something and this should be kept?
Change #1143970 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):
[mediawiki/extensions/FlaggedRevs@master] remove ?stableid=
@Novem_Linguae Under the current plan, would backwards-compatibility be kept (for e.g. people visiting pre-saved links that include stableid=; maybe by redirecting any such queries to use oldid= instead(?)), or would all support for the parameter be dropped completely?
My current work in progress patch deletes the feature, but I can be talked
into having stableid redirect to oldid if folks think it's a good idea.
A reason why deleting might be fine is the only page that generates that
stableid hypelink is already the oldid page.
Speaking personally, as a matter of general principle, I feel like I'm generally in favour of keeping backwards-compatibility for user-facing functionality/URLs -- I'd be interested to hear what other folks feel about this, though :)
Looks like a global search for "stableid" turns up 820 hits. Will go ahead and modify my patch to support redirecting ?stableid= to ?oldid= so as not to break these.
Change #1143970 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] replace complex ?stableid= code with a redirect to ?oldid=
Just noting that the feature to stabilize templates was not removed, rather the form of it that recorded all the versions of templates used at time of review was removed (FR_INCLUDES_FREEZE). There is still the FR_INCLUDES_STABLE setting to stabilize templates/modules/files by using their own stable versions (when possible). oldid= and stableid= were not equivalent in this regard (since the former just always uses the latest version of templates/modules). The idea was to have a kind of permanent link that was more resistant to template/module/file vandalism. In any case, I doubt it saw much use.