Page MenuHomePhabricator
Create Task
Maniphest T393872

Make weighted tags no longer be WMF-specific
Closed, ResolvedPublic
Actions

Description

Although the initial uses of weighted_tags were for WMF-specific features like articletopic (via ORES) and link recommendations (in GrowthExperiments), it is now being used for features that are not WMF-specific – such as searching by WikiProjects (T378868).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove deprecated $wgCirrusSearchWMFExtraFeaturesmediawiki/extensions/CirrusSearchmaster+21 -77
tests-list-large.xml: update CirrusSearch test class namespacesmediawiki/coremaster+4 -4
Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTagsoperations/mediawiki-configmaster+3 -10
Remove deprecated class alias of WeightedTagsHooksmediawiki/extensions/CirrusSearchmaster+0 -9
Update deprecated import of WeightedTagsHooks in maintenance scriptmediawiki/extensions/ImageSuggestionsmaster+1 -1
Make weighted tags no longer be WMF-specificmediawiki/extensions/CirrusSearchmaster+266 -200
Add integration tests for articletopic & hasrecommendationmediawiki/extensions/CirrusSearchmaster+1 K -7
Make weighted tags no longer be WMF-specificmediawiki/extensions/CirrusSearchwmf/1.45.0-wmf.1+2 K -349
Update deprecated import of WeightedTagsHookmediawiki/extensions/ImageSuggestionsmaster+1 -1
Update deprecated import of WeightedTagsHooksmediawiki/extensions/PageAssessmentsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

SD0001 created this task.May 12 2025, 9:05 AM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 12 2025, 9:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
SD0001 added a comment.May 12 2025, 9:07 AM

Main patch is already merged: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1143958.

  • \CirrusSearch\Wikimedia\WeightedTagsHooks is deprecated in favour of \CirrusSearch\Search\WeightedTagsHooks.
  • $wgCirrusSearchWMFExtraFeatures (which was only used for weighted tags) is deprecated in favour of $wgCirrusSearchWeightedTags.
gerritbot added a comment.May 12 2025, 9:08 AM

Change #1144479 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/ImageSuggestions@master] Update deprecated import of WeightedTagsHook

https://gerrit.wikimedia.org/r/1144479

gerritbot added a project: Patch-For-Review.May 12 2025, 9:08 AM
gerritbot added a comment.May 12 2025, 9:11 AM

Change #1143964 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/PageAssessments@master] Update deprecated import of WeightedTagsHooks

https://gerrit.wikimedia.org/r/1143964

gerritbot added a comment.May 12 2025, 9:34 AM

Change #1144484 had a related patch set uploaded (by SD0001; author: SD0001):

[operations/mediawiki-config@master] Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTags

https://gerrit.wikimedia.org/r/1144484

gerritbot added a comment.May 12 2025, 9:43 AM

Change #1144485 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/CirrusSearch@master] Remove deprecated class alias of WeightedTagsHooks

https://gerrit.wikimedia.org/r/1144485

gerritbot added a comment.May 12 2025, 9:43 AM

Change #1144486 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/CirrusSearch@master] Remove deprecated $wgCirrusSearchWMFExtraFeatures

https://gerrit.wikimedia.org/r/1144486

gerritbot added a comment.May 12 2025, 12:51 PM

Change #1144479 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Update deprecated import of WeightedTagsHook

https://gerrit.wikimedia.org/r/1144479

gerritbot added a comment.May 12 2025, 12:51 PM

Change #1143964 merged by jenkins-bot:

[mediawiki/extensions/PageAssessments@master] Update deprecated import of WeightedTagsHooks

https://gerrit.wikimedia.org/r/1143964

SD0001 mentioned this in rEISUfb6ed696a1e1: Update deprecated import of WeightedTagsHook.May 12 2025, 12:52 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 12 2025, 1:00 PM
gerritbot added a comment.May 12 2025, 1:29 PM

Change #1144573 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/core@master] tests-list-large.xml: update CirrusSearch test class namespaces

https://gerrit.wikimedia.org/r/1144573

gerritbot added a comment.May 12 2025, 1:31 PM

Change #1144574 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/ImageSuggestions@master] Update deprecated import of WeightedTagsHooks in maintenance script

https://gerrit.wikimedia.org/r/1144574

Gehel edited projects, added Discovery-Search (2025.05.02 - 2025.05.23); removed Discovery-Search.May 12 2025, 3:27 PM
Gehel moved this task from Incoming to Needs Review on the Discovery-Search (2025.05.02 - 2025.05.23) board.May 12 2025, 3:43 PM
dcausse assigned this task to SD0001.May 12 2025, 3:43 PM
gerritbot added a comment.May 16 2025, 9:10 AM

Change #1146938 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Add integration tests for articletopic & hasrecommendation

https://gerrit.wikimedia.org/r/1146938

gerritbot added a comment.May 16 2025, 2:29 PM

Change #1146700 had a related patch set uploaded (by DCausse; author: SD0001):

[mediawiki/extensions/CirrusSearch@master] Make weighted tags no longer be WMF-specific

https://gerrit.wikimedia.org/r/1146700

gerritbot added a comment.May 19 2025, 12:49 PM

Change #1147762 had a related patch set uploaded (by DCausse; author: SD0001):

[mediawiki/extensions/CirrusSearch@wmf/1.45.0-wmf.1] Make weighted tags no longer be WMF-specific

https://gerrit.wikimedia.org/r/1147762

gerritbot added a comment.May 19 2025, 12:52 PM

Change #1146938 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Add integration tests for articletopic & hasrecommendation

https://gerrit.wikimedia.org/r/1146938

gerritbot added a comment.May 19 2025, 12:55 PM

Change #1146700 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Make weighted tags no longer be WMF-specific

https://gerrit.wikimedia.org/r/1146700

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.2; 2025-05-20); removed MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 19 2025, 1:00 PM
gerritbot added a comment.May 19 2025, 1:12 PM

Change #1147762 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@wmf/1.45.0-wmf.1] Make weighted tags no longer be WMF-specific

https://gerrit.wikimedia.org/r/1147762

Stashbot added a comment.May 19 2025, 1:28 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-19T13:28:33Z] <dcausse@deploy1003> Started scap sync-world: Backport for [[gerrit:1147762|Make weighted tags no longer be WMF-specific (T393872)]]

Stashbot added a comment.May 19 2025, 1:32 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-19T13:32:51Z] <dcausse@deploy1003> dcausse: Backport for [[gerrit:1147762|Make weighted tags no longer be WMF-specific (T393872)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.May 19 2025, 1:42 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-19T13:42:02Z] <dcausse@deploy1003> Finished scap sync-world: Backport for [[gerrit:1147762|Make weighted tags no longer be WMF-specific (T393872)]] (duration: 13m 28s)

gerritbot added a comment.May 19 2025, 2:03 PM

Change #1144574 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Update deprecated import of WeightedTagsHooks in maintenance script

https://gerrit.wikimedia.org/r/1144574

SD0001 mentioned this in rEISU727be3d0ecc2: Update deprecated import of WeightedTagsHooks in maintenance script.May 19 2025, 2:05 PM
gerritbot added a comment.May 21 2025, 7:39 PM

Change #1148944 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/PageAssessments@master] Lua: Rename attribute from projects to pageAssessments

https://gerrit.wikimedia.org/r/1148944

SD0001 added a comment.May 21 2025, 7:40 PM
In T393872#10845606, @gerritbot wrote:

Change #1148944 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/PageAssessments@master] Lua: Rename attribute from projects to pageAssessments

https://gerrit.wikimedia.org/r/1148944

Wrong ticket, please ignore.

gerritbot added a comment.May 21 2025, 9:11 PM

Change #1144485 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Remove deprecated class alias of WeightedTagsHooks

https://gerrit.wikimedia.org/r/1144485

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 21 2025, 10:00 PM
Gehel edited projects, added Discovery-Search (2025.05.24 - 2025.06.13); removed Discovery-Search (2025.05.02 - 2025.05.23).May 23 2025, 1:00 PM
Gehel moved this task from Incoming to Needs Review on the Discovery-Search (2025.05.24 - 2025.06.13) board.
gerritbot added a comment.Jun 10 2025, 8:22 PM

Change #1144484 merged by jenkins-bot:

[operations/mediawiki-config@master] Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTags

https://gerrit.wikimedia.org/r/1144484

Stashbot added a comment.Jun 10 2025, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-10T20:22:31Z] <cjming@deploy1003> Started scap sync-world: Backport for [[gerrit:1144484|Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTags (T393872)]]

Stashbot added a comment.Jun 10 2025, 8:24 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-10T20:24:44Z] <cjming@deploy1003> cjming, sd: Backport for [[gerrit:1144484|Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTags (T393872)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 10 2025, 8:32 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-10T20:32:50Z] <cjming@deploy1003> Finished scap sync-world: Backport for [[gerrit:1144484|Replace deprecated wgCirrusSearchWMFExtraFeatures with wgCirrusSearchWeightedTags (T393872)]] (duration: 10m 18s)

Gehel edited projects, added Discovery-Search (2025.06.13 - 2025.07.04); removed Discovery-Search (2025.05.24 - 2025.06.13).Jun 16 2025, 1:35 PM
Gehel moved this task from Incoming to Needs Review on the Discovery-Search (2025.06.13 - 2025.07.04) board.
EBernhardson subscribed.Jun 16 2025, 4:17 PM

I think the only patch still open is: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1144486

This was initially blocked as the code was used in prod and couldn't be removed yet, but that has been resolved now. There is some code review remaining before it can be merged.

gerritbot added a comment.Jun 16 2025, 4:43 PM

Change #1144573 merged by jenkins-bot:

[mediawiki/core@master] tests-list-large.xml: update CirrusSearch test class namespaces

https://gerrit.wikimedia.org/r/1144573

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.6; 2025-06-17); removed MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).Jun 16 2025, 5:00 PM
gerritbot added a comment.Jun 20 2025, 7:09 PM

Change #1144486 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Remove deprecated $wgCirrusSearchWMFExtraFeatures

https://gerrit.wikimedia.org/r/1144486

SD0001 closed this task as Resolved.Jun 20 2025, 7:13 PM
EBernhardson moved this task from Needs Review to Done on the Discovery-Search (2025.06.13 - 2025.07.04) board.Jun 20 2025, 7:45 PM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.7; 2025-06-24); removed MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 20 2025, 8:00 PM
Gehel moved this task from Done to Reported on the Discovery-Search (2025.06.13 - 2025.07.04) board.Jun 27 2025, 8:25 AM
tstarling mentioned this in T408052: PHP Warning: Trying to access array offset on null (via GrowthExperiments listTaskCounts).Oct 30 2025, 9:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits