Page MenuHomePhabricator
Create Task
Maniphest T393879

PHP Deprecated: Implicit conversion from float 41.45954849253939 to int loses precision
Closed, ResolvedPublic
Actions

Description

Stack trace:

from /srv/mediawiki/php-1.44.0-wmf.28/maintenance/purgeParserCache.php(113)
#0 /srv/mediawiki/php-1.44.0-wmf.28/maintenance/purgeParserCache.php(113): MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1 /srv/mediawiki/php-1.44.0-wmf.28/includes/objectcache/SqlBagOStuff.php(1598): PurgeParserCache->showProgressAndWait(float)
#2 /srv/mediawiki/php-1.44.0-wmf.28/includes/objectcache/SqlBagOStuff.php(1491): SqlBagOStuff->deleteServerObjectsExpiringBefore(Wikimedia\Rdbms\DatabaseMySQL, int, float, int, array)
#3 /srv/mediawiki/php-1.44.0-wmf.28/includes/libs/objectcache/MultiWriteBagOStuff.php(316): SqlBagOStuff->deleteObjectsExpiringBefore(int, array, float, string)
#4 /srv/mediawiki/php-1.44.0-wmf.28/maintenance/purgeParserCache.php(104): Wikimedia\ObjectCache\MultiWriteBagOStuff->deleteObjectsExpiringBefore(int, array, float, string)
#5 /srv/mediawiki/php-1.44.0-wmf.28/maintenance/includes/MaintenanceRunner.php(694): PurgeParserCache->execute()
#6 /srv/mediawiki/php-1.44.0-wmf.28/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#7 /srv/mediawiki/multiversion/MWScript.php(221): require_once(string)
#8 {main}

Example: https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-1-7.0.0-1-2025.05.12?id=Ats4wpYBF1zH-YDaaw2I

We get 300K in every run of purge parser cache (daily)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
objectcache: Cast explicitly to integerLadsgroupmediawiki/corewmf/1.44.0-wmf.28+1 -1
objectcache: Cast explicitly to integerReedymediawiki/coreREL1_42+1 -1
objectcache: Cast explicitly to integerReedymediawiki/coreREL1_43+1 -1
objectcache: Cast explicitly to integerReedymediawiki/coreREL1_44+1 -1
objectcache: Cast explicitly to integerReedymediawiki/coreREL1_39+1 -1
objectcache: Cast explicitly to integerLadsgroupmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
ResolvedLadsgroupT393879 PHP Deprecated: Implicit conversion from float 41.45954849253939 to int loses precision
· · ·

Event Timeline

Ladsgroup created this task.May 12 2025, 10:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2025, 10:26 AM
Reedy added a project: PHP 8.1 support.May 12 2025, 10:26 AM
gerritbot added a comment.May 12 2025, 10:32 AM

Change #1144496 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144496

gerritbot added a project: Patch-For-Review.May 12 2025, 10:32 AM
gerritbot added a comment.May 12 2025, 11:01 AM

Change #1144502 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.44.0-wmf.28] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144502

gerritbot added a comment.May 12 2025, 11:10 AM

Change #1144496 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144496

gerritbot added a comment.May 12 2025, 11:24 AM

Change #1144509 had a related patch set uploaded (by Reedy; author: Amir Sarabadani):

[mediawiki/core@REL1_44] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144509

gerritbot added a comment.May 12 2025, 11:24 AM

Change #1144510 had a related patch set uploaded (by Reedy; author: Amir Sarabadani):

[mediawiki/core@REL1_43] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144510

gerritbot added a comment.May 12 2025, 11:25 AM

Change #1144511 had a related patch set uploaded (by Reedy; author: Amir Sarabadani):

[mediawiki/core@REL1_42] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144511

gerritbot added a comment.May 12 2025, 11:25 AM

Change #1144512 had a related patch set uploaded (by Reedy; author: Amir Sarabadani):

[mediawiki/core@REL1_39] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144512

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 12 2025, 12:00 PM
Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.May 12 2025, 12:15 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.
gerritbot added a comment.May 12 2025, 12:23 PM

Change #1144512 merged by jenkins-bot:

[mediawiki/core@REL1_39] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144512

gerritbot added a comment.May 12 2025, 12:29 PM

Change #1144509 merged by jenkins-bot:

[mediawiki/core@REL1_44] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144509

gerritbot added a comment.May 12 2025, 12:29 PM

Change #1144511 merged by jenkins-bot:

[mediawiki/core@REL1_42] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144511

gerritbot added a comment.May 12 2025, 12:29 PM

Change #1144510 merged by jenkins-bot:

[mediawiki/core@REL1_43] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144510

Reedy changed the task status from Open to In Progress.May 12 2025, 12:30 PM
Reedy assigned this task to Ladsgroup.
Ladsgroup moved this task from Triage to In progress on the DBA board.May 12 2025, 12:33 PM
Krinkle changed the task status from In Progress to Open.May 12 2025, 12:36 PM
Krinkle edited projects, added: MediaWiki-libs-BagOStuff, MediaWiki-Core-Platform-Team (Radar); removed: MediaWiki-Parser.
Krinkle moved this task from General to Confirmed problem on the MediaWiki-libs-BagOStuff board.
ReleaseTaggerBot added projects: MW-1.43-notes, MW-1.39-notes, MW-1.44-notes, MW-1.42-notes.May 12 2025, 1:00 PM
gerritbot added a comment.May 12 2025, 10:39 PM

Change #1144502 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.28] objectcache: Cast explicitly to integer

https://gerrit.wikimedia.org/r/1144502

Stashbot added a comment.May 12 2025, 10:39 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-12T22:39:53Z] <ladsgroup@deploy1003> Started scap sync-world: Backport for [[gerrit:1144502|objectcache: Cast explicitly to integer (T393879)]]

Stashbot added a comment.May 12 2025, 10:44 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-12T22:44:34Z] <ladsgroup@deploy1003> ladsgroup: Backport for [[gerrit:1144502|objectcache: Cast explicitly to integer (T393879)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 12 2025, 10:51 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-12T22:51:27Z] <ladsgroup@deploy1003> Finished scap sync-world: Backport for [[gerrit:1144502|objectcache: Cast explicitly to integer (T393879)]] (duration: 11m 33s)

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed: MW-1.44-notes.May 12 2025, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 12 2025, 11:30 PM
Ladsgroup closed this task as Resolved.May 13 2025, 9:49 AM
Ladsgroup moved this task from In progress to Done on the DBA board.

the parser cache part is fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits