Page MenuHomePhabricator
Create Task
Maniphest T393890

EventBus: replace PageMoveCompleteHook with PageMovedEvent
Closed, ResolvedPublic
Actions

Description

This task introduces basic support for the Domain Events API in EventBus.

AC:

  • PageMoveCompleteHook has been replaced with a domain event listener

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
remove PageChangeCompleteHook.mediawiki/extensions/EventBusmaster+3 -54
adopt PageMoved domain eventmediawiki/extensions/EventBusmaster+242 -47
PageChangeEmissionTest: integration test for move and undeletemediawiki/extensions/EventBusmaster+484 -86
PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumptionmediawiki/extensions/EventBusmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

gmodena created this task.May 12 2025, 12:48 PM
HCoplin-WMF moved this task from Now to Supporting on the MW-Interfaces-Team (MWI-Roadmap) board.May 12 2025, 2:56 PM
gmodena moved this task from Next Up to In progress on the Data-Engineering (Q4 2025 April 1st - June 30th) board.May 13 2025, 8:06 AM
gmodena added a comment.May 13 2025, 2:31 PM

To move forward we need these two related tasks:

gmodena renamed this task from EventBus: replace PageMoveCompleteHook with PageLifecycle to EventBus: replace PageMoveCompleteHook with PageMovedEvent.May 14 2025, 12:40 PM
gmodena mentioned this in T394046: PagedMovedEvent should carry reason data.
gerritbot added a comment.May 19 2025, 8:32 PM

Change #1147873 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PagaChangeEmissionTest: integration test for move

https://gerrit.wikimedia.org/r/1147873

gerritbot added a project: Patch-For-Review.May 19 2025, 8:32 PM
gerritbot added a comment.May 19 2025, 8:42 PM

Change #1147875 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEventIngress adopt PageMovedListener

https://gerrit.wikimedia.org/r/1147875

gmodena moved this task from In progress to In Review on the Data-Engineering (Q4 2025 April 1st - June 30th) board.May 22 2025, 12:54 PM
gerritbot added a comment.Jun 2 2025, 12:17 PM

Change #1152666 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] remove PageChangeCompleteHook.

https://gerrit.wikimedia.org/r/1152666

gmodena updated the task description. (Show Details)Jun 6 2025, 11:59 AM
gerritbot added a comment.Jun 12 2025, 12:18 PM

Change #1147873 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: integration test for move and undelete

https://gerrit.wikimedia.org/r/1147873

gerritbot added a comment.Jun 12 2025, 1:23 PM

Change #1156347 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumption

https://gerrit.wikimedia.org/r/1156347

gerritbot added a comment.Jun 12 2025, 4:33 PM

Change #1156347 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumption

https://gerrit.wikimedia.org/r/1156347

kostajh mentioned this in T397087: phpunit\integration\PageChangeEmissionTest::testPageMove with data set "Valid move with redirect" ('SourcePageA', 'DestinationPageA', true, 3).Jun 16 2025, 7:36 PM
gmodena moved this task from In Review to Ready to Deploy on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Jun 20 2025, 7:40 PM
gerritbot added a comment.Jun 20 2025, 7:53 PM

Change #1147875 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] adopt PageMoved domain event

https://gerrit.wikimedia.org/r/1147875

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.7; 2025-06-24).Jun 20 2025, 8:00 PM
gerritbot added a comment.Jun 24 2025, 12:00 PM

Change #1152666 abandoned by Gmodena:

[mediawiki/extensions/EventBus@master] remove PageChangeCompleteHook.

Reason:

Superseded by 1163344

https://gerrit.wikimedia.org/r/1152666

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2025, 12:31 PM
gmodena updated the task description. (Show Details)Jul 7 2025, 1:27 PM
gmodena moved this task from Ready to Deploy to Done on the Data-Engineering (Q4 2025 April 1st - June 30th) board.
Ahoelzl closed this task as Resolved.Jul 25 2025, 11:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits