Page MenuHomePhabricator
Create Task
Maniphest T393891

EventBus: Replace PageUndeleteCompleteHook with PageRevisionUpdated
Closed, ResolvedPublic
Actions

Description

WIP: this task references an api not yet merged in core

This task introduces basic support for the Domain Events API in EventBus.

AC:

  • PageUndeleteCompleteHook has been replaced with a domain event listener

Depends on:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
PageChangeEmissionTest: assert undeletion domain eventmediawiki/extensions/EventBusmaster+1 -1
adopt undeletion domain eventmediawiki/extensions/EventBusmaster+47 -6
PageChangeEmissionTest: integration test for move and undeletemediawiki/extensions/EventBusmaster+484 -86
PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumptionmediawiki/extensions/EventBusmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

gmodena created this task.May 12 2025, 12:50 PM
gmodena updated the task description. (Show Details)
HCoplin-WMF moved this task from Now to Supporting on the MW-Interfaces-Team (MWI-Roadmap) board.May 12 2025, 2:56 PM
gmodena moved this task from Next Up to In progress on the Data-Engineering (Q4 2025 April 1st - June 30th) board.May 15 2025, 12:08 PM
gerritbot added a comment.May 22 2025, 8:04 AM

Change #1147873 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PagaChangeEmissionTest: integration test for move and undelete

https://gerrit.wikimedia.org/r/1147873

gerritbot added a project: Patch-For-Review.May 22 2025, 8:04 AM
gerritbot added a comment.May 23 2025, 12:18 PM

Change #1147873 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: integration test for move and undelete

https://gerrit.wikimedia.org/r/1147873

gmodena updated the task description. (Show Details)Jun 6 2025, 12:41 PM
gerritbot added a comment.Jun 6 2025, 12:42 PM

Change #1154283 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] WIP: adopt undelete domain event.

https://gerrit.wikimedia.org/r/1154283

gmodena mentioned this in T389593: Introduce PageCreated event.Jun 10 2025, 3:28 PM
gerritbot added a comment.Jun 12 2025, 12:18 PM

Change #1147873 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: integration test for move and undelete

https://gerrit.wikimedia.org/r/1147873

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 12 2025, 1:00 PM
gerritbot added a comment.Jun 12 2025, 1:23 PM

Change #1156347 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumption

https://gerrit.wikimedia.org/r/1156347

gerritbot added a comment.Jun 12 2025, 4:33 PM

Change #1156347 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest::deleteAndAssertRedirectPage: Don't hard-code NS0 assumption

https://gerrit.wikimedia.org/r/1156347

gmodena added a subtask: T395327: mediawiki.page_change.v1 should not contain events for undelete into existing pages..Jun 13 2025, 5:17 PM
gmodena moved this task from In progress to In Review on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Jun 17 2025, 10:41 AM
gmodena moved this task from In Review to Ready to Deploy on the Data-Engineering (Q4 2025 April 1st - June 30th) board.Jun 20 2025, 7:40 PM
gerritbot added a comment.Jun 23 2025, 8:46 AM

Change #1154283 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] adopt undeletion domain event

https://gerrit.wikimedia.org/r/1154283

gerritbot added a comment.Jun 24 2025, 11:18 AM

Change #1163333 had a related patch set uploaded (by Gmodena; author: Gmodena):

[mediawiki/extensions/EventBus@master] PageChangeEmissionTest: assert undeletion domain event

https://gerrit.wikimedia.org/r/1163333

gmodena updated the task description. (Show Details)Jul 7 2025, 1:27 PM
gmodena moved this task from Ready to Deploy to Done on the Data-Engineering (Q4 2025 April 1st - June 30th) board.
Ahoelzl closed this task as Resolved.Jul 25 2025, 11:05 PM
Ahoelzl closed subtask T395327: mediawiki.page_change.v1 should not contain events for undelete into existing pages. as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits