Multiblocks: Display only active blocks on the top of blocked user's Special:Contributions page / when editing a blocked user's user [talk] page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Msz2001
	May 12 2025, 2:38 PM

Project Tags

Referenced Files

	F66003319: Block-notice-multi.png
	Sep 10 2025, 4:52 PM

	F65700554: Screenshot 2025-08-01 at 16.06.28.png
	Aug 1 2025, 2:12 PM

	F65700555: Screenshot 2025-08-01 at 16.06.22.png
	Aug 1 2025, 2:12 PM

	F59915860: image.png
	May 12 2025, 2:38 PM

Subscribers

View All 15 Subscribers

Description

Summary

Change the "block log excerpt" component shown on Special:Contributions, and shown when editing a blocked user's userpage/user talk page, to ignore expired or removed blocks.

Background

When viewing contributions of a blocked user, above the revisions list, there is a box with the most recent block log entry that relates to this user. Prior to the introduction of multiblocks, this was a convenient place to see, what are the current block's options and what's the reason for it.
A box like this also appears when editing the userpage/user talk page of a blocked user (or when viewing a nonexistent userpage/user talk page for a blocked user).

However, as it's possible to block a user multiple times, it may happen, that for a given blocked user, the most recent entry in the block log will be of the unblock type or will relate to a block that's already expired.

Due to this behavior, wiki users may see a rather uninformative box, presented on the screenshot below. This component can be changed to fetch information from the blocks table, as I believe these are easier to query in this setting and there's already a component for presenting these on Special:Block.

This screenshot refers to a user that was (in order):

Blocked site-wide
Blocked partially (almost at the same time as 1.)
Blocked site-wide (a redundant block, apparently admin wasn't aware of 1. due to 2. showing in the contribs)
Unblocked site-wide (once, the block from 3. was removed)

User story

As an Admin, I want to see the information about the active blocks of the user, whose contributions I am browsing / whose user [talk] page I am editing, in order to decide if the block configuration is sufficient.

Acceptance criteria

The box on Special:Contributions is updated to only display a log entry that matches a currently-active block. (https://gerrit.wikimedia.org/r/1185986)
The box shown when editing a blocked user's userpage/talk page is updated in the same way.
System messages used when displaying these excerpts are updated/reworded to no longer necessarily refer to the excerpt as the "latest block log entry". (if it's decided that this should happen)
Remove messages prefixed with sp-contributions-blocked-notice, in favour of those prefixed with blocked-notice-logextract, which have been newly added.

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Remove `sp-contributions-blocked-notice` messages	Dragoniez	mediawiki/core	master	+8 -24
Centralize block notice generation logic into LogEventsList::getBlockLogWarningBox	Dragoniez	mediawiki/core	master	+395 -128
Display only active block logs on Special:Contributions	Dragoniez	mediawiki/core	master	+150 -3

Customize query in gerrit

Related Objects

Mentioned In: T407501: Link to Special:BlockList in block notice box should use the narrowest IP as the wpTarget parameter
T404037: Two nearly simultaneous blocks to the same user result in two different blocks without warning
Mentioned Here: T407697: Block notice box should prioritize direct IP blocks
T384916: Update block log snippets for multiblocks

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2025, 2:39 PM

Msz2001 renamed this task from Multiblocks: Display only active blocks on the top of Special:Contributions page to Multiblocks: Display only active blocks on the top of blocked user's Special:Contributions page.May 12 2025, 2:41 PM

sgrabarczuk subscribed.May 12 2025, 2:44 PM

A_smart_kitten added projects: Multiblocks, MediaWiki-Logevents.May 12 2025, 2:47 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptMay 12 2025, 2:47 PM

Johannnes89 subscribed.May 12 2025, 3:16 PM

Dreamy_Jazz moved this task from Inbox to Tracking work by others on the Trust and Safety Product Team board.May 12 2025, 10:10 PM

Dragoniez triaged this task as High priority.Jul 24 2025, 1:49 AM

Dragoniez subscribed.

A recent example to demonstrate this issue: A user got blocked by two different admins who opened Special:Block at the same time. The second admin removed his block again, which leads to https://de.wikipedia.org/wiki/Spezial:Beiträge/Haster2?uselang=en&safemode=1 showing the unblock instead of the indefinite block from the first admin (https://de.wikipedia.org/w/index.php?title=Spezial:Logbuch&page=User%3AHaster2&type=block&user=&dir=prev&offset=20241107161556%7C138660209&limit=3&uselang=en&safemode=1)

Screenshot 2025-08-01 at 16.06.22.png (1,854×486 px, 241 KB)

Screenshot 2025-08-01 at 16.06.28.png (1,870×554 px, 145 KB)

This may be solved by option 4 of T384916: Update block log snippets for multiblocks. If the table is too cluttered, we can display a non-table version of block list such as this one: https://web.archive.org/web/20110506001416/http://en.wikipedia.org/wiki/Special:BlockList

Bewfip merged a task: T402495: About the UI text problem that shows that a block has been removed after one of the multiple blocks has been removed..Aug 21 2025, 9:02 AM

Bewfip added subscribers: 78-Yellowcat, Stang.

Ericliu1912 subscribed.Aug 21 2025, 10:02 PM

1F616EMO subscribed.Aug 24 2025, 3:10 PM

Dringsim subscribed.Aug 27 2025, 10:16 AM

Change #1185986 had a related patch set uploaded (by Dragoniez; author: Dragoniez):

[mediawiki/core@master] Display only active block logs on Special:Contributions

https://gerrit.wikimedia.org/r/1185986

gerritbot added a project: Patch-For-Review.Sep 8 2025, 4:45 PM

Dragoniez claimed this task.Sep 8 2025, 6:20 PM

MusikAnimal subscribed.Sep 9 2025, 12:27 AM

The patch should resolve the issue. I didn’t address the question of whether to display multiple active blocks instead of just one, though. I think we should address it in a separate task as needed, as this isn’t what this task focuses on and also we can’t leave this bug unresolved for a long time.

Change #1185986 merged by jenkins-bot:

[mediawiki/core@master] Display only active block logs on Special:Contributions

https://gerrit.wikimedia.org/r/1185986

Done. I'd like to add that it's not impossible to show multiple block logs if that's preferred, although we should discuss what the maximum number of such entries should be.

Block-notice-multi.png (1,373×460 px, 88 KB)

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 10 2025, 5:00 PM

MusikAnimal mentioned this in T404037: Two nearly simultaneous blocks to the same user result in two different blocks without warning.Sep 11 2025, 7:54 PM

A couple of questions:

Should the same change that's been made here (to how a block-log entry is selected for Special:Contributions) also be made for the other location(s) where a snippet of a user's block-log is displayed (e.g., when at the nonexistent userpage of a user that's currently blocked)?
Following this change, do we need to update/reword parts of these system messages; to reflect that the log-entry being displayed is no longer necessarily the 'latest block log entry'? If so, what would be the best wording to insert in its place?

A_smart_kitten moved this task from To triage to Special:Contributions / Special:DeletedContributions on the MediaWiki-Special-pages board.Sep 15 2025, 1:28 PM

It turns out that the patch isn't sufficient and it also needs to address LogEventsList::getBlockLogWarningBox, which generates the block notice shown when someone attempts to edit a user's user/user_talk page. In practice, it would be best to centralize the block log generation logic currently in ContributionsSpecialPage::contributionsSub into this method in the LogEventsList class.

The interface messages used in ContributionsSpecialPage are in a sense more "fine-grained", while LogEventsList only uses two:

LogEventsList

{
	"blocked-notice-logextract": "This {{GENDER:$1|user}} is currently blocked.\nThe latest block log entry is provided below for reference:",
	"blocked-notice-logextract-multi": "This {{GENDER:$1|user}} is currently blocked $2 {{PLURAL:$2|time|times}}.\nThe latest block log entry is provided below for reference:",
}

ContributionsSpecialPage

{
	"sp-contributions-blocked-notice": "This {{GENDER:$1|user}} is currently blocked.\nThe latest block log entry is provided below for reference:",
	"sp-contributions-blocked-notice-partial": "This {{GENDER:$1|user}} is currently partially blocked.\nThe latest block log entry is provided below for reference:",
	"sp-contributions-blocked-notice-anon": "This IP address is currently blocked.\nThe latest block log entry is provided below for reference:",
	"sp-contributions-blocked-notice-anon-partial": "This IP address is currently partially blocked.\nThe latest block log entry is provided below for reference:",
	"sp-contributions-blocked-notice-multi": "This {{GENDER:$1|user}} is currently blocked $2 {{PLURAL:$2|time|times}}.\nThe latest block log entry is provided below for reference:",
	"sp-contributions-blocked-notice-anon-multi": "This IP address is currently blocked $2 {{PLURAL:$2|time|times}}.\nThe latest block log entry is provided below for reference:",
}

Perhaps we should incorporate the latter into the former if we choose to do everything in LogEventsList::getBlockLogWarningBox.

(Boldly updated the task description & added AC for clarity; feel free to amend as appropriate)

Dragoniez awarded a token.Sep 16 2025, 2:20 PM

Change #1188868 had a related patch set uploaded (by Dragoniez; author: Dragoniez):

[mediawiki/core@master] Centralize block notice generation logic into LogEventsList::getBlockLogWarningBox

https://gerrit.wikimedia.org/r/1188868

gerritbot added a project: Patch-For-Review.Sep 16 2025, 7:09 PM

Dragoniez claimed this task.Sep 17 2025, 2:02 PM

@Dragoniez's current patch removes the sp-contributions-blocked-notice system messages, in favour of the (already-existing) blocked-notice-logextract series of messages.
I wonder if this is worth a User-notice, given that - judging by this Global Search - a number of communities override some of the sp-contributions-blocked-notice system messages that seem likely to be removed?

In T393902#11191824, @A_smart_kitten wrote:

@Dragoniez's current patch removes the sp-contributions-blocked-notice system messages, in favour of the (already-existing) blocked-notice-logextract series of messages.
I wonder if this is worth a User-notice, given that - judging by this Global Search - a number of communities override some of the sp-contributions-blocked-notice system messages that seem likely to be removed?

I can defer removal of the sp-contributions-blocked-notice messages to a follow-up patch to give communities time to translate the new messages before they take effect. If we do this, having a User-notice would indeed be a good option.

Dragoniez updated the task description. (Show Details)Sep 18 2025, 4:46 AM

How about something like the following?

The rollout of [[<tvar name="1">:mw:Special:MyLanguage/Help:Manage blocks</tvar>|multiblocks]] had the side effect that non-active block logs may have been shown on {{#special:Contributions}} and on blocked users' user/user_talk pages. This issue will be fully resolved in a few days. As part of the fix, [<tvar name="2">{{fullurl:Special:Allmessages|prefix=sp-contributions-blocked-notice}}</tvar> messages prefixed with <tvar name="3"><code>sp-contributions-blocked-notice</code></tvar>] will be removed and replaced with [<tvar name="4">{{fullurl:Special:Allmessages|prefix=blocked-notice-logextract}}</tvar> those prefixed with <tvar name="5"><code>blocked-notice-logextract</code></tvar>] in a few weeks. Please help translate the new messages and update any local overrides if needed.

This reads:

The rollout of multiblocks had the side effect that non-active block logs may have been shown on [[Special:Contributions]] and on blocked users’ user and user_talk pages. This issue will be fully resolved in a few days. As part of the fix, messages prefixed with sp-contributions-blocked-notice will be removed and replaced with those prefixed with blocked-notice-logextract in a few weeks. Please help translate the new messages and update any local overrides if needed.

Test wiki created on Patch demo by A smart kitten using patch(es) linked to this task:
https://e34a5ae872.catalyst.wmcloud.org/wiki/Main Page

In T393902#11192450, @Dragoniez wrote:
How about something like the following?
The rollout of [[<tvar name="1">:mw:Special:MyLanguage/Help:Manage blocks</tvar>|multiblocks]] had the side effect that non-active block logs may have been shown on {{#special:Contributions}} and on blocked users' user/user_talk pages. This issue will be fully resolved in a few days. As part of the fix, [<tvar name="2">{{fullurl:Special:Allmessages|prefix=sp-contributions-blocked-notice}}</tvar> messages prefixed with <tvar name="3"><code>sp-contributions-blocked-notice</code></tvar>] will be removed and replaced with [<tvar name="4">{{fullurl:Special:Allmessages|prefix=blocked-notice-logextract}}</tvar> those prefixed with <tvar name="5"><code>blocked-notice-logextract</code></tvar>] in a few weeks. Please help translate the new messages and update any local overrides if needed.
This reads:

The rollout of multiblocks had the side effect that non-active block logs may have been shown on [[Special:Contributions]] and on blocked users’ user and user_talk pages. This issue will be fully resolved in a few days. As part of the fix, messages prefixed with sp-contributions-blocked-notice will be removed and replaced with those prefixed with blocked-notice-logextract in a few weeks. Please help translate the new messages and update any local overrides if needed.

@Dragoniez When should this be announced?

@UOzurumba Thanks for your comment. It can be announced as soon as gerrit:1188868 is merged. The patch is basically ready and just waiting for a +2.

In T393902#11192450, @Dragoniez wrote:

This issue will be fully resolved in a few days.

Perhaps this should be changed to This issue is resolved now. or something similar once the patch has been merged. I’d appreciate any adjustments if the wording doesn’t seem to match the context or timing of the announcement.

Test wiki created on Patch demo by JNuche (WMF) using patch(es) linked to this task:
https://2c8deb3c0d.catalyst.wmcloud.org/w/

Test wiki on Patch demo by JNuche (WMF) using patch(es) linked to this task was deleted:

~~https://2c8deb3c0d.catalyst.wmcloud.org/w/~~

Test wiki created on Patch demo by JNuche (WMF) using patch(es) linked to this task:
https://f9860a71e1.catalyst.wmcloud.org/w/

Test wiki on Patch demo by JNuche (WMF) using patch(es) linked to this task was deleted:

~~https://f9860a71e1.catalyst.wmcloud.org/w/~~

^ Please ignore the noise, I was doing some testing

UOzurumba moved this task from To Triage to Announce in next Tech/News on the User-notice board.Sep 19 2025, 2:41 PM

In T393902#11196251, @Dragoniez wrote:

In T393902#11192450, @Dragoniez wrote:

This issue will be fully resolved in a few days.

Perhaps this should be changed to This issue is resolved now. or something similar once the patch has been merged. I’d appreciate any adjustments if the wording doesn’t seem to match the context or timing of the announcement.

I've merged it now. Given that the patch will go out next week, I think the wording should be "The issue will be fully resolved in a few days" so that when it goes out on Monday the 29th users would expect to see the change once it reaches their wiki (which should be by Thursday)

Change #1188868 merged by jenkins-bot:

[mediawiki/core@master] Centralize block notice generation logic into LogEventsList::getBlockLogWarningBox

https://gerrit.wikimedia.org/r/1188868

What remains is to remove the sp-contributions-blocked-notice messages and fully replace them with the new blocked-notice-logextract messages. I'll deal with this in a couple of weeks, once communities have had reasonable time to translate the new ones.

Note that I didn't update the old messages to include "active" as in "The latest active block log entry", since they're going to be removed. Currently, the new blocked-notice-logextract messages are used only for sitewide (multi-)blocks affecting non-IP users. This means that block notices for partial blocks and IP blocks still use "The latest block log entry", without "active". A follow-up patch will address this and satisfy all the acceptance criteria.

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30); removed: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 23 2025, 1:01 PM

STei-WMF moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Sep 25 2025, 6:29 PM

STei-WMF moved this task from In current Tech/News draft to Announce in next Tech/News on the User-notice board.

Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Sep 26 2025, 8:23 PM

STei-WMF moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 1 2025, 4:55 PM

Change #1194561 had a related patch set uploaded (by Dragoniez; author: Dragoniez):

[mediawiki/core@master] Remove `sp-contributions-blocked-notice` messages

https://gerrit.wikimedia.org/r/1194561

gerritbot added a project: Patch-For-Review.Oct 8 2025, 9:11 AM

Dragoniez closed this task as Resolved.Oct 8 2025, 9:51 AM

Dragoniez removed a project: Patch-For-Review.

Dragoniez updated the task description. (Show Details)

Change #1194561 merged by jenkins-bot:

[mediawiki/core@master] Remove `sp-contributions-blocked-notice` messages

https://gerrit.wikimedia.org/r/1194561

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14); removed: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Oct 8 2025, 11:02 AM

Thanks for seeing this through @Dragoniez :)

In T393902#11255488, @A_smart_kitten wrote:

Thanks for seeing this through @Dragoniez :)

+1 to this

In T393902#11255488, @A_smart_kitten wrote:

Thanks for seeing this through @Dragoniez :)

In T393902#11255511, @Dreamy_Jazz wrote:

In T393902#11255488, @A_smart_kitten wrote:

Thanks for seeing this through @Dragoniez :)

+1 to this

Sure thing :) Thanks for all the reviews

Stang unsubscribed.Oct 14 2025, 1:22 PM

Dragoniez mentioned this in T407501: Link to Special:BlockList in block notice box should use the narrowest IP as the wpTarget parameter.Oct 16 2025, 2:07 PM

I just started to wonder about something. With the current specs, the newest active block log is shown consistently, regardless of the user type. However, in a scenario like:

A single IP is blocked (say, 255.255.255.255)
A CIDR containing this IP is blocked afterwards (say, 255.255.255.254/31)

Should we show the block log for 255.255.255.255 instead even though it's older?

→ T407697: Block notice box should prioritize direct IP blocks

Maintenance_bot edited projects, added: User-notice-archive; removed: User-notice.Oct 28 2025, 5:31 PM

Multiblocks: Display only active blocks on the top of blocked user's Special:Contributions page / when editing a blocked user's user [talk] pageClosed, ResolvedPublicActions