Page MenuHomePhabricator

Use a service instead of a static function call for MediaWiki\Skins\Vector\ConfigHelper::shouldDisable
Closed, ResolvedPublic

Description

  • This allows to use dependency injection for the service SpecialPageFactory.
  • The function ConfigHelper::shouldDisable must be changed from static to non-static
  • The skin MinervaNeue must use the service instead of the static function.

QA

  • Check that the history page is not limited in width like article pages on Vector
  • Check dark mode exclusions still work on Minerva ( VectorNightModeOptions)
  • Check dark mode exclusions still work on Vector (VectorNightModeOptions)

Event Timeline

Change #1143951 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Vector@master] Create new service 'Vector.ConfigHelper' and inject this service

https://gerrit.wikimedia.org/r/1143951

Change #1143952 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Use service 'Vector.ConfigHelper' instead of ConfigHelper::shouldDisable

https://gerrit.wikimedia.org/r/1143952

Change #1143945 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Vector@master] Inject service SpecialPageFactory into service 'Vector.ConfigHelper'

https://gerrit.wikimedia.org/r/1143945

Change #1143951 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Create new service 'Vector.ConfigHelper' and inject this service

https://gerrit.wikimedia.org/r/1143951

Change #1143952 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use service 'Vector.ConfigHelper' instead of ConfigHelper::shouldDisable

https://gerrit.wikimedia.org/r/1143952

Change #1143945 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Inject service SpecialPageFactory into service 'Vector.ConfigHelper'

https://gerrit.wikimedia.org/r/1143945

Jdlrobson-WMF triaged this task as Low priority.
Jdlrobson-WMF edited projects, added: Vector 2022; removed: Vector (legacy skin).
Jdlrobson-WMF added a project: Web-Team.
Jdlrobson-WMF updated the task description. (Show Details)

Change #1147018 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Suppress false positive Phan error

https://gerrit.wikimedia.org/r/1147018

Change #1147019 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Remove backward compatibility to old Vector version

https://gerrit.wikimedia.org/r/1147019

Change #1147018 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Suppress false positive Phan error

https://gerrit.wikimedia.org/r/1147018

Change #1147019 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove backward compatibility to old Vector version

https://gerrit.wikimedia.org/r/1147019