Page MenuHomePhabricator
Create Task
Maniphest T393961

Use a service instead of a static function call for MediaWiki\Skins\Vector\ConfigHelper::shouldDisable
Closed, ResolvedPublic
Actions

Description

  • This allows to use dependency injection for the service SpecialPageFactory.
  • The function ConfigHelper::shouldDisable must be changed from static to non-static
  • The skin MinervaNeue must use the service instead of the static function.

QA

  • Check that the history page is not limited in width like article pages on Vector
  • Check dark mode exclusions still work on Minerva ( VectorNightModeOptions)
  • Check dark mode exclusions still work on Vector (VectorNightModeOptions)

Details

Other Assignee
Jdlrobson-WMF
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove backward compatibility to old Vector versionmediawiki/skins/MinervaNeuemaster+1 -4
Suppress false positive Phan errormediawiki/skins/MinervaNeuemaster+1 -0
Inject service SpecialPageFactory into service 'Vector.ConfigHelper'mediawiki/skins/Vectormaster+13 -5
Use service 'Vector.ConfigHelper' instead of ConfigHelper::shouldDisablemediawiki/skins/MinervaNeuemaster+30 -5
Create new service 'Vector.ConfigHelper' and inject this servicemediawiki/skins/Vectormaster+53 -18
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.May 12 2025, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2025, 8:02 PM
gerritbot added a comment.May 12 2025, 8:02 PM

Change #1143951 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Vector@master] Create new service 'Vector.ConfigHelper' and inject this service

https://gerrit.wikimedia.org/r/1143951

gerritbot added a project: Patch-For-Review.May 12 2025, 8:02 PM

Change #1143952 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Use service 'Vector.ConfigHelper' instead of ConfigHelper::shouldDisable

https://gerrit.wikimedia.org/r/1143952

gerritbot added a comment.May 12 2025, 8:03 PM

Change #1143945 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/Vector@master] Inject service SpecialPageFactory into service 'Vector.ConfigHelper'

https://gerrit.wikimedia.org/r/1143945

Jdlrobson-WMF updated the task description. (Show Details)May 12 2025, 10:36 PM
Jdlrobson-WMF updated Other Assignee, added: Jdlrobson-WMF.
gerritbot added a comment.May 14 2025, 7:54 PM

Change #1143951 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Create new service 'Vector.ConfigHelper' and inject this service

https://gerrit.wikimedia.org/r/1143951

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 8:00 PM
gerritbot added a comment.May 14 2025, 8:09 PM

Change #1143952 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use service 'Vector.ConfigHelper' instead of ConfigHelper::shouldDisable

https://gerrit.wikimedia.org/r/1143952

gerritbot added a comment.May 14 2025, 8:09 PM

Change #1143945 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Inject service SpecialPageFactory into service 'Vector.ConfigHelper'

https://gerrit.wikimedia.org/r/1143945

Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 8:30 PM
Jdlrobson-WMF closed this task as Resolved.May 14 2025, 9:53 PM
Jdlrobson-WMF triaged this task as Low priority.
Jdlrobson-WMF edited projects, added: Vector 2022; removed: Vector (legacy skin).
Jdlrobson-WMF added a project: Web-Team.
Jdlrobson-WMF updated the task description. (Show Details)
gerritbot added a comment.May 16 2025, 3:19 PM

Change #1147018 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Suppress false positive Phan error

https://gerrit.wikimedia.org/r/1147018

gerritbot added a project: Patch-For-Review.May 16 2025, 3:19 PM
gerritbot added a comment.May 16 2025, 3:26 PM

Change #1147019 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/skins/MinervaNeue@master] Remove backward compatibility to old Vector version

https://gerrit.wikimedia.org/r/1147019

gerritbot added a comment.May 16 2025, 5:18 PM

Change #1147018 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Suppress false positive Phan error

https://gerrit.wikimedia.org/r/1147018

gerritbot added a comment.May 20 2025, 2:30 PM

Change #1147019 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove backward compatibility to old Vector version

https://gerrit.wikimedia.org/r/1147019

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 20 2025, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 3:30 PM
Edtadros mentioned this in T394329: Verify 1.45.0-wmf.3 deployment.May 30 2025, 2:57 PM
Jdlrobson-WMF added a project: Verified.May 30 2025, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits