Page MenuHomePhabricator
Create Task
Maniphest T393974

MobileFrontend skin hooks should use injected MediaWiki services
Closed, ResolvedPublic
Actions

Description

MobileFrontend injects hooks. It currently calls MediaWikiServices::getInstance() but should instead have services injected for consistency with other code.

Acceptance criteria

  • Desktop skin contains a link to mobile site
  • Mobile skin contains a link to desktop site
  • The terms of use link points to the correct page

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Inject service UrlUtils into MobileFrontendSkinHooksmediawiki/extensions/MobileFrontendmaster+30 -10
Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.May 12 2025, 10:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2025, 10:01 PM
gerritbot added a comment.May 12 2025, 10:01 PM

Change #1143924 had a related patch set uploaded (by Jdlrobson; author: Fomafix):

[mediawiki/extensions/MobileFrontend@master] Inject service UrlUtils into MobileFrontendSkinHooks

https://gerrit.wikimedia.org/r/1143924

gerritbot added a project: Patch-For-Review.May 12 2025, 10:01 PM
Jdlrobson-WMF triaged this task as Low priority.May 12 2025, 10:01 PM
gerritbot added a comment.May 13 2025, 5:46 PM

Change #1143924 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Inject service UrlUtils into MobileFrontendSkinHooks

https://gerrit.wikimedia.org/r/1143924

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 13 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2025, 6:31 PM
Jdlrobson-WMF closed this task as Resolved.May 14 2025, 6:30 PM
Jdlrobson-WMF claimed this task.

Beta cluster seems to be working as expected. Noting that beta cluster terms of use link points to non-existent https://mobile.test/wiki/Terms_of_Use but that is not new [1]

[1] https://web.archive.org/web/20250120110341/https://en.m.wikipedia.beta.wmflabs.org/wiki/T352930

Jdlrobson-WMF updated the task description. (Show Details)May 14 2025, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits