Maniphest T393982

Duplicate IDs regression for mw:FallbackId spans
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABreault-WMF
	May 13 2025, 12:12 AM

Project Tags

Referenced Files

None

Subscribers

Description

In https://github.com/wikimedia/mediawiki-services-parsoid/commit/a8fb2fa1624d0afde120fe090d133ad70e7348c8, generating anchors was moved before linting to lint empty headings. However, that pass also introduces mw:FallbackId spans, which are also deduplicated and don't need linting for duplicates.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.22.0-a3	mediawiki/vendor	master	+7 K -3 K
	Bump wikimedia/parsoid to 0.22.0-a3	mediawiki/vendor	master	+1 K -3 K
	Don't emit duplicate id lint errors from mw:FallbackId spans	mediawiki/services/parsoid	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned In: T407533: Do not flag duplicate section headings as duplicate IDs
T393230: False linter positives if headers contain non-ASCII characters
T200517: Emit lint error or category when a page uses duplicate HTML IDs
Mentioned Here: T200517: Emit lint error or category when a page uses duplicate HTML IDs

Event Timeline

ABreault-WMF created this task.May 13 2025, 12:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2025, 12:12 AM

Change #1144689 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Don't emit duplicate id lint errors from mw:FallbackId spans

https://gerrit.wikimedia.org/r/1144689

gerritbot added a project: Patch-For-Review.May 13 2025, 12:27 AM

This is probably what was reported in https://phabricator.wikimedia.org/T200517#10785684, correct?

Change #1144689 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Don't emit duplicate id lint errors from mw:FallbackId spans

https://gerrit.wikimedia.org/r/1144689

Maintenance_bot removed a project: Patch-For-Review.May 13 2025, 9:30 AM

In T393982#10815110, @ihurbain wrote:

This is probably what was reported in https://phabricator.wikimedia.org/T200517#10785684, correct?

I believe so. Thanks for noting it

ABreault-WMF triaged this task as Medium priority.May 13 2025, 2:13 PM

ABreault-WMF moved this task from Backlog to To Deploy on the Content-Transform-Team (Work In Progress) board.

ABreault-WMF merged a task: T393230: False linter positives if headers contain non-ASCII characters.May 15 2025, 4:06 PM

ABreault-WMF mentioned this in T393230: False linter positives if headers contain non-ASCII characters.

ABreault-WMF added subscribers: RolandUnger, Alex44019.

Change #1147810 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

gerritbot added a project: Patch-For-Review.May 19 2025, 4:35 PM

Change #1147810 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

Maintenance_bot removed a project: Patch-For-Review.May 19 2025, 8:31 PM

Ranveig subscribed.May 21 2025, 7:13 AM

ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.May 21 2025, 10:14 PM

ABreault-WMF closed this task as Resolved.May 21 2025, 10:20 PM

Change #1162957 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1162957

gerritbot added a project: Patch-For-Review.Jun 23 2025, 4:00 PM

Change #1162957 abandoned by Jgiannelos:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1162957

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 4:32 PM

ABreault-WMF mentioned this in T407533: Do not flag duplicate section headings as duplicate IDs.Oct 16 2025, 7:20 PM