Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(459)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.1/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(310)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(459)MediaWiki\Xml\Xml::input(string, int, string, array)
#7/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(437)MediaWiki\Xml\Xml::inputLabelSep(string, string, string, int, string, array)
#8/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtView.php(960)MediaWiki\Xml\Xml::inputLabel(string, string, string, int, string, array)
#9/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtView.php(797)LqtView->getSubjectEditor(string, string)
#10/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtView.php(1581)LqtView->showPostEditingForm(Thread)
#11/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtView.php(1853)LqtView->showThreadBody(Thread)
#12/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtView.php(2201)LqtView->showSingleThread(Thread)
#13/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/Pages/ThreadPermalinkView.php(221)LqtView->showThread(Thread, int, int, array)
#14/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtDispatch.php(114)ThreadPermalinkView->show()
#15/srv/mediawiki/php-1.45.0-wmf.1/extensions/LiquidThreads/includes/LqtDispatch.php(234)LqtDispatch::threadPermalinkMain(MediaWiki\Output\OutputPage, MediaWiki\Page\Article, MediaWiki\Title\Title, MediaWiki\User\User, MediaWiki\Request\WebRequest)
#16/srv/mediawiki/php-1.45.0-wmf.1/includes/HookContainer/HookContainer.php(155)LqtDispatch::tryPage(MediaWiki\Output\OutputPage, MediaWiki\Page\Article, MediaWiki\Title\Title, MediaWiki\User\User, MediaWiki\Request\WebRequest, MediaWiki\Actions\ActionEntryPoint)
#17/srv/mediawiki/php-1.45.0-wmf.1/includes/HookContainer/HookRunner.php(2600)MediaWiki\HookContainer\HookContainer->run(string, array)
#18/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(692)MediaWiki\HookContainer\HookRunner->onMediaWikiPerformAction(MediaWiki\Output\OutputPage, MediaWiki\Page\Article, MediaWiki\Title\Title, MediaWiki\User\User, MediaWiki\Request\WebRequest, MediaWiki\Actions\ActionEntryPoint)
#19/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(505)MediaWiki\Actions\ActionEntryPoint->performAction(MediaWiki\Page\Article, MediaWiki\Title\Title)
#20/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#21/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#22/srv/mediawiki/php-1.45.0-wmf.1/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#23/srv/mediawiki/w/index.php(3)require(string)
#24{main}
Notes

Started after deploying 1.45.0-wmf.1 to group0. Volume is tiny as of this writing.

Surfaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1141084, which was merged as part of T341775. The offending code is https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/4ed03d640801a2a2e13d7993829d49c1b4823237/includes/xml/Xml.php#459

Event Timeline

Change #1146090 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Xml::inputLabelSep: Don't use now-hard-deprecated Xml::input

https://gerrit.wikimedia.org/r/1146090

Change #1146623 had a related patch set uploaded (by Nikerabbit; author: Abijeet Patro):

[mediawiki/extensions/LiquidThreads@master] Xml::input, label: Replace usage with Html::input, label

https://gerrit.wikimedia.org/r/1146623

Change #1146623 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Xml::input, label: Replace usage with Html::input, label

https://gerrit.wikimedia.org/r/1146623

Change #1146654 had a related patch set uploaded (by Jforrester; author: Abijeet Patro):

[mediawiki/extensions/LiquidThreads@wmf/1.45.0-wmf.1] Xml::input, label: Replace usage with Html::input, label

https://gerrit.wikimedia.org/r/1146654

Change #1146654 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@wmf/1.45.0-wmf.1] Xml::input, label: Replace usage with Html::input, label

https://gerrit.wikimedia.org/r/1146654

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:55:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]]

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:57:41Z] <jforrester@deploy1003> mszabo, jforrester: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes c

Mentioned in SAL (#wikimedia-operations) [2025-05-20T21:06:31Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] (duration: 11m 28s)

@Jdforrester-WMF I'm still seeing hits for Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. and Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. in 1.45.0-wmf.2. Here's a fresh example:

Error
normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.2/includes/xml/Xml.php(459)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.2/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.2/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.2/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.2/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.2/includes/xml/Xml.php(310)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.2/includes/xml/Xml.php(459)MediaWiki\Xml\Xml::input(string, int, string, array)
#7/srv/mediawiki/php-1.45.0-wmf.2/includes/xml/Xml.php(437)MediaWiki\Xml\Xml::inputLabelSep(string, string, string, int, string, array)
#8/srv/mediawiki/php-1.45.0-wmf.2/extensions/FlaggedRevs/includes/frontend/RejectConfirmationFormUI.php(208)MediaWiki\Xml\Xml::inputLabel(string, string, string, int, string, array)
#9/srv/mediawiki/php-1.45.0-wmf.2/extensions/FlaggedRevs/includes/frontend/specialpages/actions/RevisionReview.php(123)RejectConfirmationFormUI->getHtml()
#10/srv/mediawiki/php-1.45.0-wmf.2/includes/specialpage/SpecialPage.php(734)RevisionReview->execute(null)
#11/srv/mediawiki/php-1.45.0-wmf.2/includes/specialpage/SpecialPageFactory.php(1738)MediaWiki\SpecialPage\SpecialPage->run(null)
#12/srv/mediawiki/php-1.45.0-wmf.2/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#13/srv/mediawiki/php-1.45.0-wmf.2/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#14/srv/mediawiki/php-1.45.0-wmf.2/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#15/srv/mediawiki/php-1.45.0-wmf.2/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#16/srv/mediawiki/w/index.php(3)require(string)
#17{main}

That looks like a separate task; this is LiquidThreads, that is FlaggedRevs

That looks like a separate task; this is LiquidThreads, that is FlaggedRevs

Yeah; T394403 was fixed, but looks like there are secondary paths.

Change #1146090 merged by jenkins-bot:

[mediawiki/core@master] Xml::inputLabelSep: Don't use now-hard-deprecated Xml::input

https://gerrit.wikimedia.org/r/1146090