Page MenuHomePhabricator
Create Task
Maniphest T394053

PHP Warning: Invalid label key: 'same-wt'
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Warning: Invalid label key: 'same-wt'
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/includes/libs/Stats/Metrics/MetricTrait.php(102)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1/srv/mediawiki/php-1.45.0-wmf.1/includes/libs/Stats/Metrics/MetricTrait.php(102)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/libs/Stats/Metrics/MetricTrait.php(111)Wikimedia\Stats\Metrics\CounterMetric->setLabel(string, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/parser/Parsoid/Config/SiteConfig.php(286)Wikimedia\Stats\Metrics\CounterMetric->setLabels(array)
#4/srv/mediawiki/php-1.45.0-wmf.1/vendor/wikimedia/parsoid/src/Parsoid.php(416)MediaWiki\Parser\Parsoid\Config\SiteConfig->incrementCounter(string, array, float)
#5/srv/mediawiki/php-1.45.0-wmf.1/vendor/wikimedia/parsoid/src/Parsoid.php(306)Wikimedia\Parsoid\Parsoid->recordParseMetrics(Wikimedia\Parsoid\Config\Env, float, array, array, string, array)
#6/srv/mediawiki/php-1.45.0-wmf.1/includes/parser/Parsoid/ParsoidParser.php(166)Wikimedia\Parsoid\Parsoid->wikitext2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array, array, MediaWiki\Parser\ParserOutput)
#7/srv/mediawiki/php-1.45.0-wmf.1/includes/parser/Parsoid/ParsoidParser.php(301)MediaWiki\Parser\Parsoid\ParsoidParser->genParserOutput(MediaWiki\Parser\Parsoid\Config\PageConfig, MediaWiki\Parser\ParserOptions, MediaWiki\Parser\ParserOutput)
#8/srv/mediawiki/php-1.45.0-wmf.1/includes/content/WikitextContentHandler.php(380)MediaWiki\Parser\Parsoid\ParsoidParser->parse(string, MediaWiki\Title\Title, MediaWiki\Parser\ParserOptions, bool, bool, int, MediaWiki\Parser\ParserOutput)
#9/srv/mediawiki/php-1.45.0-wmf.1/includes/content/ContentHandler.php(1693)MediaWiki\Content\WikitextContentHandler->fillParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams, MediaWiki\Parser\ParserOutput)
#10/srv/mediawiki/php-1.45.0-wmf.1/includes/content/Renderer/ContentRenderer.php(75)MediaWiki\Content\ContentHandler->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Content\Renderer\ContentParseParams)
#11/srv/mediawiki/php-1.45.0-wmf.1/includes/Revision/RenderedRevision.php(261)MediaWiki\Content\Renderer\ContentRenderer->getParserOutput(MediaWiki\Content\WikitextContent, MediaWiki\Page\PageIdentityValue, MediaWiki\Revision\RevisionStoreRecord, MediaWiki\Parser\ParserOptions, array)
#12/srv/mediawiki/php-1.45.0-wmf.1/includes/Revision/RenderedRevision.php(233)MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(MediaWiki\Content\WikitextContent, array)
#13/srv/mediawiki/php-1.45.0-wmf.1/includes/Revision/RevisionRenderer.php(236)MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string, array)
#14/srv/mediawiki/php-1.45.0-wmf.1/includes/Revision/RevisionRenderer.php(169)MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, MediaWiki\Parser\ParserOptions, array)
#15/srv/mediawiki/php-1.45.0-wmf.1/includes/Revision/RenderedRevision.php(196)MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#16/srv/mediawiki/php-1.45.0-wmf.1/includes/page/ParserOutputAccess.php(454)MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#17/srv/mediawiki/php-1.45.0-wmf.1/includes/page/ParserOutputAccess.php(364)MediaWiki\Page\ParserOutputAccess->renderRevision(MediaWiki\Page\PageStoreRecord, MediaWiki\Parser\ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int, MediaWiki\Parser\ParserOutput)
#18/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(937)MediaWiki\Page\ParserOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, MediaWiki\Parser\ParserOptions, MediaWiki\Revision\RevisionStoreRecord, int)
#19/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(669)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutputInternal()
#20/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php(763)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getParserOutput()
#21/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Handler/ParsoidHandler.php(739)MediaWiki\Rest\Handler\Helper\HtmlOutputRendererHelper->getPageBundle()
#22/srv/mediawiki/php-1.45.0-wmf.1/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(90)MediaWiki\Rest\Handler\ParsoidHandler->wt2html(MediaWiki\Parser\Parsoid\Config\PageConfig, array)
#23/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Module/Module.php(416)MWParsoid\Rest\Handler\PageHandler->execute()
#24/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Module/Module.php(299)MediaWiki\Rest\Module\Module->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#25/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Router.php(485)MediaWiki\Rest\Module\Module->execute(string, MediaWiki\Rest\RequestFromGlobals)
#26/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/Router.php(444)MediaWiki\Rest\Router->doExecute(string, MediaWiki\Rest\RequestFromGlobals)
#27/srv/mediawiki/php-1.45.0-wmf.1/includes/Rest/EntryPoint.php(209)MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#28/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Rest\EntryPoint->execute()
#29/srv/mediawiki/php-1.45.0-wmf.1/rest.php(39)MediaWiki\MediaWikiEntryPoint->run()
#30/srv/mediawiki/w/rest.php(3)require(string)
#31{main}
Notes

Started with the rollout of 1.45.0-wmf.1 to group0. Volume is currently very small, all affecting the MediaWiki wiki.

I can't find any recent changes in the code that may be directly related, but I did find this Parsoid version bump: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1143140

Details

Request URL
https://www.mediawiki.org/w/rest.php/www.mediawiki.org/v3/page/pagebundle/Extension%3AWikidataPageBanner%2Ffr/6617845
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.22.0-a3mediawiki/vendormaster+7 K -3 K
Bump wikimedia/parsoid to 0.22.0-a3mediawiki/vendormaster+1 K -3 K
stats: labels should not contain hyphensmediawiki/extensions/GrowthExperimentsmaster+1 -1
Stats: Add temporary deprecation for addLabel() normalizationmediawiki/coremaster+25 -5
Stats: Add temporary deprecation for addLabel() normalizationmediawiki/corewmf/1.45.0-wmf.1+24 -5
Revert "Stats: Remove not needed key normalization"mediawiki/coremaster+18 -8
Avoid invalid characters in metric label namesmediawiki/services/parsoidmaster+15 -13
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasejnucheT392171 1.45.0-wmf.1 deployment blockers
 ResolvedPRODUCTION ERRORKrinkleT394053 PHP Warning: Invalid label key: 'same-wt'

Event Timeline

jnuche created this task.May 13 2025, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2025, 3:00 PM
jnuche triaged this task as Unbreak Now! priority.May 14 2025, 10:49 AM

The volume for these logs has significantly ramped up after deploying 1.45.0-wmf.1 to group1. As usual the largest impact is on commons:

image.png (474×1 px, 76 KB)

The message is a warning, but I'm concerned about the log volume if we deploy this to all wikis, so I'm tentatively marking this as UBN! to make sure we get feedback before then.

jnuche added a parent task: T392171: 1.45.0-wmf.1 deployment blockers.May 14 2025, 10:49 AM
jnuche added subscribers: ihurbain, ABreault-WMF, • mszabo.May 14 2025, 11:04 AM
gerritbot added a comment.May 14 2025, 11:25 AM

Change #1145862 had a related patch set uploaded (by Máté Szabó; author: Máté Szabó):

[mediawiki/services/parsoid@master] Avoid invalid characters in metric label names

https://gerrit.wikimedia.org/r/1145862

gerritbot added a project: Patch-For-Review.May 14 2025, 11:25 AM
cscott added a comment.EditedMay 14 2025, 1:55 PM

This was a regression caused by 56c417299ab9899858290098838f50c19a1d6760 in core and I am recommending a rollback of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1133094 rather than a new release of Parsoid to address this for this week's train, as the strict label checking will cause a stats dropout of other affected code in addition to causing logspam.

gerritbot added a comment.May 14 2025, 1:56 PM

Change #1145950 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Revert "Stats: Remove not needed key normalization"

https://gerrit.wikimedia.org/r/1145950

gerritbot added a comment.May 14 2025, 2:10 PM

Change #1145862 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid invalid characters in metric label names

https://gerrit.wikimedia.org/r/1145862

gerritbot added a comment.May 14 2025, 2:28 PM

Change #1145950 abandoned by Jforrester:

[mediawiki/core@master] Revert "Stats: Remove not needed key normalization"

Reason:

Reverting this is hopeless.

https://gerrit.wikimedia.org/r/1145950

Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 2:30 PM
gerritbot added a comment.May 14 2025, 4:00 PM

Change #1146015 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] Stats: Add temporary deprecation for addLabel() normalization

https://gerrit.wikimedia.org/r/1146015

gerritbot added a project: Patch-For-Review.May 14 2025, 4:00 PM
gerritbot added a comment.May 14 2025, 4:32 PM

Change #1146019 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/GrowthExperiments@master] stats: labels should not contain hyphens

https://gerrit.wikimedia.org/r/1146019

gerritbot added a comment.May 14 2025, 5:51 PM

Change #1146029 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@wmf/1.45.0-wmf.1] Stats: Add temporary deprecation for addLabel() normalization

https://gerrit.wikimedia.org/r/1146029

gerritbot added a comment.May 14 2025, 7:00 PM

Change #1146029 merged by jenkins-bot:

[mediawiki/core@wmf/1.45.0-wmf.1] Stats: Add temporary deprecation for addLabel() normalization

https://gerrit.wikimedia.org/r/1146029

Stashbot added a comment.May 14 2025, 7:01 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T19:01:23Z] <jhuneidi@deploy1003> Started scap sync-world: Backport for [[gerrit:1146029|Stats: Add temporary deprecation for addLabel() normalization (T394053)]]

Stashbot added a comment.May 14 2025, 7:08 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T19:08:18Z] <jhuneidi@deploy1003> jhuneidi, krinkle: Backport for [[gerrit:1146029|Stats: Add temporary deprecation for addLabel() normalization (T394053)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.May 14 2025, 7:16 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T19:16:48Z] <jhuneidi@deploy1003> Finished scap sync-world: Backport for [[gerrit:1146029|Stats: Add temporary deprecation for addLabel() normalization (T394053)]] (duration: 15m 24s)

gerritbot added a comment.May 14 2025, 7:31 PM

Change #1146015 merged by jenkins-bot:

[mediawiki/core@master] Stats: Add temporary deprecation for addLabel() normalization

https://gerrit.wikimedia.org/r/1146015

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 8:00 PM
Jdforrester-WMF closed this task as Resolved.May 14 2025, 8:51 PM
Jdforrester-WMF assigned this task to Krinkle.
Jdforrester-WMF subscribed.

image.png (1×3 px, 281 KB)

This appears to be fixed in prod; thank you! Given that the next Parsoid release won't trigger a warning with the merged code, so calling this Resolved.

gerritbot added a comment.May 14 2025, 10:29 PM

Change #1146019 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] stats: labels should not contain hyphens

https://gerrit.wikimedia.org/r/1146019

Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 10:30 PM
colewhite mentioned this in T394361: Consider reducing usage of StatsUtils::normalizeString.May 14 2025, 11:07 PM
gerritbot added a comment.May 19 2025, 4:35 PM

Change #1147810 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

gerritbot added a project: Patch-For-Review.May 19 2025, 4:35 PM
gerritbot added a comment.May 19 2025, 8:29 PM

Change #1147810 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1147810

Maintenance_bot removed a project: Patch-For-Review.May 19 2025, 8:30 PM
gerritbot added a comment.Jun 23 2025, 4:00 PM

Change #1162957 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1162957

gerritbot added a project: Patch-For-Review.Jun 23 2025, 4:00 PM
gerritbot added a comment.Jun 23 2025, 4:26 PM

Change #1162957 abandoned by Jgiannelos:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a3

https://gerrit.wikimedia.org/r/1162957

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2025, 4:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits