Page MenuHomePhabricator
Create Task
Maniphest T394073

ApiShortenUrl: TransactionProfiler warnings created by API as it is not marked as performing writes
Closed, ResolvedPublic
Actions

Description

The MediaWiki-extensions-UrlShortener extension has an API named ApiShortenUrl which is currently marked as not performing writes. This means that there are lots of TransactionProfiler warnings present (one for each API call).

Marking the API as performing writes just needs defining ::doesWrites as true.

Acceptance criteria
  • ApiShortenUrl no longer raises TransactionProfiler warnings when called

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Mark ApiShortenUrl as an API that performs writesmediawiki/extensions/UrlShortenermaster+10 -0
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.May 13 2025, 4:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2025, 4:57 PM
gerritbot added a comment.May 13 2025, 5:00 PM

Change #1145268 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/UrlShortener@master] Mark ApiShortenUrl as an API that performs writes

https://gerrit.wikimedia.org/r/1145268

gerritbot added a project: Patch-For-Review.May 13 2025, 5:00 PM
Dreamy_Jazz renamed this task from ApiShortenUrl: Lots of TransactionProfiler warnings because API is not marked as performing writes to ApiShortenUrl: TransactionProfiler warnings created by API as it is not marked as performing writes.May 13 2025, 5:04 PM
gerritbot added a comment.May 13 2025, 7:45 PM

Change #1145268 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] Mark ApiShortenUrl as an API that performs writes

https://gerrit.wikimedia.org/r/1145268

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 13 2025, 8:00 PM
Dreamy_Jazz closed this task as Resolved.May 13 2025, 8:25 PM
Dreamy_Jazz claimed this task.

Thanks for the quick review.

Maintenance_bot removed a project: Patch-For-Review.May 13 2025, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits