Page MenuHomePhabricator

Edit check: floating sidebar alignment issues
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open VisualEditor
  • Trigger a mid-edit check in content that is at the bottom of the article

What happens?:

The top of the check in the sidebar aligns with the selection at the bottom of the article... and extends off the visible area of the sidebar, causing a scrollbar to appear.

What should have happened instead?:

No scrollbar should appear. The checks should either be constrained to not extend below the bottom of the sidebar (without also colliding with checks above them), or the height of the sidebar should be extended to fit the checks.

Event Timeline

Change #1146658 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Use position:static in sidebar dialog to prevent scrollbars

https://gerrit.wikimedia.org/r/1146658

Change #1146658 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use position:static in sidebar dialog to prevent scrollbars

https://gerrit.wikimedia.org/r/1146658

I checked on two patchdemo versions: f433ef3e39 and 1b1089a907. I am still seeing that the top of the check in the sidebar does not really align with the selection at the bottom of the article and there is a scrollbar, and the last check extends off the visible area of the sidebar.

Screenshot 2025-05-22 at 10.32.57 PM.png (1×2 px, 211 KB)

Screenshot 2025-05-22 at 10.59.01 PM.png (1×2 px, 222 KB)

@Ryasmeen Sorry, this one needs a pullthrough of the submodule before it can be QA'd. I figured that would happen before you got to it. :D

Change #1149534 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ff61cf120)

https://gerrit.wikimedia.org/r/1149534

Change #1149637 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ff61cf120)

https://gerrit.wikimedia.org/r/1149637

Change #1149534 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ff61cf120)

https://gerrit.wikimedia.org/r/1149534