Page MenuHomePhabricator

[EPIC] Diff styling
Open, MediumPublic

Description

Problem

Diff styling across platforms and ways of viewing them present a wide range of color and graphical means of doing so. This causes an inconsistent user experience, lacks visual unification and proper use of Codex color tokens, while sacrificing on accessibility fronts.

Goals

  • Unify colors across all forms of viewing diffs
  • Unify graphical means of conveying removed, added, moved, and changed content
  • Improve overall visual styles and experiences of viewing diffs
diff viewbeforeafter
Wikitext
Screenshot 2025-05-04 at 11.25.07.png (1×1 px, 390 KB)
Screenshot 2025-05-04 at 11.31.33.png (1×1 px, 388 KB)
Inline
Screenshot 2025-05-04 at 11.25.16.png (1×1 px, 412 KB)
Screenshot 2025-05-04 at 11.32.59.png (1×1 px, 405 KB)
Visual
Screenshot 2025-05-04 at 11.23.45.png (1×1 px, 452 KB)
Screenshot 2025-05-04 at 11.23.06.png (1×1 px, 444 KB)

The above table is only portraying Vector on desktop, but the idea is to unify all platforms to have the same color and graphics scheme.

Principles

  • Optimize for various types of accessibility needs
  • Understand the history of diff style changes
  • Document decision-making

Considerations

With a change to colors in diffs, as this has historically been a highly debated and discussed topic, we should consider doing one of three things:

  1. Provide custom CSS code to use the existing colors - This would only work for light mode, or the system setting. This is the least effort option as it does not introduce new preferences or additional tokens to be maintained. This is the most customizable option (for light mode) but requires some technical knowledge.
  2. Introduce a toggle for "old diff styling" to opt out of the update in colors - This would not allow a lot of room for growth as it would be a single toggle, and not consider potential future options around a variety of diff colors. This would only change the colors, not the graphical improvements being made.
  3. Introduce a choice in color scheme - This could be as small as the color scheme of diffs, and start with either yellow/blue or red/green for all ways of viewing diffs. Or as large as various color themes for the entirety of MediaWiki which focus on various color vision deficiencies. The latter would require a bit more design thinking and would be the most technical work.

Another consideration should be releasing this work to small amounts of users at a time, or potentially to smaller wikis with different cultural contexts.

In the future, we could consider redesigning the Wikitext left/right view with a simplified layout and background colors changes T394352

Screenshot 2025-05-04 at 12.24.34.png (1×2 px, 553 KB)

Acceptance criteria

(individual tasks will cover each item listed here)

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Adding Apps design folks for visibility and coordinating changes on iOS and Android as needed.

Thanks for creating this task! This was long due. Please feel free to contact Julieta and me for more context and history of diff. From engineering side, Harumi Monroy was the last person to work on this.