[MEX] M1 - First iteration stub Build an initial UI element:
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	May 14 2025, 11:20 AM

Description

Under the Statements section on an item page display text box that says “This item has n statements.”

Only enabled to mobile mode (as interpreteed in team's document), and Items
For feature-enabled wikis only (via a config flag $wgWBRepoSettings['tmpMobileEditingUI'] on patch demo env)
Non-JS experience: Provide the same text box for non-JS enabled clients

Acceptance Criteria:

When visiting https://patchdemo.wmcloud.org/wikis/[WIKI_ID]/wiki/Item:Q1?mobileaction=toggle_view_mobile, "This items has X statements" is displayed under Statements on both JS and non-JS enabled client
When JS is enabled in the browser, the text should included additional "JS" indicator at the end

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add new mobile statement UI config flag	mediawiki/extensions/Wikibase	master	+152 -15

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T394621 [MEX] Mobile Editing Experience of Items Project
Resolved	karapayneWMDE	T394292 [MEX] M1 - Technical Investigation
Resolved	Arian_Bozorg	T394291 [MEX] M1 - First iteration stub Build an initial UI element:

Event Timeline

WMDE-leszek created this task.May 14 2025, 11:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2025, 11:20 AM

Lucas_Werkmeister_WMDE subscribed.May 14 2025, 11:20 AM

WMDE-leszek added a parent task: T394292: [MEX] M1 - Technical Investigation.May 14 2025, 11:22 AM

WMDE-leszek updated the task description. (Show Details)May 14 2025, 11:25 AM

WMDE-leszek moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.

Maintenance_bot added a project: Wikidata.May 14 2025, 11:29 AM

WMDE-leszek updated the task description. (Show Details)May 14 2025, 11:36 AM

Lucas_Werkmeister_WMDE claimed this task.May 14 2025, 1:57 PM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

Change #1146011 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] POC: Add new mobile statement UI config flag

https://gerrit.wikimedia.org/r/1146011

gerritbot added a project: Patch-For-Review.May 14 2025, 3:46 PM

karapayneWMDE renamed this task from MEX First iteration stub Build an initial UI element: to [MEX] M1 - First iteration stub Build an initial UI element:.May 19 2025, 4:50 AM

Arian_Bozorg reassigned this task from Lucas_Werkmeister_WMDE to AudreyPenven_WMDE.May 19 2025, 8:20 AM

Not quite sure where to leave this, so I'll put it here. Currently EntityView expects that it can produce html only depending on the language (code) that can canonically be used (and cached!). If we want to allow this feature, at least temporarily, to depend on the user (settings), we will need to break this assumption. One way to adopt the above change to T394704: [MEX] M1 - Create a beta feature (untested):

Make the wbMobile parser option tri-state (true, false and something else for the new mobile UI) and set it according to the beta feature (in RepoHooks::onParserOptionsRegister). Get the value of that option (or retrieve the setting in some other way) in FullEntityParserOutputGenerator::addHtmlToParserOutput and pass it to ItemView::getContent.

While this is a little unclean, I think it might be ok for a temporary feature. Alternatively the setting value could be passed to the EntityView / ItemView constructor. But as these instances are created without access to the user (except for global state) more thorough changes would be needed to properly inject it there.

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.May 23 2025, 6:41 PM

AudreyPenven_WMDE moved this task from In Development to Ready for Development on the Wikidata-Omega (The Board) board.

AudreyPenven_WMDE moved this task from Ready for Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

AudreyPenven_WMDE subscribed.

handover notes:

as far as I can tell, the acceptance criteria are fulfilled. There is both a server-side-rendered HTML placeholder and a JS-added placeholder based on the temporary flag.
the previously-failing tests pass
ItemViewTest is extended to confirm that the placeholder is there when the flag is enabled, and not there when it isn't
FullEntityParserOutputGeneratorTest confirms the expected modules load under all combinations of $isMobileView and $tmpMobileEditingUI
I wasn't sure whether handling the beta feature flag was in scope for this ticket, and left it out

hoo mentioned this in T394704: [MEX] M1 - Create a beta feature.May 28 2025, 3:51 PM

In T394291#10836697, @hoo wrote:

One way to adopt the above change to T394704: [MEX] M1 - Create a beta feature (untested):

Make the wbMobile parser option tri-state (true, false and something else for the new mobile UI) and set it according to the beta feature (in RepoHooks::onParserOptionsRegister). Get the value of that option (or retrieve the setting in some other way) in FullEntityParserOutputGenerator::addHtmlToParserOutput and pass it to ItemView::getContent.

While this is a little unclean, I think it might be ok for a temporary feature. Alternatively the setting value could be passed to the EntityView / ItemView constructor. But as these instances are created without access to the user (except for global state) more thorough changes would be needed to properly inject it there.

That sounds promising to me. I was thinking of reusing the wbMobile parser option for “old vs. new mobile UI” anyway, because that way we hopefully don’t invalidate any existing parser output with wbMobile=0 / wbMobile=1 (whereas adding a separate flag might result in that not being used? idk).

ArthurTaylor claimed this task.Jun 2 2025, 11:45 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

Test wiki created on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/1f52abea58/w/

Deployed a patchdemo environment with this patch plus the flag enabled and it seems to work: https://patchdemo.wmcloud.org/wikis/1f52abea58/w/index.php?title=Item:Q1&mobileaction=toggle_view_mobile

Change #1146011 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add new mobile statement UI config flag

https://gerrit.wikimedia.org/r/1146011

ArthurTaylor removed ArthurTaylor as the assignee of this task.Jun 2 2025, 12:16 PM

ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.

ArthurTaylor subscribed.

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2025, 12:31 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03).Jun 2 2025, 1:00 PM

Thank you! I am assuming the text has changed from the initial acceptance criteria to "TODO: Add Vue Statements View (text added by wikibase.mobileUi.entityViewInit.js)"

Yeah, it used to display that text for a bit and then we moved beyond it :)

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Jun 6 2025, 3:12 PM

karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.Jun 18 2025, 6:31 AM

karapayneWMDE mentioned this in T399703: [MEX] Release under feature flag on beta wikidata.Jul 16 2025, 10:34 AM

Test wiki on Patch demo by Arthur Taylor (WMDE) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmcloud.org//wikis/1f52abea58/w/~~