Page MenuHomePhabricator
Create Task
Maniphest T394299

MediaModeration: Disable extension on beta wikis
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Summary

The MediaModeration extension scans files using the PhotoDNA service that needs an API key. We don't have the API key available on beta wikis, so need to disable it to avoid issues.

Background

  • MediaModeration runs scans over images using a maintenance script
  • To scan images we need to make a request to PhotoDNA
    • This needs an API key to make these requests, but it is not set for the beta wikis
  • We should disable the scanning script on beta wiki to avoid requests that contain an invalid API key

Acceptance criteria

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MediaModeration: Only running scanning scripts on productionoperations/puppetproduction+19 -15
Throw if $wgMediaModerationPhotoDNASubscriptionKey not setmediawiki/extensions/MediaModerationmaster+31 -5
Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.phpoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Dreamy_Jazz created this task.May 14 2025, 12:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2025, 12:04 PM
Dreamy_Jazz updated the task description. (Show Details)May 14 2025, 12:05 PM
Dreamy_Jazz claimed this task.May 14 2025, 12:22 PM
Dreamy_Jazz set the point value for this task to 2.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
gerritbot added a comment.May 14 2025, 1:32 PM

Change #1145946 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MediaModeration@master] Throw if $wgMediaModerationPhotoDNASubscriptionKey not set

https://gerrit.wikimedia.org/r/1145946

gerritbot added a project: Patch-For-Review.May 14 2025, 1:32 PM
gerritbot added a comment.May 14 2025, 1:39 PM

Change #1145947 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.php

https://gerrit.wikimedia.org/r/1145947

gerritbot added a comment.May 14 2025, 1:51 PM

Change #1145949 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/puppet@production] MediaModeration: Only running scanning scripts on production

https://gerrit.wikimedia.org/r/1145949

gerritbot added a comment.May 14 2025, 2:43 PM

Change #1145947 merged by jenkins-bot:

[operations/mediawiki-config@master] Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.php

https://gerrit.wikimedia.org/r/1145947

Stashbot added a comment.May 14 2025, 2:43 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T14:43:49Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1145947|Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.php (T394299)]]

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 14 2025, 2:45 PM
Stashbot added a comment.May 14 2025, 2:48 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T14:48:23Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:1145947|Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.php (T394299)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

gerritbot added a comment.May 14 2025, 2:49 PM

Change #1145946 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Throw if $wgMediaModerationPhotoDNASubscriptionKey not set

https://gerrit.wikimedia.org/r/1145946

Stashbot added a comment.May 14 2025, 2:55 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-14T14:55:09Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145947|Set $wgMediaModerationPhotoDNASubscriptionKey as empty in readme.php (T394299)]] (duration: 11m 20s)

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 3:00 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.May 14 2025, 8:41 PM
gerritbot added a comment.May 15 2025, 4:03 PM

Change #1145949 merged by RLazarus:

[operations/puppet@production] MediaModeration: Only running scanning scripts on production

https://gerrit.wikimedia.org/r/1145949

Maintenance_bot removed a project: Patch-For-Review.May 15 2025, 4:30 PM
Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.EditedMay 15 2025, 4:42 PM

For QA I would suggest checking that no more logs appear in https://beta-logs.wmcloud.org/goto/7dacc8512956b14f79255206bf05187e after end of May 15th.

You can also verify that setting $wgMediaModerationPhotoDNASubscriptionKey as an empty string on a local instance causes a LogicException to be thrown when you try to scan.

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 17 2025, 6:04 AM
Djackson-ctr subscribed.

QA is completed, I have verified the new code has been implemented and is functioning as expected (When viewing the https://beta-logs.wmcloud.org/goto/7dacc8512956b14f79255206bf05187e, I am seeing LogicExceptions thrown for $wgMediaModerationPhotoDNASubscriptionKey API Key is not set).

Dreamy_Jazz closed this task as Resolved.May 21 2025, 12:51 PM
Dreamy_Jazz mentioned this in T401643: "LogicException: $wgMediaModerationPhotoDNASubscriptionKey API key is not set" in beta.Aug 12 2025, 9:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits