PageTriage gate and submit intermittently fails, PageTriageTest->testBulkSetTagsUpdated(), "Failed asserting that '20250513203936' is null."
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Novem_Linguae
	May 15 2025, 7:27 AM

Project Tags

Referenced Files

	F60004208: image.png
	May 15 2025, 7:27 AM

	F60004197: image.png
	May 15 2025, 7:27 AM

	F60004187: image.png
	May 15 2025, 7:27 AM

	F60004179: image.png
	May 15 2025, 7:27 AM

	F60004164: image.png
	May 15 2025, 7:27 AM

Subscribers

Aklapper

Novem_Linguae

Description

Steps to replicate the issue (include links if applicable):

+2 a patch in the PageTriage repo, or "recheck" it a bunch of times

What happens?:

See Verified-1 comments in these patches:

What should have happened instead?:

gate and submit succeeds. patch merges

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Doesn't appear to affect the wmf (gate) build at all. This solely affects PageTriage
Is intermittent.
Despite being intermittent, enough of the 4 gate and submit builds fail each time to block all patch merging.
Since it's the same test failing each time, I think I'll write a patch to skip that test, then rebase and resubmit the existing patches, and see if that resolves this.

Acceptance criteria

test no longer marked as skipped
test no longer flaky

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: mark testBulkSetTagsUpdated as skipped	mediawiki/extensions/PageTriage	REL1_44	+3 -0
	tests: mark testBulkSetTagsUpdated as skipped	mediawiki/extensions/PageTriage	master	+3 -0

Customize query in gerrit

Event Timeline

Novem_Linguae created this task.May 15 2025, 7:27 AM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 15 2025, 7:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Novem_Linguae updated the task description. (Show Details)May 15 2025, 7:28 AM

Change #1146488 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] tests: mark testBulkSetTagsUpdated as skipped

https://gerrit.wikimedia.org/r/1146488

gerritbot added a project: Patch-For-Review.May 15 2025, 7:30 AM

		$pageIds[] = $this->insertPage( 'PageTriageTest', 'Testing 123' )['id'];

		$pageTriagePage = $this->getDb()->newSelectQueryBuilder()
			->select( 'ptrp_tags_updated' )
			->from( 'pagetriage_page' )
			->where( [ 'ptrp_page_id' => $pageIds ] )
			->caller( __METHOD__ )
			->fetchField();

		$this->assertNull( $pageTriagePage );

I think PageTriage SQL tables / metadata sometimes gets updated in a DeferredUpdate. If the DeferredUpdate is sometimes slower than the test code, that could create an intermittent failure.

Not sure why this is rearing itself now though when it was fine for the last 2 years.

Novem_Linguae updated the task description. (Show Details)May 15 2025, 7:41 AM

Change #1146488 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] tests: mark testBulkSetTagsUpdated as skipped

https://gerrit.wikimedia.org/r/1146488

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 15 2025, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 15 2025, 3:30 PM

Will leave this open in case anyone wants to fix the test.

Novem_Linguae updated the task description. (Show Details)May 15 2025, 7:30 PM

• Kgraessle moved this task from Inbox to To be estimated on the Moderator-Tools-Team board.May 22 2025, 5:20 PM

Scardenasmolinar moved this task from To be estimated to Triaged on the Moderator-Tools-Team board.Jun 10 2025, 3:20 PM

Change #1220007 had a related patch set uploaded (by Umherirrender; author: Novem Linguae):

[mediawiki/extensions/PageTriage@REL1_44] tests: mark testBulkSetTagsUpdated as skipped

https://gerrit.wikimedia.org/r/1220007

gerritbot added a project: Patch-For-Review.Dec 21 2025, 2:24 PM

Change #1220007 merged by jenkins-bot: