Page MenuHomePhabricator
Create Task
Maniphest T394387

Special:IPInfo: The "Show IP" button is broken when viewing a temporary account
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Open Special:IPInfo for temporary account that has recently made an action
  2. Click "Show IP" on the IP

What happens?:
Notice that the IP is not displayed and instead "error" is displayed:

image.png (1,848×854 px, 78 KB)

Also in the browser console, an invalid request is made:

image.png (1,518×142 px, 22 KB)

image.png (896×372 px, 38 KB)

What should have happened instead?:
The IP should have been shown when the user pressed "Show IP"

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix IP reveal on Special:IPInfomediawiki/extensions/IPInfomaster+1 -1
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.May 15 2025, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2025, 10:01 AM
Dreamy_Jazz updated the task description. (Show Details)May 15 2025, 10:01 AM
Dreamy_Jazz claimed this task.May 15 2025, 10:15 AM
Dreamy_Jazz set the point value for this task to 1.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
gerritbot added a comment.May 15 2025, 10:18 AM

Change #1146541 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@master] Fix IP reveal on Special:IPInfo

https://gerrit.wikimedia.org/r/1146541

gerritbot added a project: Patch-For-Review.May 15 2025, 10:18 AM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 15 2025, 10:18 AM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.
gerritbot added a comment.May 15 2025, 10:52 AM

Change #1146541 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Fix IP reveal on Special:IPInfo

https://gerrit.wikimedia.org/r/1146541

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 15 2025, 10:57 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 15 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 15 2025, 11:30 AM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 17 2025, 6:05 AM
Djackson-ctr subscribed.

QA is completed, I have verified the new code has been implemented and is functioning as expected (The IP address is shown when the user selects the "Show IP" button).

Tchanders closed this task as Resolved.May 20 2025, 2:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits