Page MenuHomePhabricator
Create Task
Maniphest T394404

PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher]
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(297)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.1/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(390)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(297)MediaWiki\Xml\Xml::radio(string, string, bool, array)
#7/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(62)SpecialCentralNoticeLogs->getLogSwitcher(string, string, string, string)
#8/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPage.php(734)SpecialCentralNoticeLogs->execute(null)
#9/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1738)MediaWiki\SpecialPage\SpecialPage->run(null)
#10/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#11/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#12/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#13/srv/mediawiki/php-1.45.0-wmf.1/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#14/srv/mediawiki/w/index.php(3)require(string)
#15{main}
Notes

Yet another deprecation surfaced by the wfDeprecated added ahead of 1.45.0-wmf.1.

We should just stop deprecating things, it's a bother.

Offender seems to be two lines shifted from the line mentioned in the stacktrace: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+blame/refs/heads/wmf/1.45.0-wmf.1/includes/specials/SpecialCentralNoticeLogs.php#299

(@Jdforrester-WMF pinging you again, apologies)

Details

Request URL
https://meta.wikimedia.org/w/index.php?campaign=*&centralnoticesubmit=*&endDate_timestamp=*&log_type=*&startDate=*&startDate_timestamp=*&title=*&user=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Merge remote-tracking branch 'origin/master' into wmf_deploymediawiki/extensions/CentralNoticewmf/1.45.0-wmf.1+46 -9
Merge remote-tracking branch 'origin/master' into wmf_deploymediawiki/extensions/CentralNoticewmf_deploy+0 -0
Customize query in gerrit

Related Objects

Event Timeline

• jnuche created this task.May 15 2025, 12:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2025, 12:17 PM
Jdforrester-WMF added a comment.EditedMay 15 2025, 12:41 PM

This was waiting on FR-Tech (or us) to merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1143609 which they/we did not do ahead of the branch, as CI flaked. :-(

gerritbot added a comment.May 15 2025, 12:42 PM

Change #1143609 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

gerritbot added a project: Patch-For-Review.May 15 2025, 12:42 PM
Jdforrester-WMF added a comment.EditedMay 15 2025, 12:55 PM

Hmm:

00:00:34.113 INFO:zuul.Cloner:Updating origin remote in repo mediawiki/core to https://gerrit.wikimedia.org/r/mediawiki/core
00:00:37.785 INFO:zuul.Cloner:upstream repo is missing branch wmf_deploy
00:00:38.451 INFO:zuul.Cloner:Prepared mediawiki/core repo with commit 8ffa251e75e4cb879f2e3d7231f342b36da709a0

That's not a git hash known to gerrit or my local check-out.

Edit: Never mind, it was a future patch in the mediawiki stack.

gerritbot added a comment.May 15 2025, 1:55 PM

Change #1143609 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

gerritbot added a comment.May 15 2025, 1:57 PM

Change #1146631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

Jdforrester-WMF added a comment.May 15 2025, 1:58 PM
In T394404#10826374, @gerritbot wrote:

Change #1146631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

@jnuche: This should kill off the logspam and otherwise do nothing except an i18n update (sorry :-().

• jnuche added a comment.May 15 2025, 2:07 PM

@jnuche: This should kill off the logspam and otherwise do nothing except an i18n update (sorry :-().

No worries, thanks for jumping on it so promptly!

• Krinkle triaged this task as High priority.May 20 2025, 4:40 PM
• Krinkle moved this task from Untriaged to Apr-Jun 2025 on the Wikimedia-production-error board.
gerritbot added a comment.May 20 2025, 8:54 PM

Change #1146631 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

Stashbot mentioned this in T394270: LogicException: Title not found!.May 20 2025, 8:55 PM
Stashbot mentioned this in T393122: Make PHPUnit dataProvider on BundleSizeTestBase static.
Stashbot mentioned this in T394025: PHP Deprecated: Use of MediaWiki\Xml\Xml::input was deprecated in MediaWiki 1.42. [Called from MediaWiki\Xml\Xml::inputLabelSep].
Stashbot mentioned this in T341775: Discourage, deprecate and stop using Xml methods for building HTML markup.
Stashbot mentioned this in T373017: CI PerformanceBudgetTest fails on GrowthExperiments master branch with 0.5kB difference.

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:55:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]]

Stashbot added a comment.May 20 2025, 8:57 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:57:41Z] <jforrester@deploy1003> mszabo, jforrester: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes c

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.1; 2025-05-13).May 20 2025, 9:00 PM
Jdforrester-WMF closed this task as Resolved.May 20 2025, 9:05 PM
Jdforrester-WMF claimed this task.

Should now be fixed.

Stashbot added a comment.May 20 2025, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-20T21:06:31Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] (duration: 11m 28s)

Maintenance_bot removed a project: Patch-For-Review.May 20 2025, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits