Page MenuHomePhabricator

PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   PHP Deprecated: Use of MediaWiki\Xml\Xml::radio was deprecated in MediaWiki 1.42. [Called from SpecialCentralNoticeLogs::getLogSwitcher]
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(297)
#0[internal function]MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, string)
#1/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(386)trigger_error(string, int)
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(357)MediaWiki\Debug\MWDebug::sendRawDeprecated(string, bool, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/debug/MWDebug.php(238)MediaWiki\Debug\MWDebug::deprecatedMsg(string, string, string, int)
#4/srv/mediawiki/php-1.45.0-wmf.1/includes/GlobalFunctions.php(782)MediaWiki\Debug\MWDebug::deprecated(string, string, string, int)
#5/srv/mediawiki/php-1.45.0-wmf.1/includes/xml/Xml.php(390)wfDeprecated(string, string)
#6/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(297)MediaWiki\Xml\Xml::radio(string, string, bool, array)
#7/srv/mediawiki/php-1.45.0-wmf.1/extensions/CentralNotice/includes/specials/SpecialCentralNoticeLogs.php(62)SpecialCentralNoticeLogs->getLogSwitcher(string, string, string, string)
#8/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPage.php(734)SpecialCentralNoticeLogs->execute(null)
#9/srv/mediawiki/php-1.45.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1738)MediaWiki\SpecialPage\SpecialPage->run(null)
#10/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(499)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#11/srv/mediawiki/php-1.45.0-wmf.1/includes/actions/ActionEntryPoint.php(143)MediaWiki\Actions\ActionEntryPoint->performRequest()
#12/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Actions\ActionEntryPoint->execute()
#13/srv/mediawiki/php-1.45.0-wmf.1/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#14/srv/mediawiki/w/index.php(3)require(string)
#15{main}
Notes

Yet another deprecation surfaced by the wfDeprecated added ahead of 1.45.0-wmf.1.

We should just stop deprecating things, it's a bother.

Offender seems to be two lines shifted from the line mentioned in the stacktrace: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+blame/refs/heads/wmf/1.45.0-wmf.1/includes/specials/SpecialCentralNoticeLogs.php#299

(@Jdforrester-WMF pinging you again, apologies)

Details

Request URL
https://meta.wikimedia.org/w/index.php?campaign=*&centralnoticesubmit=*&endDate_timestamp=*&log_type=*&startDate=*&startDate_timestamp=*&title=*&user=*
Related Changes in Gerrit:

Event Timeline

This was waiting on FR-Tech (or us) to merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/1143609 which they/we did not do ahead of the branch, as CI flaked. :-(

Change #1143609 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

Hmm:

00:00:34.113 INFO:zuul.Cloner:Updating origin remote in repo mediawiki/core to https://gerrit.wikimedia.org/r/mediawiki/core
00:00:37.785 INFO:zuul.Cloner:upstream repo is missing branch wmf_deploy
00:00:38.451 INFO:zuul.Cloner:Prepared mediawiki/core repo with commit 8ffa251e75e4cb879f2e3d7231f342b36da709a0

That's not a git hash known to gerrit or my local check-out.

Edit: Never mind, it was a future patch in the mediawiki stack.

Change #1143609 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1143609

Change #1146631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

Change #1146631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

@jnuche: This should kill off the logspam and otherwise do nothing except an i18n update (sorry :-().

@jnuche: This should kill off the logspam and otherwise do nothing except an i18n update (sorry :-().

No worries, thanks for jumping on it so promptly!

Change #1146631 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf/1.45.0-wmf.1] Merge remote-tracking branch 'origin/master' into wmf_deploy

https://gerrit.wikimedia.org/r/1146631

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:55:02Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]]

Mentioned in SAL (#wikimedia-operations) [2025-05-20T20:57:41Z] <jforrester@deploy1003> mszabo, jforrester: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes c

Jdforrester-WMF claimed this task.

Should now be fixed.

Mentioned in SAL (#wikimedia-operations) [2025-05-20T21:06:31Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1145867|TransformHandler: Return 400 for invalid titles (T394270)]], [[gerrit:1146631|Merge remote-tracking branch 'origin/master' into wmf_deploy (T341775 T373017 T393122 T394404)]], [[gerrit:1146654|Xml::input, label: Replace usage with Html::input, label (T394025)]] (duration: 11m 28s)