[builds-api] Main branch is used even when a different "ref" is specified
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	fnegri
	May 16 2025, 2:28 PM

Description

Steps to replicate the issue (include links if applicable):

toolforge build start --ref=buildservice https://github.com/dhinus/wikidata-painters

What happens?:

[step-clone] 2025-05-16T14:26:45.984027419Z + /ko-app/git-init '-url=https://github.com/dhinus/wikidata-painters' '-revision=bec591393bd9656e37184e3afd2086f01148650e' '-refspec=' '-path=/workspace/' '-sslVerify=true' '-submodules=true' '-depth=1' '-sparseCheckoutDirectories='

What should have happened instead?:

The tip of the branch buildservice should be used.

Other information

Looking at the resolveRef function, it seems that the value of ref is never used: https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/blob/main/internal/build.go#L784

Details

Related Changes in GitLab:

Title	Reference	Author	Source Branch	Dest Branch
builds-api: bump to 0.0.192-20250516182559-51f1f993	repos/cloud/toolforge/toolforge-deploy!788	group_203_bot_f4d95069bb2675e4ce1fff090c1c1620	bump_builds-api	main
DONOTMERGE Use the given ref as the 4th argument for pattern matching in git ls-remote	repos/cloud/toolforge/builds-api!133	dcaro	dcaro-patch-1	main
Use the given ref as a pattern in git ls-remote	repos/cloud/toolforge/builds-api!132	nokibsarkar	patch-1	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In Progress		Nokib_Sarkar	T394515 Migration of CampWiz NXT to toolforge
		Resolved	BUG REPORT	Nokib_Sarkar	T394516 [builds-api] Main branch is used even when a different "ref" is specified

Event Timeline

fnegri created this task.May 16 2025, 2:28 PM

Restricted Application added a project: cloud-services-team. · View Herald TranscriptMay 16 2025, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Nokib_Sarkar added a parent task: T394515: Migration of CampWiz NXT to toolforge.May 16 2025, 2:31 PM

Nokib_Sarkar mentioned this in T394515: Migration of CampWiz NXT to toolforge.

Nokib_Sarkar mentioned this in T394520: Request increased quota for campwiz Toolforge tool.May 16 2025, 2:55 PM

Nokib_Sarkar claimed this task.May 16 2025, 3:52 PM

nokibsarkar updated https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/132

[builds-api] Main branch is used even when a different "ref" is specified.

Nokib_Sarkar changed the task status from Open to In Progress.May 16 2025, 4:32 PM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/133

Use the given ref as the 4th argument for pattern matching in git ls-remote

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/132

Use the given ref as a pattern in git ls-remote

dcaro closed https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/133

DONOTMERGE Use the given ref as the 4th argument for pattern matching in git ls-remote

Nokib_Sarkar closed this task as Resolved.May 16 2025, 6:30 PM

group_203_bot_f4d95069bb2675e4ce1fff090c1c1620 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/788

builds-api: bump to 0.0.192-20250516182559-51f1f993

dcaro edited projects, added Toolforge (Toolforge iteration 20); removed Toolforge.May 16 2025, 6:51 PM

dcaro moved this task from Next Up to Done on the Toolforge (Toolforge iteration 20) board.

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/788