Steps to replicate the issue (include links if applicable):
- Visit beta cluster and enable reading list feature
- Switch to mobile site
- Click the bookmark button
What happens?:
A JS error
What should have happened instead?:
No JS error.
Minerva doesn't output the data attributes provided in the ReadingList hook.
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
Requirement
Minerva skin must support outputting custom data-* attributes provided via the ReadingList hook to ensure the reading list feature functions without JavaScript errors.
BDD
Feature: Minerva outputs custom data attributes from ReadingList hook Scenario: Bookmark icon renders with expected data attributes on Minerva Given the ReadingList beta feature is enabled And I am using the Minerva skin on the mobile site When I navigate to any article Then the bookmark icon should include custom `data-*` attributes from the ReadingList hook And no JavaScript error should be thrown in the console
Test Steps
Test Case 1: Custom data attributes appear on bookmark icon
- Create or use an existing account
- Enable the Reading List beta feature in preferences
- Switch to the Minerva (mobile) skin
- Navigate to any article, e.g., https://en.wikipedia.beta.wmflabs.org/wiki/Paris
- Open browser dev tools and inspect the bookmark icon element
- AC1: Confirm that it contains the expected data-* attributes provided by the ReadingList hook (data-mw-list-id, and data-mw-entry-id if saved)
- AC2: Confirm that no JavaScript error related to reading lists appears in the console
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T394560#10873432 |
| 2 | ✅ | T394560#10873432 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T394560#10905520 |
| 2 | ✅ | T394560#10905520 |
