Page MenuHomePhabricator

Hide the watchstar and watchlist when the reading list beta feature is enabled
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
Jdlrobson-WMF
May 17 2025, 12:31 AM
Referenced Files
F62293995: screenshot 24.png
Jun 11 2025, 4:04 PM
F62293993: screenshot 22.png
Jun 11 2025, 4:04 PM
F62293991: screenshot 23.png
Jun 11 2025, 4:04 PM
F62293962: screenshot 21.png
Jun 11 2025, 4:04 PM
F62293956: screenshot 20.png
Jun 11 2025, 4:04 PM
F62293940: screenshot 19.png
Jun 11 2025, 4:04 PM
F62293939: screenshot 18.png
Jun 11 2025, 4:04 PM
F62293927: screenshot 17.png
Jun 11 2025, 4:04 PM

Description

Background

With the completion of T393608: [ReadingLists] Move bookmark action button to toolbar we have a situation where both the watchstar and the bookmark appear in the page actions menu. This is a confusing experience for readers unfamiliar with the concepts of reading lists and watchlists.

Going forward we should consolidate on the bookmark being the main article entry point.
We know that many editors do not use the watchstar (instead relying on the auto population of their watchlist via edits to articles). We know mobile editors mistake the watchstar for "favoriting" an article.

Note: In future we may want to consider a user preference that shows both but for now let's hide the watchstar when the beta feature is enabled. See also T394561: [Feature idea] Support moving reading list articles to watchlist

Screenshot 2025-05-16 at 5.22.44 PM.png (1×758 px, 578 KB)

Screenshot 2025-05-16 at 5.23.16 PM.png (804×2 px, 654 KB)

User story

As a reader I don't want to be confused by the presence of a bookmark and watchstar icon on articles.

Requirements

  • When the beta feature is enabled, the watchstar should be unset from the menu on Minerva skin
  • When the beta feature is disabled the watchstar should be in the menu on Minerva skin
  • When the beta feature is enabled, the watchstar should be unset from the menu on Vector 2022 skin
  • When the beta feature is disabled the watchstar should be in the menu on Vector 2022 skin
  • When the beta feature is enabled, and the user has made no edits to the site and has an empty watchlist there should be no watchlist item in the main menu on the Minerva skin
  • When the beta feature is enabled it has no impact on the watchlist's presence in menus on other skins.

BDD

Feature: Reading list beta hides watchstar and watchlist

Scenario: Watchstar visibility on Minerva skin
  Given I am using the Minerva skin
  When I enable the reading list beta feature
  Then the watchstar should not appear in the page actions menu

Scenario: Watchstar visibility on Vector 2022 skin
  Given I am using the Vector 2022 skin
  When I enable the reading list beta feature
  Then the watchstar should not appear in the page actions menu

Scenario: Watchstar appears when beta is disabled
  Given I disable the reading list beta feature
  Then the watchstar should appear in the page actions menu

Scenario: Watchlist not shown in Minerva menu for new user
  Given I am using Minerva skin
  And I have no edits and an empty watchlist
  When I enable the reading list beta feature
  Then the Watchlist item should not appear in the main menu

Scenario: Other skins are unaffected
  Given I am using a skin other than Minerva or Vector 2022
  When I enable or disable the reading list beta feature
  Then the watchstar and watchlist menu items remain unchanged

Test Steps

Test Case 1: Watchstar hidden when beta is enabled (Minerva and Vector 2022)

  1. Create a new account or log in to one without edits
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Navigate to any article
  5. AC1: Watchstar is not visible in the page actions menu
  6. Switch to Vector 2022 skin
  7. Navigate to any article
  8. AC2: Watchstar is not visible in the page actions menu

Test Case 2: Watchstar appears when beta is disabled

  1. Disable the reading list beta feature
  2. Switch to Minerva skin
  3. Navigate to any article
  4. AC3: Watchstar is visible in the page actions menu
  5. Switch to Vector 2022 skin
  6. Navigate to any article
  7. AC4: Watchstar is visible in the page actions menu

Test Case 3: Watchlist menu item hidden for new user

  1. Create a brand-new account (no edits)
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Open the main menu (hamburger menu)
  5. AC5: Watchlist item is not shown in the menu

Test Case 4: Other skins are unaffected

  1. Enable the reading list beta feature
  2. Switch to a skin other than Minerva or Vector 2022 (e.g., Legacy Vector)
  3. Navigate to any article
  4. AC6: Watchstar and watchlist menu items are still present

QA Results - Beta

QA Results - Prod

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson-WMF renamed this task from Hide the watchstar when the reading list beta feature is enabled to Hide the watchstar and watchlist when the reading list beta feature is enabled.May 17 2025, 12:57 AM
Jdlrobson-WMF updated the task description. (Show Details)
Jdlrobson-WMF set the point value for this task to 2.May 19 2025, 5:39 PM

Allowing both watchlist & reading list icons would finally move us closer to T3492: Enable editors to monitor edits to sets of watched pages. I understand your concerns that both icons might be confusing to inexperienced users, but at least allowing the user preference to show both would be great for all people who currently use their watchlist as both watchlist & reading list.

Allowing both watchlist & reading list icons would finally move us closer to T3492: Enable editors to monitor edits to sets of watched pages. I understand your concerns that both icons might be confusing to inexperienced users, but at least allowing the user preference to show both would be great for all people who currently use their watchlist as both watchlist & reading list.

There is a distinction between the "watchlist icon" that lets you view the list, and the "star icon" that adds a new article to the list.

All this task does is replace the star icon with the bookmark icon. Users can still navigate to their watchlist as-is, given there are one or more articles already added to it.

Sorry I meant the watchlist star. I don’t believe in your assumption that users don’t use it - there wouldn’t be the reoccurring wish to allow multiple watchlists if users just relied on auto population. Multi-watchlists only make sense if you populate them manually using the star. I could easily find plenty of experienced users (including myself) who use the star a lot.

The watchlist expiry feature wouldn’t exist as well if people didn’t use the watchlist star…

I understand your concerns that both icons might be confusing to inexperienced users, but at least allowing the user preference to show both would be great for all people who currently use their watchlist as both watchlist & reading list.

@Johannnes89 the watchlist is currently being treated as a special type of ReadingList and we're currently in a research phase of exploring workflows with the new reading list icon. We are currently exploring a workflow where the button defaults to a "Saved" list but in future it may provide the ability to select a list like so:

Screenshot 2025-05-21 at 2.05.30 PM.png (1×1 px, 513 KB)

For now we are keeping things simple, but we will evaluate options such as showing both watchstar and bookmark in future before this gets pushed out to community, it's just not a focus right now.

You can see your Watchlist in the reading list feature:
https://meta.wikimedia.org/wiki/Special:ReadingLists
Or: https://meta.wikimedia.org/wiki/Special:ReadingLists/Jdlrobson/-10 (substituting my username for yours)

Thanks for sharing, I like the idea! :)

Change #1149471 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/ReadingLists@master] bookmark: Hide watch star if beta feature enabled

https://gerrit.wikimedia.org/r/1149471

Change #1147073 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Minerva doesn't support outputting custom data attributes

https://gerrit.wikimedia.org/r/1147073

Jdlrobson-WMF lowered the priority of this task from High to Medium.May 23 2025, 10:14 PM

Change #1149471 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] bookmark: Hide watch star if beta feature enabled

https://gerrit.wikimedia.org/r/1149471

Jdlrobson-WMF raised the priority of this task from Medium to High.May 23 2025, 11:03 PM
Jdlrobson-WMF updated the task description. (Show Details)

Updated the requirements based on what's been implemented so far. @Dillon could you take a look at AC5 and AC6? https://gerrit.wikimedia.org/r/1147073 should cover rest. Thanks in advance!

Jdlrobson-WMF lowered the priority of this task from High to Medium.May 23 2025, 11:11 PM

Change #1151792 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/ReadingLists@master] ReadingLists: Hide watchlist on Minerva

https://gerrit.wikimedia.org/r/1151792

Change #1151792 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] ReadingLists: Hide watchlist on Minerva

https://gerrit.wikimedia.org/r/1151792

Jdlrobson-WMF lowered the priority of this task from Medium to Low.
Jdlrobson-WMF added a subscriber: Dillon.

You can test this on beta cluster with new account and beta feature enabled.

Change #1147073 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes: Minerva doesn't support outputting custom data attributes

https://gerrit.wikimedia.org/r/1147073

Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Steps

Test Case 1: Watchstar hidden when beta is enabled (Minerva and Vector 2022)

  1. Create a new account or log in to one without edits
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Navigate to any article
  5. AC1: Watchstar is not visible in the page actions menu

screenshot 349.png (744×1 px, 257 KB)

  1. Switch to Vector 2022 skin
  2. Navigate to any article
  3. AC2: Watchstar is not visible in the page actions menu

The star that is visible is just the featured articles star, because of course I had to find an article with another star.

screenshot 350.png (744×1 px, 239 KB)

Test Case 1: Watchstar removed from Minerva and Vector 2022 when reading list beta is enabled (user has no edits)

  1. Create a new account on beta cluster.
  2. Do not make any edits.
  3. Go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-betafeatures and enable the Reading Lists beta feature.
  4. Visit any article using the Minerva skin (e.g., https://en.m.wikipedia.beta.wmflabs.org/wiki/Paris).
  5. AC1: Confirm the watchstar does not appear in the page actions menu in Minerva.
  1. Visit the same article using the Vector 2022 skin (e.g., https://en.wikipedia.beta.wmflabs.org/wiki/Paris?useskin=vector-2022).
  2. AC2: Confirm the watchstar does not appear in the page actions menu in Vector 2022.

Test Case 2: Watchstar appears when beta is disabled

  1. Disable the reading list beta feature
  2. Switch to Minerva skin
  3. Navigate to any article
  4. AC3: Watchstar is visible in the page actions menu
screenshot 353.png (744×1 px, 335 KB)
screenshot 354.png (634×489 px, 200 KB)
screenshot 355.png (744×1 px, 350 KB)
screenshot 356.png (744×1 px, 165 KB)
  1. Switch to Vector 2022 skin
  2. Navigate to any article
  3. AC4: Watchstar is visible in the page actions menu

screenshot 357.png (744×1 px, 469 KB)

Test Case 3: Watchlist menu item hidden for new user

  1. Create a brand-new account (no edits)
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Open the main menu (hamburger menu)
  5. AC5: Watchlist item is not shown in the menu

screenshot 359.png (744×1 px, 109 KB)

Test Case 4: Other skins are unaffected

  1. Enable the reading list beta feature
  2. Switch to a skin other than Minerva or Vector 2022 (e.g., Legacy Vector)
  3. Navigate to any article
  4. AC6: Watchstar and watchlist menu items are still present
Vector LegacyMonobookTimeless
screenshot 360.png (744×1 px, 540 KB)
screenshot 361.png (744×1 px, 548 KB)
screenshot 362.png (744×1 px, 426 KB)
Jdlrobson-WMF updated the task description. (Show Details)

Nice catch @Edtadros
@Dillon could you please take another pass at AC6 ? Sorry I missed this during code review.

Jdlrobson-WMF raised the priority of this task from Low to Medium.May 29 2025, 11:37 PM

@Edtadros The screenshot of Timeless doesn't have the user dropdown open where the Watchlist link is located. Can you confirm if it's there or not?

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Cat&useskin=timeless

How it looks:

Screenshot 2025-05-30 at 10.51.49 AM.png (1×3 px, 892 KB)

The issue is now the watchlist menu item but the watchstar
e.g. this should be appearing:

Screenshot 2025-05-30 at 10.52.45 AM.png (308×610 px, 41 KB)

Ah I see, working on a patch for that now! Thanks @Jdlrobson-WMF.

Change #1152343 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/extensions/ReadingLists@master] hook: Only hide watch icon on Vector 2022 and Minerva

https://gerrit.wikimedia.org/r/1152343

Change #1152343 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] hook: Only hide watch icon on Vector 2022 and Minerva

https://gerrit.wikimedia.org/r/1152343

Patch is merged. Please re-test AC4 @Edtadros

Edtadros removed Edtadros as the assignee of this task.EditedMay 31 2025, 6:20 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Steps

Test Case 4: Other skins are unaffected

  1. Enable the reading list beta feature
  2. Switch to a skin other than Minerva or Vector 2022 (e.g., Legacy Vector)
  3. Navigate to any article
  4. AC6: Watchstar and watchlist menu items are still present
Vector LegacyMonobookTimelessModern
screenshot 369.png (729×1 px, 583 KB)
screenshot 370.png (729×1 px, 656 KB)
screenshot 101.mov.gif (728×1 px, 872 KB)
I know it's deprecated, but it works
screenshot 371.png (729×1 px, 590 KB)

Test Result - Beta

Status: ✅ FAIL

Did you mean to put PASS here? I assume this is just a typo.

Jdlrobson-WMF claimed this task.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Steps

Test Case 1: Watchstar hidden when beta is enabled (Minerva and Vector 2022)

  1. Create a new account or log in to one without edits
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Navigate to any article
  5. AC1: Watchstar is not visible in the page actions menu

screenshot 349.png (744×1 px, 257 KB)

  1. Switch to Vector 2022 skin
  2. Navigate to any article
  3. AC2: Watchstar is not visible in the page actions menu

The star that is visible is just the featured articles star, because of course I had to find an article with another star.

screenshot 350.png (744×1 px, 239 KB)

Test Case 1: Watchstar removed from Minerva and Vector 2022 when reading list beta is enabled (user has no edits)

  1. Create a new account on beta cluster.
  2. Do not make any edits.
  3. Go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences#mw-prefsection-betafeatures and enable the Reading Lists beta feature.
  4. Visit any article using the Minerva skin (e.g., https://en.m.wikipedia.beta.wmflabs.org/wiki/Paris).
  5. AC1: Confirm the watchstar does not appear in the page actions menu in Minerva.

screenshot 17.png (1×1 px, 222 KB)

  1. Visit the same article using the Vector 2022 skin (e.g., https://en.wikipedia.beta.wmflabs.org/wiki/Paris?useskin=vector-2022).
  2. AC2: Confirm the watchstar does not appear in the page actions menu in Vector 2022.

screenshot 18.png (1×1 px, 371 KB)

screenshot 19.png (1×1 px, 364 KB)

Test Case 2: Watchstar appears when beta is disabled

  1. Disable the reading list beta feature
  2. Switch to Minerva skin
  3. Navigate to any article
  4. AC3: Watchstar is visible in the page actions menu

screenshot 20.png (1×1 px, 238 KB)

  1. Switch to Vector 2022 skin
  2. Navigate to any article
  3. AC4: Watchstar is visible in the page actions menu

screenshot 21.png (1×1 px, 289 KB)

Test Case 3: Watchlist menu item hidden for new user

  1. Create a brand-new account (no edits)
  2. Enable the reading list beta feature
  3. Switch to Minerva skin
  4. Open the main menu (hamburger menu)
  5. AC5: Watchlist item is not shown in the menu

Can not create new users in prod

Test Case 4: Other skins are unaffected

  1. Enable the reading list beta feature
  2. Switch to a skin other than Minerva or Vector 2022 (e.g., Legacy Vector)
  3. Navigate to any article
  4. AC6: Watchstar and watchlist menu items are still present
Vector LegacyMonobookTimeless
screenshot 23.png (1×1 px, 305 KB)
screenshot 22.png (1×1 px, 281 KB)
screenshot 24.png (1×1 px, 263 KB)