The EchoGetDefaultNotifiedUsers hook has been soft-deprecated in favor of locators way back in 2014: f995de90c8e1e643c0f4592243ef52e604cbcc10
Despite that there are still uses in popular extensions: https://codesearch.wmcloud.org/search/?q=EchoGetDefaultNotifiedUsers&files=php
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • matmarex | T387475 Migrate some uses of Echo hooks to static registries | |||
| Resolved | • matmarex | T394564 Migrate some uses of EchoGetDefaultNotifiedUsers hook to locators |
Change #1147084 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/BounceHandler@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1147085 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/FlaggedRevs@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1147084 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1147085 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Those 2 were the only extensions deployed on Wikimedia wikis.
There are a few more extensions maintained in Gerrit, I'll submit patches for them as well, then I'll consider this task done.
Change #1148476 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/SocialProfile@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1148477 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/InlineComments@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1148478 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/EditNotify@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1148479 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/Challenge@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Thank you for this, and thank you for setting a good example to other people and teams on how these kind of changes should be handled! ❤
Change #1148479 merged by jenkins-bot:
[mediawiki/extensions/Challenge@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1148476 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Let's call this done. Two of the patches remain unmerged, but my goal wasn't to migrate everything, just to provide some examples. I hope that someone will get around to reviewing them one day.
Change #1148477 merged by jenkins-bot:
[mediawiki/extensions/InlineComments@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1148478 merged by jenkins-bot:
[mediawiki/extensions/EditNotify@master] Migrate EchoGetDefaultNotifiedUsers hook to locators
Change #1284998 had a related patch set uploaded (by Reedy; author: Bartosz Dziewoński):
[mediawiki/extensions/FlaggedRevs@REL1_44] Migrate EchoGetDefaultNotifiedUsers hook to locators