Page MenuHomePhabricator

Quantity diffs present the unit a bit excessively
Closed, ResolvedPublic

Description

Example: https://www.wikidata.org/w/index.php?diff=1718083089&uselang=en

obrazek.png (1×885 px, 90 KB)

"Amount", "Upper bound" and "Lower bound" should present only the respective number without the unit, which is already presented on its own as "Unit". Repeating the same information is unnecessary, and makes the differences more difficult to spot.

Event Timeline

Change #1147113 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/Wikibase@master] Remove repetitive units from quantity details

https://gerrit.wikimedia.org/r/1147113

{​F60082950​}

The file is not currently visible to most people – please follow the “Steps to fix file visibility” at mw:Phabricator/Help § File visibility to fix it.

image.png (106×266 px, 6 KB)

Oops. Thanks for pointing this out!

Change #1147113 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove repetitive units from quantity details

https://gerrit.wikimedia.org/r/1147113

Note that rendered diffs seem to be cached somewhere (I had to clear the cache when testing the change locally), so old diffs may still display units after this change has rolled out with next week’s train. (I have no idea how long that cache lives, or whether it can be purged at all.)