Page MenuHomePhabricator
Create Task
Maniphest T394644

Migrate remaining hook handlers from ArticleDeleteComplete to PageDeleteComplete in wikibase client
Closed, ResolvedPublic
Actions

Description

The ArticleDeleteComplete hook is deprecated in MW 1.37. In Wikibase client, UpdateRepoHookHandler and DataUpdateHookHandler are still handling this hook. PageDeleteComplete should be used instead.

Acceptance Criteria

  • ArticleDeleteComplete is no longer listed in extension-client.json
    • UpdateRepoHookHandler implements PageDeleteCompleteHook
    • DataUpdateHookHandler implements PageDeleteCompleteHook

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Migrate ArticleDeleteComplete handlers to PageDeleteCompletemediawiki/extensions/Wikibasemaster+87 -64
Customize query in gerrit

Related Objects
Search...

Event Timeline

ArthurTaylor created this task.May 19 2025, 9:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2025, 9:38 AM
ArthurTaylor claimed this task.May 19 2025, 9:38 AM
ArthurTaylor moved this task from Incoming to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added: Wikidata-Omega (The Board); removed: Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
Maintenance_bot added a project: Wikidata.May 19 2025, 10:30 AM
ArthurTaylor added a parent task: T381172: [EPIC] Update all WMDE Wikibase topics to use the new HookContainer/HookRunner system.May 19 2025, 10:55 AM
gerritbot added a comment.May 19 2025, 11:07 AM

Change #1147740 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Migrate ArticleDeleteComplete handlers to PageDeleteComplete

https://gerrit.wikimedia.org/r/1147740

gerritbot added a project: Patch-For-Review.May 19 2025, 11:07 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.May 19 2025, 11:22 AM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
hoo moved this task from Ready for Peer Review to Ready for Tech Verification on the Wikidata-Omega (The Board) board.May 19 2025, 12:27 PM
gerritbot added a comment.May 19 2025, 12:50 PM

Change #1147740 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Migrate ArticleDeleteComplete handlers to PageDeleteComplete

https://gerrit.wikimedia.org/r/1147740

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 19 2025, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 19 2025, 1:30 PM
karapayneWMDE closed this task as Resolved.Jun 6 2025, 2:52 PM
karapayneWMDE claimed this task.
karapayneWMDE moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.
karapayneWMDE moved this task from In Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
karapayneWMDE edited projects, added: Wikidata-Omega (Completed Tasks); removed: Wikidata-Omega (The Board).
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.Jun 18 2025, 6:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits