Parsoid's AttributeExpander doesn't stringify \n# correctly (which can appear in CSS styles)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Andyrom75
	May 19 2025, 12:45 PM

Description

https://it.wikivoyage.org/wiki/Utente:Andyrom75
is rendered differently from
https://it.wikivoyage.org/w/index.php?title=Utente:Andyrom75&useparsoid=0

Chrome and Firefox (latest versions) provide the same result.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.23.0-a12	mediawiki/vendor	master	+929 -492
	Restore bullets before retokenizing expanded attrs	mediawiki/services/parsoid	master	+14 -0

Customize query in gerrit

Related Objects

Mentioned Here: T186278: Attributes that expand to block? elements fail to roundtrip

Event Timeline

Andyrom75 created this task.May 19 2025, 12:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2025, 12:45 PM

Checking the rendered code, I've noticed that Parsoid eliminate the symbol "#" from the color definition.
In this way, the CSS rule become invalid.

This is the line WITHOUT Pasoid:
<div style="padding: 0.8em;border: 2px solid #777;background: #f8f8f8;color:black;text-align: left;margin: 0 0 1em;">

This is the line WITH Pasoid:
<div style="padding: 0.8em;border: 1px solid 777;background: f8f8f8;color:black;text-align: left;margin: 0 0 1em;" about="#mwt24" typeof="mw:ExpandedAttrs" id="mwIg" data-mw="{"attribs":[[{"txt":"style","html":"<span about=\"#mwt22\" typeof=\"mw:Transclusion\" data-parsoid='{\"pi\":[[{\"k\":\"color\",\"named\":true}]],\"dsr\":[1408,1431,null,null]}' data-mw='{\"parts\":[{\"template\":{\"target\":{\"wt\":\"SectionText\",\"href\":\"./Template:SectionText\"},\"params\":{\"color\":{\"wt\":\"4\"}},\"i\":0}}]}'>style=\"padding: 0.8em; border: 1px solid \n#777; background: \n#f8f8f8; color:black; text-align: left; margin: 0 0 1em; \"</span>"},{"html":""}]]}">

Andyrom75 renamed this task from CSS border and background are broken with parsoid to Parsoid eliminate # in CSS rules.Nov 12 2025, 3:17 PM

Since in 6 months I got no reply, I've changed completely the templates to solve the local issue, but I leave open the ticket to track it.

It looks like template expansion to something like,

style="padding: 0.8em; border: 1px solid  
#4d64cf; background: 
#f3faff; color:black; text-align: left; margin: 0 0 1em;        "

which gets tokenized as a list item,

2-[peg]        | ---->    [{"type":"NlTk","dataParsoid":{"tsr":[42,43]}},{"type":"TagTk","name":"listItem","attribs":[{"k":"bullets","v":["#"],"srcOffsets":[43,43,43,44]}],"dataParsoid":{"tsr":[43,44]}},"4d64cf;"]

and then the attribute expander is dropping the hash when stringifying the result.

T186278 seems somewhat related

cscott renamed this task from Parsoid eliminate # in CSS rules to Parsoid's AttributeExpander doesn't stringify \n# correctly (which appears in CSS rules).Nov 20 2025, 3:27 PM

cscott renamed this task from Parsoid's AttributeExpander doesn't stringify \n# correctly (which appears in CSS rules) to Parsoid's AttributeExpander doesn't stringify \n# correctly (which can appear in CSS styles).

MSantos triaged this task as Low priority.Nov 20 2025, 3:27 PM

MSantos edited projects, added Parsoid-Read-Views; removed Parsoid-Read-Views (Large Wikipedias), Content-Transform-Team.

Restricted Application added a project: Parsoid. · View Herald TranscriptNov 20 2025, 3:27 PM

MSantos moved this task from Uncategorized to Non-blockers (any wiki) on the Parsoid-Read-Views board.Nov 20 2025, 3:27 PM

SLopes-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Nov 27 2025, 3:29 PM

Change #1225041 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Restore bullets before retokenizing expanded attrs

https://gerrit.wikimedia.org/r/1225041

gerritbot added a project: Patch-For-Review.Jan 9 2026, 11:20 PM

ABreault-WMF claimed this task.Jan 9 2026, 11:21 PM

ABreault-WMF added a project: Content-Transform-Team (Work In Progress).

ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.