Maniphest T394663

dot product code implementations fail
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DVrandecic
	May 19 2025, 1:04 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to replicate the issue (include links if applicable):

https://www.wikifunctions.org/view/en/Z24188

What happens?:
The code implementations fail.

What should have happened instead?:
They should pass.

It can easily be that the error is in the code implementations. Users Dv13 and 99of9 couldn't figure out what's wrong. This needs investigation. Reported here: https://www.wikifunctions.org/wiki/Wikifunctions:Project_chat#Problems_with_a_js_implementation

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

DVrandecic created this task.May 19 2025, 1:04 PM

99of9 subscribed.May 19 2025, 11:52 PM

Jdforrester-WMF triaged this task as High priority.May 21 2025, 3:49 PM

Jdforrester-WMF moved this task from To Triage to Bugs to investigate on the Abstract Wikipedia team board.

Jdforrester-WMF added a project: function-orchestrator.

Jdforrester-WMF added a subscriber: cmassaro.

The javascript implementations now seem to work. The python doesn't.

cmassaro claimed this task.May 27 2025, 5:54 PM

The problem was the import statement:

import fractions.Fraction as f

doesn't work because fractions isn't a package. The correct invocation is

from fractions import Fraction as f

I've tested this under python3.12 and RustPython. I've also changed the live implementation and tests are passing.

cmassaro changed the task status from Open to In Progress.May 27 2025, 6:22 PM

cmassaro moved this task from Bugs to investigate to 25Q4 (Apr–Jun) on the Abstract Wikipedia team board.

cmassaro edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)); removed Abstract Wikipedia team.

cmassaro moved this task from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.

@DVrandecic Can we close this?

Nice, thanks. Looks done to me.

Thanks! This looks resolved.