Page MenuHomePhabricator

Add step-backwards from "thanks" with file errors to "describe" to allow changes if necessary
Closed, ResolvedPublic

Description

Rather than just stopping and offering "retry" as the only option, errors on the final step should probably give the user the option to go backwards and add in the right filename, change the description, and so on. This is necessary especially because we may soon be finishing the description, etc., _before_ the stash upload finishes, so any errors from both upload attempts would need to be shown on the description page. The fix for bug 32247 already allows removal of the file from "describe" (so if it's a duplicate error, the file can be removed easily), so any error could feasibly be fixed, or at least worked around, with the addition of this backwards mobility.

Note that I still don't think backwards navigation makes sense in any other case, because other data would not need to be changed based on the server's input.


Version: unspecified
Severity: normal

Details

Reference
bz37468

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:25 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz37468.
bzimport added a subscriber: Unknown Object (MLST).

OK, as it turns out, this capability exists! The only thing was, for unknown and duplicate errors, we weren't calling the right methods.

Patch. Patch need review. https://gerrit.wikimedia.org/r/10995

Correction: Patch. Patch in Gerrit.

As the referenced gerrit patch is merged, I assume this bug can be closed?

Also, this bug seems to be about the same or at last very related to bug 29594, but well.

So is this done now...?

Twice no feedback => Assuming this is FIXED as per merged Gerrit patch.

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:21 AM