Page MenuHomePhabricator

Consider ignoring permission checks in backfillLocalAccounts.php
Open, Needs TriagePublic

Description

backfillLocalAccounts.php can fail to backfill the account on loginwiki/metawiki because the autocreation is prevented by a permission check, block or abuse filter. Should we prevent that? Or prevent that on loginwiki only (on account of vandalism being less of a problem there than on metawiki)?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

https://phabricator.wikimedia.org/T378401#10307273 for more about the backfill script and what it skips when doing autocreates; this can be revisited if appropriate.

Maybe we should pass UltimateAuthority as the performer for the backfill script. Not 100% sure about meta, but at least on loginwiki I imagine we'd prefer the account to be created, even if it's blocked or prevented by some other rule.

I think this is ultimately a question for stewards, as they are the target audience for these autocreations: when a user registers successfully on some wiki, but their local account on metawiki and/or loginwiki cannot be created because of some local rule (block, abusefilter etc), what would be your preferred outcome for the backfill script (T371267: Create a script to backfill missing local accounts on loginwiki/metawiki for new global accounts)? Obeying the rule or overriding it and creating the account anyway?

Maybe we should pass UltimateAuthority as the performer for the backfill script. Not 100% sure about meta, but at least on loginwiki I imagine we'd prefer the account to be created, even if it's blocked or prevented by some other rule.

I think this is ultimately a question for stewards, as they are the target audience for these autocreations: when a user registers successfully on some wiki, but their local account on metawiki and/or loginwiki cannot be created because of some local rule (block, abusefilter etc), what would be your preferred outcome for the backfill script (T371267: Create a script to backfill missing local accounts on loginwiki/metawiki for new global accounts)? Obeying the rule or overriding it and creating the account anyway?

Yes the backfill script should create an account on loginwiki, even if the account's IP is globally blocked (that's typically the reason why an account is created on meta but nowhere else, e.g. https://meta.wikimedia.org/wiki/Special:CentralAuth/Marx.Elon.Wu). Without a loginwiki account there's no way for stewards to perform CU unless they also hold CU permissions on metawiki. That's especially true now that T394732: backfillLocalAccounts.php does not (always?) copy checkuser data is basically fixed (except for MediaWikiAccountBackfiller appearing in CU results T394732#11612502).