Page MenuHomePhabricator
Create Task
Maniphest T394739

Special:ImportTranslations does not handle all Gettext parsing errors
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Please import https://kizule.xyz/out-mantis-0-all_sr-el.po file for out-mantis-0-all (just for sr-el and I don't need to be provided with sr-ec file or something like that what I usually request for mediawiki group).

I was able to import the sr-ec file without any problems through Special:ImportTranslations. This one is giving me a hard time and throwing RuntimeException. Please import it server-side.

Steps to replicate the issue (include links if applicable):

  • Go to Special:ImportTranslations
  • Try to import the file which I provided

What happens?:
[5bfe49f3f3fba06f123a8109] 2025-05-19 21:40:04: Фатална грешка типа „RuntimeException”

What should have happened instead?:
Import should work without such errors.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
/

Other information (browser name/version, screenshots, etc.):
/

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ImportTranslationsSpecialPage: Handle all Gettext errorsmediawiki/extensions/Translatemaster+13 -6
Customize query in gerrit

Event Timeline

Kizule created this task.May 19 2025, 9:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 19 2025, 9:41 PM
Kizule changed the subtype of this task from "Bug Report" to "Task".May 19 2025, 9:41 PM
Kizule moved this task from Backlog to System admin stuff on the translatewiki.net board.
gerritbot added a comment.May 20 2025, 7:24 AM

Change #1148208 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] ImportTranslationsSpecialPage: Handle all Gettext errors

https://gerrit.wikimedia.org/r/1148208

gerritbot added a project: Patch-For-Review.May 20 2025, 7:24 AM
Nikerabbit subscribed.May 20 2025, 7:24 AM

The file is incorrectly formatted, so server side import would give the same error. Here is the full error:

exception.ERROR: [b35af8a474f9e65a2f9e2cea] /wiki/Special:ImportTranslations   RuntimeException: Unable to parse msgstr:

msgctxt "s_project_delete_msg"
msgid "Are you sure you want to delete project \"%1$s\"?<br>This will also delete %2$s attached issue reports."
msgstr Da li ste sigurni da želite da obrišete projekat \"%1$s\"?<br>Ovim će biti obrisano %2$s prijavljenih problema na njemu."

Side note: I recommend against moving things to columns, as we triage from the backlog and may miss tickets that have been moved already.

Nikerabbit claimed this task.May 20 2025, 7:25 AM
Nikerabbit set the point value for this task to 2.
Nikerabbit edited projects, added Unplanned-Sprint-Work, LPL Essential (LPL Essential 2025 Apr-Jun: CX), MediaWiki-extensions-Translate; removed translatewiki.net.
Nikerabbit moved this task from Backlog to In Progress on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.
Nikerabbit added a comment.May 20 2025, 7:30 AM

With the patch it will look like this:

image.png (1×2 px, 133 KB)

Kizule added a comment.May 20 2025, 11:33 PM
In T394739#10837891, @Nikerabbit wrote:

The file is incorrectly formatted, so server side import would give the same error. Here is the full error:

exception.ERROR: [b35af8a474f9e65a2f9e2cea] /wiki/Special:ImportTranslations   RuntimeException: Unable to parse msgstr:

msgctxt "s_project_delete_msg"
msgid "Are you sure you want to delete project \"%1$s\"?<br>This will also delete %2$s attached issue reports."
msgstr Da li ste sigurni da želite da obrišete projekat \"%1$s\"?<br>Ovim će biti obrisano %2$s prijavljenih problema na njemu."

Side note: I recommend against moving things to columns, as we triage from the backlog and may miss tickets that have been moved already.

Thank you for letting me know, I made a fix, and I was able to import it now.

In T394739#10837901, @Nikerabbit wrote:

With the patch it will look like this:

image.png (1×2 px, 133 KB)

Thank you so much for this, it looks nice.

Nikerabbit added a comment.May 21 2025, 6:43 AM

Latest version of the patch:

image.png (1×2 px, 118 KB)

Kizule added a comment.May 21 2025, 6:52 AM
In T394739#10842617, @Nikerabbit wrote:

Latest version of the patch:

image.png (1×2 px, 118 KB)

Nice. ❤️

Nikerabbit triaged this task as High priority.May 21 2025, 7:06 AM
Nikerabbit renamed this task from Request for importing PO file for out-mantis-0-all to translatewiki.net to Special:ImportTranslations does not handle all Gettext parsing errors.May 22 2025, 7:17 AM
gerritbot added a comment.May 22 2025, 10:18 AM

Change #1148208 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] ImportTranslationsSpecialPage: Handle all Gettext errors

https://gerrit.wikimedia.org/r/1148208

Maintenance_bot removed a project: Patch-For-Review.May 22 2025, 10:30 AM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 22 2025, 11:00 AM
Nikerabbit moved this task from In Progress to Pending Deployment on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.May 22 2025, 11:49 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.Jun 2 2025, 6:49 AM
Nikerabbit closed this task as Resolved.Jun 3 2025, 6:49 AM
Nikerabbit moved this task from Need QA to Done on the LPL Essential (LPL Essential 2025 Apr-Jun: CX) board.

Looks good on production too,

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits