Page MenuHomePhabricator
Create Task
Maniphest T394776

Trigger diff-specific functions using the wikipage.diff hook in Mobile Diffs
Closed, ResolvedPublicBUG REPORT
Actions

Description

I propose that the relevant portion of code — line 234 in initMobile.js — should be triggered via mw.hook( 'wikipage.diff' ).

This would improve extensibility and allow reuse in scripts that dynamically load diffs, such as my tool: Instant Diffs.

As you can see, the timestamp marker is added by the initModifiedInfo function:

image.png (392×846 px, 47 KB)
image.png (390×844 px, 32 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Trigger modified info on mobile diffsOsps7mediawiki/skins/MinervaNeuemaster+1 -0
Customize query in gerrit

Event Timeline

SerDIDG created this task.May 20 2025, 1:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2025, 1:12 PM
SToyofuku-WMF added a project: Web-Team.May 21 2025, 9:35 PM
SToyofuku-WMF added subscribers: ovasileva, SToyofuku-WMF.

Something to consider - tagging @ovasileva for prioritization

KSarabia-WMF triaged this task as Medium priority.May 27 2025, 5:06 PM
KSarabia-WMF lowered the priority of this task from Medium to Low.
KSarabia-WMF moved this task from Incoming to Freezer on the Web-Team board.
KSarabia-WMF added a project: patch-welcome.
Jdlrobson-WMF removed a project: Web-Team.Aug 27 2025, 11:52 PM
Jdlrobson-WMF removed a project: MobileFrontend.Sep 10 2025, 10:45 PM
Jdlrobson-WMF subscribed.

Diffs on mobile are styled using skinStyles/mediawiki.diff.styles.less in Minerva. Untagging MobileFrontend.

Jdlrobson-WMF moved this task from Backlog to Tracking on the MinervaNeue board.Apr 7 2026, 11:28 PM
Jdlrobson-WMF edited projects, added: MinervaNeue (Tracking); removed: MinervaNeue.
gerritbot added a comment.Sep 5 2026, 4:21 PM

Change #1336902 had a related patch set uploaded (by Osps7; author: Osps7):

[mediawiki/skins/MinervaNeue@master] Trigger modified info on mobile diffs

https://gerrit.wikimedia.org/r/1336902

gerritbot added a project: Patch-For-Review.Sep 5 2026, 4:21 PM
Osps7 subscribed.Sep 5 2026, 4:22 PM

Implemented a patch for this task by triggering initModifiedInfo through the wikipage.diff hook. This allows the modified-info enhancements to be triggered when diffs are dynamically loaded, improving extensibility and reuse for Mobile Diffs.

gerritbot added a comment.Mon, Sep 21, 2:44 PM

Change #1336902 had a related patch set uploaded (by Osps7; author: Osps7):

[mediawiki/skins/MinervaNeue@master] Trigger modified info on mobile diffs

https://gerrit.wikimedia.org/r/1336902

gerritbot added a comment.Thu, Sep 24, 7:00 AM

Change #1336902 had a related patch set uploaded (by Osps7; author: Osps7):

[mediawiki/skins/MinervaNeue@master] Trigger modified info on mobile diffs

https://gerrit.wikimedia.org/r/1336902

gerritbot added a comment.Thu, Sep 24, 11:10 PM

Change #1336902 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Trigger modified info on mobile diffs

https://gerrit.wikimedia.org/r/1336902

Jdlrobson-WMF closed this task as Resolved.Thu, Sep 24, 11:19 PM
Jdlrobson-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits