Page MenuHomePhabricator
Create Task
Maniphest T394812

InvalidTiffException: Could not extract data from tiff file {filename}
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   InvalidTiffException: Could not extract data from tiff file {filename}
FrameLocationCall
from/srv/mediawiki/php-1.45.0-wmf.1/includes/media/BitmapMetadataHandler.php(298)
#0/srv/mediawiki/php-1.45.0-wmf.1/extensions/PagedTiffHandler/includes/PagedTiffImage.php(194)BitmapMetadataHandler::Tiff(string)
#1/srv/mediawiki/php-1.45.0-wmf.1/extensions/PagedTiffHandler/includes/PagedTiffHandler.php(601)MediaWiki\Extension\PagedTiffHandler\PagedTiffImage->retrieveMetaData()
#2/srv/mediawiki/php-1.45.0-wmf.1/includes/media/MediaHandler.php(230)MediaWiki\Extension\PagedTiffHandler\PagedTiffHandler->getSizeAndMetadata(TrivialMediaHandlerState, string)
#3/srv/mediawiki/php-1.45.0-wmf.1/includes/utils/MWFileProps.php(91)MediaHandler->getSizeAndMetadataWithFallback(Wikimedia\FileBackend\FSFile\FSFile, string)
#4/srv/mediawiki/php-1.45.0-wmf.1/includes/upload/UploadBase.php(589)MWFileProps->getPropsFromPath(string, string)
#5/srv/mediawiki/php-1.45.0-wmf.1/includes/upload/UploadBase.php(514)UploadBase->verifyPartialFile()
#6/srv/mediawiki/php-1.45.0-wmf.1/includes/upload/UploadBase.php(437)UploadBase->verifyFile()
#7/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiUpload.php(822)UploadBase->verifyUpload()
#8/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiUpload.php(159)MediaWiki\Api\ApiUpload->verifyUpload()
#9/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(2010)MediaWiki\Api\ApiUpload->execute()
#10/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(948)MediaWiki\Api\ApiMain->executeAction()
#11/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiMain.php(919)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#12/srv/mediawiki/php-1.45.0-wmf.1/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#13/srv/mediawiki/php-1.45.0-wmf.1/includes/MediaWikiEntryPoint.php(198)MediaWiki\Api\ApiEntryPoint->execute()
#14/srv/mediawiki/php-1.45.0-wmf.1/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#15/srv/mediawiki/w/api.php(3)require(string)
#16{main}
Impact
Notes

Error handling introduced in early April 2025 via "media: Normalize file names in Tiff exceptions" in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/42b3aa3a88515ceab18de4b463431b494689b167%5E%21/includes/media/BitmapMetadataHandler.php by @taavi.
Maybe this is all intentional (useful feedback given to a user trying to upload a TIFF file and wondering why it fails) and should be declined (though I wonder if we could avoid having this propoagated into Logstash).
Still filing this ticket for the papertrail so we'd have a decision record in any case.

Details

MediaWiki Version
1.45.0-wmf.1
Request URL
https://commons.wikimedia.org/w/api.php
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Catch InvalidTiffException when extract exif data from tiff filesmediawiki/extensions/PagedTiffHandlermaster+11 -2
Customize query in gerrit

Event Timeline

Aklapper created this task.May 20 2025, 5:00 PM
Krinkle subscribed.May 20 2025, 6:06 PM
From the task description:

The above link reports the underlying issue in the shellbox "exec" channel (right before, during the same request):

context.command
/bin/bash '/srv/app/src/Command/limit.sh' ''\''/bin/bash'\'' '\''scripts/retrieveMetaData.sh'\''' 'SB_INCLUDE_STDERR=;SB_CPU_LIMIT=50; SB_CGROUP='\'''\''; SB_MEM_LIMIT=1073741824; SB_FILE_SIZE_LIMIT=536870912; SB_WALL_CLOCK_LIMIT=60; SB_USE_LOG_PIPE=yes'
context.api_client_user_agent
Spacemedia/0.5.0-SNAPSHOT (https://commons.wikimedia.org/wiki/Commons:Spacemedia - OptimusPrimeBot) SpringBoot/3.4.5 ScribeJava/8.3.3 Flickr4Java/3.0.9
context.error
TIFFReadDirectory: Warning, Unknown field with tag 33550 (0x830e) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 33922 (0x8482) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 34735 (0x87af) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 34736 (0x87b0) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 34737 (0x87b1) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42112 (0xa480) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
TIFFReadDirectory: Warning, Unknown field with tag 42113 (0xa481) encountered.
Krinkle added a project: Content-Transform-Team.May 20 2025, 6:11 PM

Tagging per mw:Maintainers.

The impact today is that this Tiff file cannot be uploaded to Wikimedia Commons, and the user receives an unhelpful "Internal server error".

The main question here is: Is this particular Tiff metadata intentionally hard-required during upload? That is, we consider it an invalid Tiff file without this?

If yes, we should catch the exception and tell the user why and what they can do about it.

If not, we should not throw exception, and log a diagnostic warning to Logstash visible to maintainers, without preventing the upload itself.

Krinkle moved this task from Untriaged to Apr-Jun 2025 on the Wikimedia-production-error board.May 20 2025, 6:11 PM
MSantos edited projects, added Essential-Work, Content-Transform-Team (Work In Progress); removed Content-Transform-Team.May 22 2025, 2:04 PM
MSantos moved this task from Backlog to Needs Investigation on the Content-Transform-Team (Work In Progress) board.
gerritbot added a comment.Jul 31 2025, 8:18 PM

Change #1174810 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PagedTiffHandler@master] Catch InvalidTiffException when extract exif data from tiff files

https://gerrit.wikimedia.org/r/1174810

gerritbot added a project: Patch-For-Review.Jul 31 2025, 8:19 PM
Umherirrender claimed this task.Aug 25 2025, 7:30 PM
Jgiannelos subscribed.Aug 28 2025, 8:24 AM

Untagging content transform team WIP from needs investigation because there is a patch for the issue.
Thanks @Umherirrender

Jgiannelos removed a project: Content-Transform-Team (Work In Progress).Aug 28 2025, 8:24 AM
gerritbot added a comment.Sep 27 2025, 6:31 PM

Change #1174810 merged by jenkins-bot:

[mediawiki/extensions/PagedTiffHandler@master] Catch InvalidTiffException when extract exif data from tiff files

https://gerrit.wikimedia.org/r/1174810

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2025, 6:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 27 2025, 7:00 PM
Umherirrender closed this task as Resolved.Sep 30 2025, 4:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits