CommonPasswords failing with timeouts
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 20 2025, 5:58 PM

Description

Different composer test failure on different php versions on https://gerrit.wikimedia.org/r/c/mediawiki/libs/CommonPasswords/+/1147861 due to timeout

19:46:27 Analyzing files...
19:46:27 ░░                                                     2 / 2 (100%) 295MB
19:51:24 The following exception is caused by a process timeout
19:51:24 Check https://getcomposer.org/doc/06-config.md#process-timeout for details
19:51:24 
19:51:24 In Process.php line 1205:
19:51:24                                                                                
19:51:24   The process "phan --allow-polyfill-parser --long-progress-bar" exceeded the  
19:51:24    timeout of 300 seconds.                                                     
19:51:24

In a passing job there is a time leak between phan and minus, not sure what is running there, but it timeouts out "that" takes to long

19:46:41 Analyzing files...
19:46:41 ░░                                                     2 / 2 (100%) 294MB
19:50:28 
19:50:29 > minus-x check .
19:50:29 MinusX
19:50:29 ======
19:50:29 Processing /src...
19:50:29 .....................
19:50:29 All good!
19:50:29 [PostBuildScript] - [INFO] Executing post build scripts.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CI: Exclude common.php from phan	mediawiki/libs/CommonPasswords	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned In: T395292: taint-check chokes on huge arrays
Mentioned Here: T395292: taint-check chokes on huge arrays
T212460: Adopt static array files for local disk storage of values (epic)
T379482: Increase the common passwords list to 1M entries

Event Timeline

Umherirrender created this task.May 20 2025, 5:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 20 2025, 5:58 PM

		"test": [
			"parallel-lint . --exclude vendor",
			"phpunit",
			"covers-validator",
			"@phpcs",
			"phan --allow-polyfill-parser --long-progress-bar",
			"minus-x check ."
		],

Arguably some fallout from {f1d9f97730a2971cce31101cffd716d3f4d72059} for T212460: Adopt static array files for local disk storage of values (epic)... Which reverting would make T379482: Increase the common passwords list to 1M entries easier.

Change #1148964 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/CommonPasswords@master] CI: Exclude common.php from phan

https://gerrit.wikimedia.org/r/1148964

gerritbot added a project: Patch-For-Review.May 21 2025, 9:23 PM

There's probably scope for an Upstream bug report for the perf issue for phan, if someone wants...

Change #1148964 merged by jenkins-bot:

[mediawiki/libs/CommonPasswords@master] CI: Exclude common.php from phan

https://gerrit.wikimedia.org/r/1148964

Maintenance_bot removed a project: Patch-For-Review.May 21 2025, 9:30 PM

Umherirrender closed this task as Resolved.May 21 2025, 9:51 PM

Umherirrender added a project: phan.

In T394821#10845912, @Reedy wrote:

There's probably scope for an Upstream bug report for the perf issue for phan, if someone wants...

Filed T395292. The bug appears to be in taint-check, not phan.

Tests on mediawiki/libs/CommonPasswords failing with timeoutsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Tests on mediawiki/libs/CommonPasswords failing with timeouts
Closed, ResolvedPublic
Actions