Page MenuHomePhabricator

[MEX] Format a simple statement using a Commons media datatype
Closed, ResolvedPublic

Description

Update the formatting of a statement in the MEX view to match the prototype, but apply it for a Commons media datatype:

Current display:

image.png (331×339 px, 24 KB)

Expected formatting

image.png (317×576 px, 16 KB)

Figma file

Acceptance Criteria

  • Statement should appear with the same formatting as the prototype for a Commons media datatype

Notes
This is a read-only so no edit links need to be clickable.

Event Timeline

Change #1153553 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] [WIP] Draft of commons media statement view

https://gerrit.wikimedia.org/r/1153553

I have a patch with a first draft that looks like this:

2025-06-04-103901_389x210_scrot.png (210×389 px, 12 KB)

Some questions that come up - @LarissaHonsek:

  • What should be the behaviour for images with different aspect ratios? Is there a max-width or a max-height and a min-width / min-height? What is that expressed as rem?
  • We don't have a codex icon for the statement rank selector (ui-icon-rankselector). Can we get an SVG version of the icon?
  • To make the line spacing (between Rihanna-signature.svg and 348 x 178...) look right, I had to introduce a negative margin on the paragraphs. Is this expected / intended?
  • Your x character in 348 x 178 is vertically centered. When I just put the same glyph in a string, it shows up on the bottom of the line. Did you do anything special to get that vertically centered?
ArthurTaylor changed the task status from Open to Stalled.Jun 4 2025, 8:46 AM
ArthurTaylor removed ArthurTaylor as the assignee of this task.
ArthurTaylor subscribed.

Per our meeting 5. June, @LarissaHonsek will create some designs to show the behaviour of different images sizes for the commons media type. For the other questions, we can skip the pixel-perfect positioning in the first draft of the functionality.

ArthurTaylor changed the task status from Stalled to Open.Jun 5 2025, 11:09 AM

Change #1163286 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add initial draft of commonsMedia statement view

https://gerrit.wikimedia.org/r/1163286

Change #1153553 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] [WIP] Draft of commons media statement view

Reason:

Superceded by I516400cdf2

https://gerrit.wikimedia.org/r/1153553

Change #1163286 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add initial draft of commonsMedia statement view

https://gerrit.wikimedia.org/r/1163286

Is there somewhere I can check this one?

Arian_Bozorg claimed this task.

Thank you! This is functional, although there are some UI issues on this one:

  • The ranking is appearing over the image
  • The dropdown arrow for the references is aligned with the bottom of the text rather than the centre of the text

image.png (241×440 px, 19 KB)

@Arian_Bozorg It's good to have this feedback, but I worried that it will get lost on a 'resolved' ticket. It would be good to have somewhere where we are collecting the delta between how the UI looks in the "first pass" and how it looks in the design - that will be a very useful guide for the next milestone. Do you have such a document? (A figma?) Will you make one?