Page MenuHomePhabricator

definitions: Copy selected user-defined ZObjects into function-schemata for testing of new Wikidata types
Closed, ResolvedPublic

Description

Description

We have decided to allow certain predefined ZObjects (created for T390559) to make use of several user-defined types (as types of their keys). For this to work well, these user-defined types, and some of their related support functions, need to be available for testing, in CI and in local environments. To make them available, we need to do the following steps for each of the ZObjects listed below.

  1. Get the JSON content for its entire Z2 from Wikifunctions.org
  2. Remove all labels, aliases, and descriptions except those in English
  3. Using the original ZID, commit & merge the resulting slenderized JSON, as <ZID>.json, in function-schemata/data/definitions

Nested types (Added 2 June 2025):

The above 4 types are directly referenced by the new predefined types created for T390559.
Below are some nested types - user-space types that are referenced by the four types above. It's not entirely clear at present whether they need to be added. If the following referenced types are not present, will some tests break? Do we even know without trying it? (From the orchestrator perspective, we should know more after coding tests for T391216.) Also, if we include these types, should we include their converters and equality functions (if any)?

  • Rational number uses:
    • Sign (Z16659)
  • Gregorian calendar date uses:
    • Gregorian year (Z20159), which uses
      • Gregorian era (Z17813)
    • Day of Roman year (Z20342), which uses
      • Gregorian calendar month (Z16098)

Completion checklist

Event Timeline

DSantamaria added a project: OKR-Work.
Jdforrester-WMF changed the task status from Open to In Progress.Jun 2 2025, 9:15 PM
Jdforrester-WMF claimed this task.

Change #1153681 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (69e4f72)

https://gerrit.wikimedia.org/r/1153681

Change #1153681 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (69e4f72)

https://gerrit.wikimedia.org/r/1153681

Change #1155661 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-06-03-205630 to 2025-06-09-163022

https://gerrit.wikimedia.org/r/1155661

Change #1155662 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-06-04-185118 to 2025-06-10-144243

https://gerrit.wikimedia.org/r/1155662

Change #1155661 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-06-03-205630 to 2025-06-09-163022

https://gerrit.wikimedia.org/r/1155661

Change #1155662 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update orchestrator from 2025-06-04-185118 to 2025-06-10-144243

https://gerrit.wikimedia.org/r/1155662