The MR https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/77 worked around not having the image_name from the build by using destination_image, but after T395035: [builds-api] populate the `image_name` for the builds returned image_name should be populated correctly, so we can drop that logic and reuse what the builds-api returns.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Raymond_Ndibe | T395076 [components-api] use the `build.params.image_name` to compare with the `component` | |||
| Resolved | • Chuckonwumelu | T395035 [builds-api] populate the `image_name` for the builds returned |
Event Timeline
Comment Actions
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Comment Actions
@Chuckonwumelu this task is also a good one for you to work on, after you complete T395035: [builds-api] populate the `image_name` for the builds returned.
Comment Actions
raymond-ndibe opened https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/115
[toolforge,tool_handlers] replace destination_name comparisons with image_name
Comment Actions
raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/components-api/-/merge_requests/115
[toolforge,tool_handlers] replace destination_name comparisons with image_name
Comment Actions
group_203_bot_f4d95069bb2675e4ce1fff090c1c1620 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1003
components-api: bump to 0.0.170-20251021000227-485a8fbc
Comment Actions
raymond-ndibe merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/1003
components-api: bump to 0.0.170-20251021000227-485a8fbc