Page MenuHomePhabricator

Empty Wikipedia logo link can trip screen reader software
Closed, DeclinedPublic

Description

Author: mohinder.khosla

Description:
Empty link in the content section of articles

There is an empty link in the content section of articles such as Obama, Drew Barrymore below Wikipedia logo to visit main page that is unrecognised by web content readers such as JAWS and NVDA. The relevant HTML that is causing the problem is

1<div id="p-logo" role="banner">
2 <a class="mw-wiki-logo" href="/wiki/Main_Page" title="Visit the main page"></a>
3</div>
4<div class="portal" role="navigation" id='p-navigation' aria-labelledby='p-navigation-label'>
5 <h3 id='p-navigation-label'>Navigation</h3>
6 <div class="body">

Pages checked:

http://en.wikipedia.org/wiki/Drew_Barrymore?aftv5_form=1&aftv5_link=E
http://en.wikipedia.org/wiki/Barack_Obama?aftv5_form=1&aftv5_link=E
http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?aftv5_form=1&aftv5_link=E

Browser: FF12

Machine Specifications:

Dell Laptop Mode: Studio 1555
Windows 7 Home Premium
Service Pack 1
System Type: 64 bit
Processor: Pentium (R) Dual-Core CPU T4300 2.1 GHz
RAM: 4 GB
Hard Drive: 500 GB


Version: 1.21.x
Severity: minor
OS: Windows 7
Platform: PC

Attached:

Bug_21b-Bug_Left_top_corner-Empty_link_problem_with_MSAA.JPG (117×196 px, 12 KB)

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 12:29 AM
bzimport set Reference to bz37515.
bzimport added a subscriber: Unknown Object (MLST).

This is completely unrelated to AFTv5.

Took me a while to find this in the HTML.

I assume this refers to:

<!-- logo -->
<div id="p-logo" role="banner"><a style="background-image: url(//upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png);" href="/wiki/Main_Page" title="Visit the main page"></a></div>
<!-- /logo -->

TheDJ set Security to None.
TheDJ added a subscriber: TheDJ.

We should probably move the content of the link from title to text content, and then use one of the text hiding routines, but text hiding routines are still 'problematic'.

We should probably define a mixin dedicated to that specific purpose, so we can more easily change the implementation if needed.

Change 262861 had a related patch set uploaded (by VolkerE):
Fix Vector's Logo Link for Assistive Technology

https://gerrit.wikimedia.org/r/262861

Volker_E renamed this task from Empty Link in the content section below Wikipedia logo can trip web content reader to Empty Wikipedia logo link can trip screen reader software.Apr 6 2016, 5:33 AM
Volker_E updated the task description. (Show Details)

I've prepared an exemplified before/after CodePen:
https://codepen.io/Volker_E/full/JXOeXj/

While we're at this task, we might be also thinking about using another notice than “Visit the main page” for all screen reader users.
For better clarifying which message is read when, I've changed the added link text, which is just visible for screen readers, itself to “Visit Wikipedia's main page”.

VoiceOver/OS X reads, when no link text is available, the title attribute's content and then a second time doesn't read on which link the focus is set. When the link text is available (2nd logo in example), it starts with link text content and then read's the title attribute's content.

And now it's getting a lil more complex: If we're going for that change, we should reconsider the first link in the portal navigation:

<a href="/wiki/Main_Page" title="Visit the main page [ctrl-option-z]" accesskey="z">Main page</a>

Would be good to know how many screen reader users make actual use of the provided access keys and don't circumvent using them because of problematic browser/OS implementation.

Change 262861 abandoned by VolkerE:
Make Vector's logo link support assistive technology

Reason:
Legacy Vector has an established mental model for screenreader users, it doesn't seem useful to pursue changing this possible actual output error anymore and instead pursue a different structure within Desktop Improvements project where we also ensure user testing of our assumptions with screenreader users. Exemplified Ibc4b055150761388a6b78f9127da342c451ce0e7

https://gerrit.wikimedia.org/r/262861

Jdlrobson added a subscriber: Jdlrobson.

Declining per https://phabricator.wikimedia.org/T39515#6098848 It confused me as I thought it was a bug about the new header so I fear this is just going to cause confusion if left open.