Maniphest T395182

Move threading.RLock to backports module
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	May 24 2025, 10:49 AM

Tags

Referenced Files

None

Subscribers

pywikibot-bugs-list

Description

Move threading.RLock to backports module

Reason:
pywikibot.threading.RLock was introduced with T151727 to implement compat's output cache. The only reason for this derived class was to have a locked() method which is used in terminal_interface_base.UI. With Python 3.14 this locked() method was implemented. The additional count property isn't used within the framework and can surely dropped if we went back to the standard Python implementation.

Steps

move pywikibot.threading.RLock to backports module and implement it for Python < 3.13
deprecate pywikibot.threading.RLock
deprecate (or remove) count property

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	IMPR: move tools.threading.RLock to backports module	pywikibot/core	master	+105 -69

Customize query in gerrit

Related Objects

Mentioned Here: T151727: Port cache_output from compat

Event Timeline

Xqt created this task.May 24 2025, 10:49 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptMay 24 2025, 10:49 AM

Xqt changed the task status from Open to In Progress.May 24 2025, 10:49 AM

Xqt triaged this task as Low priority.

Xqt moved this task from Backlog to Backwards compatibility on the Pywikibot board.

Change #1149817 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] IMPR: move tools.threading.RLock to backports module

https://gerrit.wikimedia.org/r/1149817

gerritbot added a project: Patch-For-Review.May 24 2025, 12:48 PM

Xqt moved this task from Backwards compatibility to Needs Review on the Pywikibot board.May 24 2025, 12:48 PM

Xqt updated the task description. (Show Details)May 29 2025, 2:30 PM

Change #1149817 merged by jenkins-bot:

[pywikibot/core@master] IMPR: move tools.threading.RLock to backports module

https://gerrit.wikimedia.org/r/1149817

Maintenance_bot removed a project: Patch-For-Review.May 31 2025, 10:30 AM

Xqt closed this task as Resolved.May 31 2025, 11:53 AM