Page MenuHomePhabricator
Create Task
Maniphest T395204

MediaWiki should log request information (IP, user agent, referrer, HTTP method, etc) in a more uniform and predictable way
Open, Needs TriagePublic
Actions

Description

We don't want to always log request PII such as IP or user agent (e.g. we don't want to have enough information in the logs to track a reader), but we want to log them for various security-sensitive or abuse-prone actions such as login. Currently this is happening in a very ad hoc fashion, which leads to a lot of code duplication, and inconsistencies (e.g. different names for the same data in the PSR-3 context, which then makes it very annoying to build dashboards).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
WebRequest::getSecurityLogContext: Log if user is a botmediawiki/coremaster+5 -1
WebRequest::getSecurityLogContext: Log if user is a botmediawiki/corewmf/1.46.0-wmf.11+5 -1
logger: Add client IP to logger contextmediawiki/coremaster+12 -2
Pass SecurityLogContext to loggeroperations/mediawiki-configmaster+12 -4
Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging"operations/mediawiki-configmaster+28 -24
Revert "Use GetSecurityLogContext hook for goodpass/badpass logging"operations/mediawiki-configmaster+24 -28
Fix GetSecurityLogContext hook declarationoperations/mediawiki-configmaster+1 -1
Use GetSecurityLogContext hook for goodpass/badpass loggingoperations/mediawiki-configmaster+28 -24
Unify logging of IP / user agent / etc on sensitive operationsmediawiki/coremaster+159 -10
Add global existence info on GetSecurityLogContext hookmediawiki/extensions/CentralAuthmaster+19 -5
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 25 2025, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2025, 2:33 PM
Tgr added a project: MediaWiki-User-login-and-signup.May 25 2025, 2:33 PM
Tgr added a comment.May 25 2025, 2:59 PM

Some examples of what's logged currently (per this search:

  • WebProcessor (added to all logs): url, http_method, referrer, reqId, ip (not the real IP though)
  • RateLimiter: name, ip
  • action API feature usage: username, clientip, agent, referer
  • AuthManager: user, clientip
  • SpamRegexConstraint in EditPage: ip
  • ChronologyProtector: clientIP, clientAgent
  • SessionManager / SessionBackend: clientip, user, userAgent
  • OATH: user / clientip
  • goodpass/badpass in Wikimedia config: name, user group / privilege information, clientip, xff, ua, geocookie
  • CentralAuth login: user, clientip, ua
  • IPReputation: ip
  • EmailAuth: user, ua, ip
  • EmailAuth (in WikimediaEvents): user, ua, ip, group / LoginNotify / IPoid / geocookie / 2FA / activity info
  • LoginNotify: name, ip / clientip, ua, xff, geocookie
  • OAuth: user, clientip
  • ConfirmEdit: user, clientip, ua
  • StopForumSpam: user, clientip
kostajh subscribed.May 25 2025, 6:06 PM

See also this patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1130543

kostajh added a comment.May 26 2025, 9:58 AM

https://doc.wikimedia.org/ecs/ contains a spec for most of these fields (xff and geocookie are not in ECS), so I think we could follow the ECS guidance for these.

gerritbot added a comment.May 26 2025, 11:13 AM

Change #1130543 had a related patch set uploaded (by Kosta Harlan; author: Máté Szabó):

[mediawiki/core@master] logger: Add client IP to logger context

https://gerrit.wikimedia.org/r/1130543

gerritbot added a project: Patch-For-Review.May 26 2025, 11:13 AM
kostajh renamed this task from MediaWiki should log request information (IP etc) in a more uniform and predictable way to MediaWiki should log request information (IP, user agent ) in a more uniform and predictable way.May 26 2025, 11:15 AM
kostajh renamed this task from MediaWiki should log request information (IP, user agent ) in a more uniform and predictable way to MediaWiki should log request information (IP, user agent, referrer, HTTP method, etc) in a more uniform and predictable way.
gerritbot added a comment.May 26 2025, 1:08 PM

Change #1150677 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] [WIP] Unify logging of IP / user agent / etc on sensitive operations

https://gerrit.wikimedia.org/r/1150677

Tgr added a comment.May 28 2025, 3:58 PM

We should also log whether the central and local account exists.

Tgr claimed this task.Jun 4 2025, 10:12 AM
Tgr added a project: MediaWiki-Platform-Team.
gerritbot added a comment.Jun 4 2025, 1:00 PM

Change #1153618 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] Add global existence info on GetSecurityLogContext hook

https://gerrit.wikimedia.org/r/1153618

gerritbot added a comment.Jun 4 2025, 1:29 PM

Change #1153626 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Use GetSecurityLogContext hook for goodpass/badpass logging

https://gerrit.wikimedia.org/r/1153626

matmarex moved this task from Inbox, needs triage to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.Jun 5 2025, 1:30 AM
Tgr added a comment.Jun 16 2025, 12:10 PM
In T395204#10856164, @kostajh wrote:

https://doc.wikimedia.org/ecs/ contains a spec for most of these fields (xff and geocookie are not in ECS), so I think we could follow the ECS guidance for these.

Ref: T234565: Standardize the logging format

I seem to recall a MediaWiki-specific subtask for that project which was declined, but I can't find anything like that so maybe I'm confabulating.

Anyway I think that's worth a separate task and a bigger discussion.

gerritbot added a comment.Jun 16 2025, 5:07 PM

Change #1150677 merged by jenkins-bot:

[mediawiki/core@master] Unify logging of IP / user agent / etc on sensitive operations

https://gerrit.wikimedia.org/r/1150677

gerritbot added a comment.Jun 16 2025, 5:07 PM

Change #1153618 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add global existence info on GetSecurityLogContext hook

https://gerrit.wikimedia.org/r/1153618

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.6; 2025-06-17).Jun 16 2025, 6:00 PM
gerritbot added a comment.Jun 17 2025, 1:10 PM

Change #1153626 merged by jenkins-bot:

[operations/mediawiki-config@master] Use GetSecurityLogContext hook for goodpass/badpass logging

https://gerrit.wikimedia.org/r/1153626

Stashbot added a comment.Jun 17 2025, 1:10 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:10:37Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1153626|Use GetSecurityLogContext hook for goodpass/badpass logging (T395204)]]

Stashbot added a comment.Jun 17 2025, 1:12 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:12:47Z] <tgr@deploy1003> tgr: Backport for [[gerrit:1153626|Use GetSecurityLogContext hook for goodpass/badpass logging (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

gerritbot added a comment.Jun 17 2025, 1:20 PM

Change #1160138 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Fix GetSecurityLogContext hook declaration

https://gerrit.wikimedia.org/r/1160138

gerritbot added a comment.Jun 17 2025, 1:22 PM

Change #1160138 merged by jenkins-bot:

[operations/mediawiki-config@master] Fix GetSecurityLogContext hook declaration

https://gerrit.wikimedia.org/r/1160138

Stashbot added a comment.Jun 17 2025, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:23:13Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1160138|Fix GetSecurityLogContext hook declaration (T395204)]]

Stashbot added a comment.Jun 17 2025, 1:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:25:26Z] <tgr@deploy1003> tgr: Backport for [[gerrit:1160138|Fix GetSecurityLogContext hook declaration (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 17 2025, 1:35 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:35:00Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1160138|Fix GetSecurityLogContext hook declaration (T395204)]] (duration: 11m 47s)

gerritbot added a comment.Jun 17 2025, 1:41 PM

Change #1160147 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Revert "Use GetSecurityLogContext hook for goodpass/badpass logging"

https://gerrit.wikimedia.org/r/1160147

gerritbot added a comment.Jun 17 2025, 1:42 PM

Change #1160147 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Use GetSecurityLogContext hook for goodpass/badpass logging"

https://gerrit.wikimedia.org/r/1160147

Stashbot added a comment.Jun 17 2025, 1:43 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:43:20Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1160147|Revert "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]]

Stashbot added a comment.Jun 17 2025, 1:45 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:45:32Z] <tgr@deploy1003> tgr: Backport for [[gerrit:1160147|Revert "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 17 2025, 1:50 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:50:36Z] <tgr> broke login for ~30 min by deploying the wrong patch (T395204)

Stashbot added a comment.Jun 17 2025, 1:53 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-17T13:53:45Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1160147|Revert "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]] (duration: 10m 24s)

gerritbot added a comment.Jun 17 2025, 2:05 PM

Change #1160157 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging"

https://gerrit.wikimedia.org/r/1160157

gerritbot added a comment.Jun 23 2025, 9:01 PM

Change #1160157 merged by jenkins-bot:

[operations/mediawiki-config@master] Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging"

https://gerrit.wikimedia.org/r/1160157

Stashbot mentioned this in T387600: IP Auto-reveal: Agree and implement metrics and instrumentation plan.Jun 23 2025, 9:01 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-23T21:01:54Z] <kharlan@deploy1003> Started scap sync-world: Backport for [[gerrit:1163004|Reapply "ores: Disable AbuseFilter integration by default" (T364705)]], [[gerrit:1155725|Configure event stream for IP auto-reveal instrument (T387600)]], [[gerrit:1160157|Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]]

Stashbot mentioned this in T364705: Provide AbuseFilter condition for revertrisk threshold.Jun 23 2025, 9:01 PM
Stashbot added a comment.Jun 23 2025, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-23T21:04:28Z] <kharlan@deploy1003> kharlan, tgr, tchanders: Backport for [[gerrit:1163004|Reapply "ores: Disable AbuseFilter integration by default" (T364705)]], [[gerrit:1155725|Configure event stream for IP auto-reveal instrument (T387600)]], [[gerrit:1160157|Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now

Stashbot added a comment.Jun 23 2025, 9:16 PM

Mentioned in SAL (#wikimedia-operations) [2025-06-23T21:16:46Z] <kharlan@deploy1003> Finished scap sync-world: Backport for [[gerrit:1163004|Reapply "ores: Disable AbuseFilter integration by default" (T364705)]], [[gerrit:1155725|Configure event stream for IP auto-reveal instrument (T387600)]], [[gerrit:1160157|Reapply "Use GetSecurityLogContext hook for goodpass/badpass logging" (T395204)]] (duration: 14m 51s)

Tgr mentioned this in T397754: Consider using Elastic Common Schema (ECS) in MediaWiki PSR-3 logs.Jun 24 2025, 6:04 PM
In T395204#10917984, @Tgr wrote:

Anyway I think that's worth a separate task and a bigger discussion.

T397754: Consider using Elastic Common Schema (ECS) in MediaWiki PSR-3 logs

Tgr mentioned this in T353339: Add support for dynamic placeholder replacement in logger..Jun 24 2025, 6:07 PM
gerritbot added a comment.Jun 25 2025, 7:10 AM

Change #1163633 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] Pass SecurityLogContext to logger

https://gerrit.wikimedia.org/r/1163633

gerritbot added a comment.Jun 25 2025, 8:15 AM

Change #1163633 merged by jenkins-bot:

[operations/mediawiki-config@master] Pass SecurityLogContext to logger

https://gerrit.wikimedia.org/r/1163633

Stashbot added a comment.Jun 25 2025, 8:15 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T08:15:41Z] <kharlan@deploy1003> Started scap sync-world: Backport for [[gerrit:1163633|Pass SecurityLogContext to logger (T395204)]]

Stashbot added a comment.Jun 25 2025, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T08:17:53Z] <kharlan@deploy1003> kharlan: Backport for [[gerrit:1163633|Pass SecurityLogContext to logger (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 25 2025, 8:28 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-25T08:28:01Z] <kharlan@deploy1003> Finished scap sync-world: Backport for [[gerrit:1163633|Pass SecurityLogContext to logger (T395204)]] (duration: 12m 19s)

Michael subscribed.Jul 4 2025, 8:29 PM
Tgr moved this task from In progress (DO NOT USE) to Next (DO NOT USE) on the MediaWiki-Platform-Team board.Sep 8 2025, 2:24 PM
Tgr added a comment.Oct 6 2025, 7:25 PM

Some tasks where inconsistent logging came up recently: T406431, T406430, T406434

colewhite subscribed.Oct 8 2025, 10:05 PM
gerritbot added a comment.Oct 28 2025, 5:01 PM

Change #1130543 abandoned by Kosta Harlan:

[mediawiki/core@master] logger: Add client IP to logger context

https://gerrit.wikimedia.org/r/1130543

gerritbot added a comment.Oct 28 2025, 5:01 PM

Change #1199471 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] WebRequest::getSecurityLogContext: Log if user is a bot

https://gerrit.wikimedia.org/r/1199471

OWresch-WMF edited projects, added MediaWiki-Platform-Team (Q3 Kanban Board); removed MediaWiki-Platform-Team.Nov 21 2025, 11:39 AM
Tgr mentioned this in T410878: wmfGetPrivilegedGroups is slow.Nov 24 2025, 11:34 AM
Tgr mentioned this in T407219: Enrich MediaWiki logs with IP reputation data in Logstash.Nov 30 2025, 10:22 AM
Tgr mentioned this in T412396: Pass through information about the client from the CDN to MediaWiki to Logstash.Dec 11 2025, 12:59 PM
gerritbot added a comment.Jan 15 2026, 9:13 AM

Change #1227265 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@wmf/1.46.0-wmf.11] WebRequest::getSecurityLogContext: Log if user is a bot

https://gerrit.wikimedia.org/r/1227265

gerritbot added a comment.Jan 15 2026, 9:26 AM

Change #1199471 merged by jenkins-bot:

[mediawiki/core@master] WebRequest::getSecurityLogContext: Log if user is a bot

https://gerrit.wikimedia.org/r/1199471

gerritbot added a comment.Jan 15 2026, 9:27 AM

Change #1227265 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.11] WebRequest::getSecurityLogContext: Log if user is a bot

https://gerrit.wikimedia.org/r/1227265

Stashbot added a comment.Jan 15 2026, 9:27 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-15T09:27:47Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1227265|WebRequest::getSecurityLogContext: Log if user is a bot (T395204)]]

Stashbot added a comment.Jan 15 2026, 9:29 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-15T09:29:53Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1227265|WebRequest::getSecurityLogContext: Log if user is a bot (T395204)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2026, 9:31 AM
Stashbot added a comment.Jan 15 2026, 9:36 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-15T09:36:51Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1227265|WebRequest::getSecurityLogContext: Log if user is a bot (T395204)]] (duration: 09m 04s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits