Steps to reproduce
- Add a non-existing file as a thumbnail (e.g. [[File:No such file|thumb]]).
- Preview it.
Actual result
The link to the non-existing file is black (both in dark and light mode).
Expected result
The link is red, just like any other (file or non-file) link to non-existing pages.
Note: This seems to work fine in Minerva skin, which uses its own styling for images (e.g. doesn't use the media ResourceLoader SkinModule).
QA steps
- Visit https://en.wikipedia.beta.wmflabs.org/wiki/T395206
- In dark mode and light mode "No such file" should be red.
- All images should be legible in dark and light mode.
- Visit https://en.wikipedia.beta.wmflabs.org/wiki/T395206?useskin=vector and confirm both "No such file" should be red. (thanks @A_smart_kitten)
Requirement
Broken file thumbnails should appear as redlinks across all skins, including Vector, not just Minerva. This ensures consistent styling for links to non-existent files.
BDD
Feature: Broken file thumbnail link styling Scenario: Broken thumbnail link is red across all skins Given I visit a page with a non-existent file thumbnail When I view the page in light mode Then the link to the file should appear in red Scenario: Broken thumbnail link is red in dark mode Given I view the page in dark mode When the page contains a broken file thumbnail Then the link should appear in red and the image alt text should remain legible Scenario: Broken thumbnail is styled consistently across skins Given I view the page in Minerva and Vector skins Then the broken file thumbnail is red in both skins
Test Steps
Test Case 1: Link for broken file is red in Vector skin (light mode)
- Visit https://en.wikipedia.beta.wmflabs.org/wiki/T395206
- Switch to light mode
- AC1: Confirm that "No such file" link is red (indicating a redlink)
Test Case 2: Link for broken file is red in Vector skin (dark mode)
- Visit https://en.wikipedia.beta.wmflabs.org/wiki/T395206
- Switch to dark mode
- AC2: Confirm that "No such file" link is red and visible
- AC3: Confirm that image placeholder and text are legible in dark mode
Test Case 3: Link for broken file is red in Legacy Vector skin
- Visit https://en.wikipedia.beta.wmflabs.org/wiki/T395206?useskin=vector
- AC4: Confirm that "No such file" link is red in both themes
- AC5: Confirm that image placeholder and text are legible
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ❌ | T395206#10873439 |
| 2 | ❌ | T395206#10873439 |
| 3 | ✅ | T395206#10873439 |
| 4 | ❌ | T395206#10873439 |
| 5 | ✅ | T395206#10873439 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T395206#10905358 |
| 2 | ✅ | T395206#10905358 |
| 3 | ✅ | T395206#10905358 |
| 4 | ✅ | T395206#10905358 |
| 5 | ✅ | T395206#10905358 |
